oops. grammar.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,69 +0,0 @@
-name: Bug Report
-description: File a bug report for Vichan
-title: "[BUG] "
-labels: ["bug"]
-assignees: []
-
-body:
-  - type: markdown
-    attributes:
-      value: |
-        **Thank you for reporting a bug! Please provide as much detail as possible.**
-        
-        Before submitting, check the [Vichan Wiki](https://vichan.info) to see if there's already a solution to your problem.
-
-  - type: textarea
-    id: bug_description
-    attributes:
-      label: "Describe the bug"
-      description: "A clear and concise description of what the bug is."
-      placeholder: "Posting doesn't go through and displays a collation error. The exact error message given is the text below and I've attached a screenshot..."
-    validations:
-      required: true
-
-  - type: textarea
-    id: steps_to_reproduce
-    attributes:
-      label: "Steps to Reproduce"
-      description: "Provide step-by-step instructions to reproduce the issue. If you're unsure on how, that is alright, just try and explain as well as you can."
-      placeholder: |
-        1. Go to '...'
-        2. Click on '....'
-        3. Scroll down to '....'
-        4. See error
-      render: markdown
-    validations:
-      required: true
-
-  - type: textarea
-    id: expected_behavior
-    attributes:
-      label: "Expected Behavior"
-      description: "What did you expect to happen?"
-      placeholder: "Expected behavior here..."
-      render: markdown
-    validations:
-      required: true
-
-  - type: textarea
-    id: server_specs
-    attributes:
-      label: "Server Specifications"
-      description: "Provide details about your server environment. If you're unsure about any of this, you might be using shared hosting (Hostinger, HostGator, Serv00, etc). If so, put the name of your hosting provider here."
-      placeholder: |
-        - OS: (Ubuntu, CentOS, Windows Server 2025, etc.)
-        - PHP Version: (e.g., 7.4, 8.0, 8.4)
-        - Web Server: (Apache, NGINX, etc.)
-        - Database: (MySQL, MariaDB, etc.)
-        - Vichan Version: (5.2.0, 5.3.0 (dev branch), etc)
-      render: markdown
-    validations:
-      required: true
-
-  - type: textarea
-    id: additional_context
-    attributes:
-      label: "Additional Context"
-      description: "Any other details we should know?"
-      placeholder: "Add any additional context here..."
-      render: markdown

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: ''
-labels: ''
-assignees: ''
-
----
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.

composer.json

@@ -18,8 +18,7 @@
         "gettext/gettext": "^5.5",
         "mrclay/minify": "^2.1.6",
         "geoip/geoip": "^1.17",
-        "dapphp/securimage": "^4.0",
+        "dapphp/securimage": "^4.0"
-        "erusev/parsedown":  "^1.7.4"
     },
     "autoload": {
         "classmap": ["inc/"],
@@ -34,13 +33,12 @@
             "inc/lock.php",
             "inc/queue.php",
             "inc/functions.php",
-            "inc/functions/dice.php",
-            "inc/functions/format.php",
             "inc/functions/net.php",
             "inc/functions/num.php",
-            "inc/functions/theme.php",
+            "inc/functions/format.php",
-            "inc/service/captcha-queries.php",
+            "inc/driver/http-driver.php",
-            "inc/context.php"
+            "inc/driver/log-driver.php",
+            "inc/service/captcha-queries.php"
         ]
     },
     "license": "Tinyboard + vichan",

docker-compose.yml

@@ -9,7 +9,7 @@ services:
     depends_on:
       - db
     volumes:
-      - ./local-instances/${INSTANCE:-0}/www:/var/www/html
+      - ./local-instances/1/www:/var/www/html
       - ./docker/nginx/vichan.conf:/etc/nginx/conf.d/default.conf
       - ./docker/nginx/nginx.conf:/etc/nginx/nginx.conf
       - ./docker/nginx/proxy.conf:/etc/nginx/conf.d/proxy.conf
@@ -21,7 +21,7 @@ services:
       context: .
       dockerfile: ./docker/php/Dockerfile
     volumes:
-      - ./local-instances/${INSTANCE:-0}/www:/var/www
+      - ./local-instances/1/www:/var/www
       - ./docker/php/www.conf:/usr/local/etc/php-fpm.d/www.conf
       - ./docker/php/jit.ini:/usr/local/etc/php/conf.d/jit.ini
 
@@ -37,4 +37,4 @@ services:
       MYSQL_DATABASE: vichan
       MYSQL_ROOT_PASSWORD: password
     volumes:
-      - ./local-instances/${INSTANCE:-0}/mysql:/var/lib/mysql
+      - ./local-instances/1/mysql:/var/lib/mysql

docker/php/Dockerfile

@@ -1,6 +1,6 @@
 # Based on https://github.com/dead-guru/devichan/blob/master/php-fpm/Dockerfile
 
-FROM composer:lts AS composer
+FROM composer AS composer
 FROM php:8.1-fpm-alpine
 
 RUN apk add --no-cache \
@@ -64,8 +64,7 @@ RUN apk add --no-cache \
         imagemagick-dev \
         pcre-dev \
         $PHPIZE_DEPS \
-    && rm -rf /var/cache/* \
+    && rm -rf /var/cache/*
-    && rm -rf /tmp/pear
 RUN rmdir /var/www/html \
     && install -d -m 744 -o www-data -g www-data /var/www \
     && install -d -m 700 -o www-data -g www-data /var/tmp/vichan \

inc/Data/Driver/ApcuCacheDriver.php

@@ -1,28 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-class ApcuCacheDriver implements CacheDriver {
-	public function get(string $key): mixed {
-		$success = false;
-		$ret = \apcu_fetch($key, $success);
-		if ($success === false) {
-			return null;
-		}
-		return $ret;
-	}
-
-	public function set(string $key, mixed $value, mixed $expires = false): void {
-		\apcu_store($key, $value, (int)$expires);
-	}
-
-	public function delete(string $key): void {
-		\apcu_delete($key);
-	}
-
-	public function flush(): void {
-		\apcu_clear_cache();
-	}
-}

inc/Data/Driver/ArrayCacheDriver.php

@@ -1,28 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-
-defined('TINYBOARD') or exit;
-
-/**
- * A simple process-wide PHP array.
- */
-class ArrayCacheDriver implements CacheDriver {
-	private static $inner = [];
-
-	public function get(string $key) {
-		return isset(self::$inner[$key]) ? self::$inner[$key] : null;
-	}
-
-	public function set(string $key, $value, $expires = false): void {
-		self::$inner[$key] = $value;
-	}
-
-	public function delete(string $key): void {
-		unset(self::$inner[$key]);
-	}
-
-	public function flush(): void {
-		self::$inner = [];
-	}
-}

inc/Data/Driver/CacheDriver.php

@@ -1,38 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-interface CacheDriver {
-        /**
-         * Get the value of associated with the key.
-         *
-         * @param string $key The key of the value.
-         * @return mixed|null The value associated with the key, or null if there is none.
-         */
-        public function get(string $key);
-
-        /**
-         * Set a key-value pair.
-         *
-         * @param string $key The key.
-         * @param mixed $value The value.
-         * @param int|false $expires After how many seconds the pair will expire. Use false or ignore this parameter to keep
-         *                           the value until it gets evicted to make space for more items. Some drivers will always
-         *                           ignore this parameter and store the pair until it's removed.
-         */
-        public function set(string $key, $value, $expires = false);
-
-        /**
-         * Delete a key-value pair.
-         *
-         * @param string $key The key.
-         */
-        public function delete(string $key);
-
-        /**
-         * Delete all the key-value pairs.
-         */
-        public function flush();
-}

inc/Data/Driver/ErrorLogLogDriver.php

@@ -1,28 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-/**
- * Log via the php function error_log.
- */
-class ErrorLogLogDriver implements LogDriver {
-	use LogTrait;
-
-	private string $name;
-	private int $level;
-
-	public function __construct(string $name, int $level) {
-		$this->name = $name;
-		$this->level = $level;
-	}
-
-	public function log(int $level, string $message): void {
-		if ($level <= $this->level) {
-			$lv = $this->levelToString($level);
-			$line = "{$this->name} $lv: $message";
-			\error_log($line, 0, null, null);
-		}
-	}
-}

inc/Data/Driver/FileLogDriver.php

@@ -1,61 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-/**
- * Log to a file.
- */
-class FileLogDriver implements LogDriver {
-	use LogTrait;
-
-	private string $name;
-	private int $level;
-	private mixed $fd;
-
-	public function __construct(string $name, int $level, string $file_path) {
-		/*
-		 * error_log is slow as hell in it's 3rd mode, so use fopen + file locking instead.
-		 * https://grobmeier.solutions/performance-ofnonblocking-write-to-files-via-php-21082009.html
-		 *
-		 * Whatever file appending is atomic is contentious:
-		 *  - There are no POSIX guarantees: https://stackoverflow.com/a/7237901
-		 *  - But linus suggested they are on linux, on some filesystems: https://web.archive.org/web/20151201111541/http://article.gmane.org/gmane.linux.kernel/43445
-		 *  - But it doesn't seem to be always the case: https://www.notthewizard.com/2014/06/17/are-files-appends-really-atomic/
-		 *
-		 * So we just use file locking to be sure.
-		 */
-
-		$this->fd = \fopen($file_path, 'a');
-		if ($this->fd === false) {
-			throw new \RuntimeException("Unable to open log file at $file_path");
-		}
-
-		$this->name = $name;
-		$this->level = $level;
-
-		// In some cases PHP does not run the destructor.
-		\register_shutdown_function([$this, 'close']);
-	}
-
-	public function __destruct() {
-		$this->close();
-	}
-
-	public function log(int $level, string $message): void {
-		if ($level <= $this->level) {
-			$lv = $this->levelToString($level);
-			$line = "{$this->name} $lv: $message\n";
-			\flock($this->fd, LOCK_EX);
-			\fwrite($this->fd, $line);
-			\fflush($this->fd);
-			\flock($this->fd, LOCK_UN);
-		}
-	}
-
-	public function close() {
-		\flock($this->fd, LOCK_UN);
-		\fclose($this->fd);
-	}
-}

inc/Data/Driver/FsCachedriver.php

@@ -1,155 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-class FsCacheDriver implements CacheDriver {
-	private string $prefix;
-	private string $base_path;
-	private mixed $lock_fd;
-	private int|false $collect_chance_den;
-
-
-	private function prepareKey(string $key): string {
-		$key = \str_replace('/', '::', $key);
-		$key = \str_replace("\0", '', $key);
-		return $this->prefix . $key;
-	}
-
-	private function sharedLockCache(): void {
-		\flock($this->lock_fd, LOCK_SH);
-	}
-
-	private function exclusiveLockCache(): void {
-		\flock($this->lock_fd, LOCK_EX);
-	}
-
-	private function unlockCache(): void {
-		\flock($this->lock_fd, LOCK_UN);
-	}
-
-	private function collectImpl(): int {
-		/*
-		 * A read lock is ok, since it's alright if we delete expired items from under the feet of other processes, and
-		 * no other process add new cache items or refresh existing ones.
-		 */
-		$files = \glob($this->base_path . $this->prefix . '*', \GLOB_NOSORT);
-		$count = 0;
-		foreach ($files as $file) {
-			$data = \file_get_contents($file);
-			$wrapped = \json_decode($data, true, 512, \JSON_THROW_ON_ERROR);
-			if ($wrapped['expires'] !== false && $wrapped['expires'] <= \time()) {
-				if (@\unlink($file)) {
-					$count++;
-				}
-			}
-		}
-		return $count;
-	}
-
-	private function maybeCollect(): void {
-		if ($this->collect_chance_den !== false && \mt_rand(0, $this->collect_chance_den - 1) === 0) {
-			$this->collect_chance_den = false; // Collect only once per instance (aka process).
-			$this->collectImpl();
-		}
-	}
-
-	public function __construct(string $prefix, string $base_path, string $lock_file, int|false $collect_chance_den) {
-		if ($base_path[\strlen($base_path) - 1] !== '/') {
-			$base_path = "$base_path/";
-		}
-
-		if (!\is_dir($base_path)) {
-			throw new \RuntimeException("$base_path is not a directory!");
-		}
-
-		if (!\is_writable($base_path)) {
-			throw new \RuntimeException("$base_path is not writable!");
-		}
-
-		$this->lock_fd = \fopen($base_path . $lock_file, 'w');
-		if ($this->lock_fd === false) {
-			throw new \RuntimeException('Unable to open the lock file!');
-		}
-
-		$this->prefix = $prefix;
-		$this->base_path = $base_path;
-		$this->collect_chance_den = $collect_chance_den;
-	}
-
-	public function __destruct() {
-		$this->close();
-	}
-
-	public function get(string $key): mixed {
-		$key = $this->prepareKey($key);
-
-		$this->sharedLockCache();
-
-		// Collect expired items first so if the target key is expired we shortcut to failure in the next lines.
-		$this->maybeCollect();
-
-		$fd = \fopen($this->base_path . $key, 'r');
-		if ($fd === false) {
-			$this->unlockCache();
-			return null;
-		}
-
-		$data = \stream_get_contents($fd);
-		\fclose($fd);
-		$this->unlockCache();
-		$wrapped = \json_decode($data, true, 512, \JSON_THROW_ON_ERROR);
-
-		if ($wrapped['expires'] !== false && $wrapped['expires'] <= \time()) {
-			// Already expired, leave it there since we already released the lock and pretend it doesn't exist.
-			return null;
-		} else {
-			return $wrapped['inner'];
-		}
-	}
-
-	public function set(string $key, mixed $value, mixed $expires = false): void {
-		$key = $this->prepareKey($key);
-
-		$wrapped = [
-			'expires' => $expires ? \time() + $expires : false,
-			'inner' => $value
-		];
-
-		$data = \json_encode($wrapped);
-		$this->exclusiveLockCache();
-		$this->maybeCollect();
-		\file_put_contents($this->base_path . $key, $data);
-		$this->unlockCache();
-	}
-
-	public function delete(string $key): void {
-		$key = $this->prepareKey($key);
-
-		$this->exclusiveLockCache();
-		@\unlink($this->base_path . $key);
-		$this->maybeCollect();
-		$this->unlockCache();
-	}
-
-	public function collect(): int {
-		$this->sharedLockCache();
-		$count = $this->collectImpl();
-		$this->unlockCache();
-		return $count;
-	}
-
-	public function flush(): void {
-		$this->exclusiveLockCache();
-		$files = \glob($this->base_path . $this->prefix . '*', \GLOB_NOSORT);
-		foreach ($files as $file) {
-			@\unlink($file);
-		}
-		$this->unlockCache();
-	}
-
-	public function close(): void {
-		\fclose($this->lock_fd);
-	}
-}

inc/Data/Driver/HttpDriver.php

@@ -1,131 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-/**
- * Honestly this is just a wrapper for cURL. Still useful to mock it and have an OOP API on PHP 7.
- */
-class HttpDriver {
-	private $inner;
-	private int $timeout;
-	private int $max_file_size;
-
-
-	private function resetTowards(string $url, int $timeout): void {
-		\curl_reset($this->inner);
-		\curl_setopt_array($this->inner, [
-			\CURLOPT_URL => $url,
-			\CURLOPT_TIMEOUT => $timeout,
-			\CURLOPT_USERAGENT => 'Tinyboard',
-			\CURLOPT_PROTOCOLS => \CURLPROTO_HTTP | \CURLPROTO_HTTPS,
-		]);
-	}
-
-	public function __construct(int $timeout, int $max_file_size) {
-		$this->inner = \curl_init();
-		$this->timeout = $timeout;
-		$this->max_file_size = $max_file_size;
-	}
-
-	public function __destruct() {
-		\curl_close($this->inner);
-	}
-
-	/**
-	 * Execute a GET request.
-	 *
-	 * @param string $endpoint Uri endpoint.
-	 * @param ?array $data Optional GET parameters.
-	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
-	 * @return string Returns the body of the response.
-	 * @throws RuntimeException Throws on IO error.
-	 */
-	public function requestGet(string $endpoint, ?array $data, int $timeout = 0): string {
-		if (!empty($data)) {
-			$endpoint .= '?' . \http_build_query($data);
-		}
-		if ($timeout == 0) {
-			$timeout = $this->timeout;
-		}
-
-		$this->resetTowards($endpoint, $timeout);
-		\curl_setopt($this->inner, \CURLOPT_RETURNTRANSFER, true);
-		$ret = \curl_exec($this->inner);
-
-		if ($ret === false) {
-			throw new \RuntimeException(\curl_error($this->inner));
-		}
-		return $ret;
-	}
-
-	/**
-	 * Execute a POST request.
-	 *
-	 * @param string $endpoint Uri endpoint.
-	 * @param ?array $data Optional POST parameters.
-	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
-	 * @return string Returns the body of the response.
-	 * @throws RuntimeException Throws on IO error.
-	 */
-	public function requestPost(string $endpoint, ?array $data, int $timeout = 0): string {
-		if ($timeout == 0) {
-			$timeout = $this->timeout;
-		}
-
-		$this->resetTowards($endpoint, $timeout);
-		\curl_setopt($this->inner, \CURLOPT_POST, true);
-		if (!empty($data)) {
-			\curl_setopt($this->inner, \CURLOPT_POSTFIELDS, \http_build_query($data));
-		}
-		\curl_setopt($this->inner, \CURLOPT_RETURNTRANSFER, true);
-		$ret = \curl_exec($this->inner);
-
-		if ($ret === false) {
-			throw new \RuntimeException(\curl_error($this->inner));
-		}
-		return $ret;
-	}
-
-	/**
-	 * Download the url's target with curl.
-	 *
-	 * @param string $url Url to the file to download.
-	 * @param ?array $data Optional GET parameters.
-	 * @param resource $fd File descriptor to save the content to.
-	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
-	 * @return bool Returns true on success, false if the file was too large.
-	 * @throws RuntimeException Throws on IO error.
-	 */
-	public function requestGetInto(string $endpoint, ?array $data, $fd, int $timeout = 0): bool {
-		if (!empty($data)) {
-			$endpoint .= '?' . \http_build_query($data);
-		}
-		if ($timeout == 0) {
-			$timeout = $this->timeout;
-		}
-
-		$this->resetTowards($endpoint, $timeout);
-		// Adapted from: https://stackoverflow.com/a/17642638
-		$opt = (\PHP_MAJOR_VERSION >= 8 && \PHP_MINOR_VERSION >= 2) ? \CURLOPT_XFERINFOFUNCTION : \CURLOPT_PROGRESSFUNCTION;
-		\curl_setopt_array($this->inner, [
-			\CURLOPT_NOPROGRESS => false,
-			$opt => fn($res, $next_dl, $dl, $next_up, $up) => (int)($dl <= $this->max_file_size),
-			\CURLOPT_FAILONERROR => true,
-			\CURLOPT_FOLLOWLOCATION => false,
-			\CURLOPT_FILE => $fd,
-			\CURLOPT_IPRESOLVE => CURL_IPRESOLVE_V4,
-		]);
-		$ret = \curl_exec($this->inner);
-
-		if ($ret === false) {
-			if (\curl_errno($this->inner) === CURLE_ABORTED_BY_CALLBACK) {
-				return false;
-			}
-
-			throw new \RuntimeException(\curl_error($this->inner));
-		}
-		return true;
-	}
-}

inc/Data/Driver/LogDriver.php

@@ -1,22 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-interface LogDriver {
-	public const EMERG = \LOG_EMERG;
-	public const ERROR = \LOG_ERR;
-	public const WARNING = \LOG_WARNING;
-	public const NOTICE = \LOG_NOTICE;
-	public const INFO = \LOG_INFO;
-	public const DEBUG = \LOG_DEBUG;
-
-	/**
-	 * Log a message if the level of relevancy is at least the minimum.
-	 *
-	 * @param int $level Message level. Use Log interface constants.
-	 * @param string $message The message to log.
-	 */
-	public function log(int $level, string $message): void;
-}

inc/Data/Driver/LogTrait.php

@@ -1,26 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-trait LogTrait {
-	public static function levelToString(int $level): string {
-		switch ($level) {
-			case LogDriver::EMERG:
-				return 'EMERG';
-			case LogDriver::ERROR:
-				return 'ERROR';
-			case LogDriver::WARNING:
-				return 'WARNING';
-			case LogDriver::NOTICE:
-				return 'NOTICE';
-			case LogDriver::INFO:
-				return 'INFO';
-			case LogDriver::DEBUG:
-				return 'DEBUG';
-			default:
-				throw new \InvalidArgumentException('Not a logging level');
-		}
-	}
-}

inc/Data/Driver/MemcacheCacheDriver.php

@@ -1,43 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-class MemcachedCacheDriver implements CacheDriver {
-	private \Memcached $inner;
-
-	public function __construct(string $prefix, string $memcached_server) {
-		$this->inner = new \Memcached();
-		if (!$this->inner->setOption(\Memcached::OPT_BINARY_PROTOCOL, true)) {
-			throw new \RuntimeException('Unable to set the memcached protocol!');
-		}
-		if (!$this->inner->setOption(\Memcached::OPT_PREFIX_KEY, $prefix)) {
-			throw new \RuntimeException('Unable to set the memcached prefix!');
-		}
-		if (!$this->inner->addServers($memcached_server)) {
-			throw new \RuntimeException('Unable to add the memcached server!');
-		}
-	}
-
-	public function get(string $key): mixed {
-		$ret = $this->inner->get($key);
-		// If the returned value is false but the retrival was a success, then the value stored was a boolean false.
-		if ($ret === false && $this->inner->getResultCode() !== \Memcached::RES_SUCCESS) {
-			return null;
-		}
-		return $ret;
-	}
-
-	public function set(string $key, mixed $value, mixed $expires = false): void {
-		$this->inner->set($key, $value, (int)$expires);
-	}
-
-	public function delete(string $key): void {
-		$this->inner->delete($key);
-	}
-
-	public function flush(): void {
-		$this->inner->flush();
-	}
-}

inc/Data/Driver/NoneCacheDriver.php

@@ -1,26 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-/**
- * No-op cache. Useful for testing.
- */
-class NoneCacheDriver implements CacheDriver {
-	public function get(string $key): mixed {
-		return null;
-	}
-
-	public function set(string $key, mixed $value, mixed $expires = false): void {
-		// No-op.
-	}
-
-	public function delete(string $key): void {
-		// No-op.
-	}
-
-	public function flush(): void {
-		// No-op.
-	}
-}

inc/Data/Driver/RedisCacheDriver.php

@@ -1,48 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-class RedisCacheDriver implements CacheDriver {
-	private string $prefix;
-	private \Redis $inner;
-
-	public function __construct(string $prefix, string $host, int $port, ?string $password, string $database) {
-		$this->inner = new \Redis();
-		$this->inner->connect($host, $port);
-		if ($password) {
-			$this->inner->auth($password);
-		}
-		if (!$this->inner->select($database)) {
-			throw new \RuntimeException('Unable to connect to Redis!');
-		}
-
-		$$this->prefix = $prefix;
-	}
-
-	public function get(string $key): mixed {
-		$ret = $this->inner->get($this->prefix . $key);
-		if ($ret === false) {
-			return null;
-		}
-		return \json_decode($ret, true);
-	}
-
-	public function set(string $key, mixed $value, mixed $expires = false): void {
-		if ($expires === false) {
-			$this->inner->set($this->prefix . $key, \json_encode($value));
-		} else {
-			$expires = $expires * 1000; // Seconds to milliseconds.
-			$this->inner->setex($this->prefix . $key, $expires, \json_encode($value));
-		}
-	}
-
-	public function delete(string $key): void {
-		$this->inner->del($this->prefix . $key);
-	}
-
-	public function flush(): void {
-		$this->inner->flushDB();
-	}
-}

inc/Data/Driver/StderrLogDriver.php

@@ -1,27 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-
-/**
- * Log to php's standard error file stream.
- */
-class StderrLogDriver implements LogDriver {
-	use LogTrait;
-
-	private string $name;
-	private int $level;
-
-	public function __construct(string $name, int $level) {
-		$this->name = $name;
-		$this->level = $level;
-	}
-
-	public function log(int $level, string $message): void {
-		if ($level <= $this->level) {
-			$lv = $this->levelToString($level);
-			\fwrite(\STDERR, "{$this->name} $lv: $message\n");
-		}
-	}
-}

inc/Data/Driver/SyslogLogDriver.php

@@ -1,35 +0,0 @@
-<?php
-namespace Vichan\Data\Driver;
-
-defined('TINYBOARD') or exit;
-
-/**
- * Log to syslog.
- */
-class SyslogLogDriver implements LogDriver {
-	private int $level;
-
-	public function __construct(string $name, int $level, bool $print_stderr) {
-		$flags = \LOG_ODELAY;
-		if ($print_stderr) {
-			$flags |= \LOG_PERROR;
-		}
-
-		if (!\openlog($name, $flags, \LOG_USER)) {
-			throw new \RuntimeException('Unable to open syslog');
-		}
-
-		$this->level = $level;
-	}
-
-	public function log(int $level, string $message): void {
-		if ($level <= $this->level) {
-			if (isset($_SERVER['REMOTE_ADDR'], $_SERVER['REQUEST_METHOD'], $_SERVER['REQUEST_URI'])) {
-				// CGI
-				\syslog($level, "$message - client: {$_SERVER['REMOTE_ADDR']}, request: \"{$_SERVER['REQUEST_METHOD']} {$_SERVER['REQUEST_URI']}\"");
-			} else {
-				\syslog($level, $message);
-			}
-		}
-	}
-}

inc/anti-bot.php

@@ -1,5 +1,191 @@
 <?php
 
 /*
- *  Anti-bot.php has been deprecated and removed due to its functions not being necessary and being easily bypassable, by both customized and uncustomized spambots.
+ *  Copyright (c) 2010-2013 Tinyboard Development Group
  */
+
+defined('TINYBOARD') or exit;
+
+$hidden_inputs_twig = array();
+
+class AntiBot {
+	public $salt, $inputs = array(), $index = 0;
+	
+	public static function randomString($length, $uppercase = false, $special_chars = false, $unicode_chars = false) {
+		$chars = 'abcdefghijklmnopqrstuvwxyz0123456789';
+		if ($uppercase)
+			$chars .= 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
+		if ($special_chars)
+			$chars .= ' ~!@#$%^&*()_+,./;\'[]\\{}|:<>?=-` ';
+		if ($unicode_chars) {
+			$len = strlen($chars) / 10;
+			for ($n = 0; $n < $len; $n++)
+				$chars .= mb_convert_encoding('&#' . mt_rand(0x2600, 0x26FF) . ';', 'UTF-8', 'HTML-ENTITIES');
+		}
+		
+		$chars = preg_split('//u', $chars, -1, PREG_SPLIT_NO_EMPTY);
+		
+		$ch = array();
+		
+		// fill up $ch until we reach $length
+		while (count($ch) < $length) {
+			$n = $length - count($ch);
+			$keys = array_rand($chars, $n > count($chars) ? count($chars) : $n);
+			if ($n == 1) {
+				$ch[] = $chars[$keys];
+				break;
+			}
+			shuffle($keys);
+			foreach ($keys as $key)
+				$ch[] = $chars[$key];
+		}
+		
+		$chars = $ch;
+		
+		return implode('', $chars);
+	}
+	
+	public static function make_confusing($string) {
+		$chars = preg_split('//u', $string, -1, PREG_SPLIT_NO_EMPTY);
+		
+		foreach ($chars as &$c) {
+			if (mt_rand(0, 3) != 0)
+				$c = utf8tohtml($c);
+			else
+				$c = mb_encode_numericentity($c, array(0, 0xffff, 0, 0xffff), 'UTF-8');
+		}
+		
+		return implode('', $chars);
+	}
+	
+	public function __construct(array $salt = array()) {
+		global $config;
+		
+		if (!empty($salt)) {
+			// create a salted hash of the "extra salt"
+			$this->salt = implode(':', $salt);
+		} else { 
+			$this->salt = '';
+		}
+		
+		shuffle($config['spam']['hidden_input_names']);
+		
+		$input_count = mt_rand($config['spam']['hidden_inputs_min'], $config['spam']['hidden_inputs_max']);
+		$hidden_input_names_x = 0;
+		
+		for ($x = 0; $x < $input_count ; $x++) {
+			if ($hidden_input_names_x === false || mt_rand(0, 2) == 0) {
+				// Use an obscure name
+				$name = $this->randomString(mt_rand(10, 40), false, false, $config['spam']['unicode']);
+			} else {
+				// Use a pre-defined confusing name
+				$name = $config['spam']['hidden_input_names'][$hidden_input_names_x++];
+				if ($hidden_input_names_x >= count($config['spam']['hidden_input_names']))
+					$hidden_input_names_x = false;
+			}
+			
+			if (mt_rand(0, 2) == 0) {
+				// Value must be null
+				$this->inputs[$name] = '';
+			} elseif (mt_rand(0, 4) == 0) {
+				// Numeric value
+				$this->inputs[$name] = (string)mt_rand(0, 100000);
+			} else {
+				// Obscure value
+				$this->inputs[$name] = $this->randomString(mt_rand(5, 100), true, true, $config['spam']['unicode']);
+			}
+		}
+	}
+	
+	public static function space() {
+		if (mt_rand(0, 3) != 0)
+			return ' ';
+		return str_repeat(' ', mt_rand(1, 3));
+	}
+	
+	public function html($count = false) {
+		global $config;
+		
+		$elements = array(
+			'<input type="hidden" name="%name%" value="%value%">',
+			'<input type="hidden" value="%value%" name="%name%">',
+			'<input name="%name%" value="%value%" type="hidden">',
+			'<input value="%value%" name="%name%" type="hidden">',
+			'<input style="display:none" type="text" name="%name%" value="%value%">',
+			'<input style="display:none" type="text" value="%value%" name="%name%">',
+			'<span style="display:none"><input type="text" name="%name%" value="%value%"></span>',
+			'<div style="display:none"><input type="text" name="%name%" value="%value%"></div>',
+			'<div style="display:none"><input type="text" name="%name%" value="%value%"></div>',
+			'<textarea style="display:none" name="%name%">%value%</textarea>',
+			'<textarea name="%name%" style="display:none">%value%</textarea>'
+		);
+		
+		$html = '';
+		
+		if ($count === false) {
+			$count = mt_rand(1, (int)abs(count($this->inputs) / 15) + 1);
+		}
+		
+		if ($count === true) {
+			// all elements
+			$inputs = array_slice($this->inputs, $this->index);
+		} else {
+			$inputs = array_slice($this->inputs, $this->index, $count);
+		}
+		$this->index += count($inputs);
+		
+		foreach ($inputs as $name => $value) {
+			$element = false;
+			while (!$element) {
+				$element = $elements[array_rand($elements)];
+				$element = str_replace(' ', self::space(), $element);
+				if (mt_rand(0, 5) == 0)
+					$element = str_replace('>', self::space() . '>', $element);
+				if (strpos($element, 'textarea') !== false && $value == '') {
+					// There have been some issues with mobile web browsers and empty <textarea>'s.
+					$element = false;
+				}
+			}
+			
+			$element = str_replace('%name%', utf8tohtml($name), $element);
+			
+			if (mt_rand(0, 2) == 0)
+				$value = $this->make_confusing($value);
+			else
+				$value = utf8tohtml($value);
+			
+			if (strpos($element, 'textarea') === false)
+				$value = str_replace('"', '&quot;', $value);
+			
+			$element = str_replace('%value%', $value, $element);
+			
+			$html .= $element;
+		}
+		
+		return $html;
+	}
+	
+	public function reset() {
+		$this->index = 0;
+	}
+	
+	public function hash() {
+		global $config;
+		
+		// This is the tricky part: create a hash to validate it after
+		// First, sort the keys in alphabetical order (A-Z)
+		$inputs = $this->inputs;
+		ksort($inputs);
+		
+		$hash = '';
+		// Iterate through each input
+		foreach ($inputs as $name => $value) {
+			$hash .= $name . '=' . $value;
+		}
+		// Add a salt to the hash
+		$hash .= $config['cookies']['salt'];
+		
+		// Use SHA1 for the hash
+		return sha1($hash . $this->salt);
+	}
+}

inc/api.php

@@ -9,49 +9,14 @@ defined('TINYBOARD') or exit;
  * Class for generating json API compatible with 4chan API
  */
 class Api {
-	private bool $show_filename;
+	function __construct(){
-	private bool $hide_email;
+		global $config;
-	private bool $country_flags;
+		/**
-	private array $postFields;
+		 * Translation from local fields to fields in 4chan-style API
+		 */
+		$this->config = $config;
 
-	private const INTS = [
+		$this->postFields = array(
-		'no' => 1,
-		'resto' => 1,
-		'time' => 1,
-		'tn_w' => 1,
-		'tn_h' => 1,
-		'w' => 1,
-		'h' => 1,
-		'fsize' => 1,
-		'omitted_posts' => 1,
-		'omitted_images' => 1,
-		'replies' => 1,
-		'images' => 1,
-		'sticky' => 1,
-		'locked' => 1,
-		'last_modified' => 1
-	];
-
-	private const THREADS_PAGE_FIELDS = [
-		'id' => 'no',
-		'bump' => 'last_modified'
-	];
-
-	private const FILE_FIELDS = [
-		'thumbheight' => 'tn_h',
-		'thumbwidth' => 'tn_w',
-		'height' => 'h',
-		'width' => 'w',
-		'size' => 'fsize'
-	];
-
-	public function __construct(bool $show_filename, bool $hide_email, bool $country_flags) {
-		// Translation from local fields to fields in 4chan-style API
-		$this->show_filename = $show_filename;
-		$this->hide_email = $hide_email;
-		$this->country_flags = $country_flags;
-
-		$this->postFields = [
 			'id' => 'no',
 			'thread' => 'resto',
 			'subject' => 'sub',
@@ -70,65 +35,91 @@ class Api {
 			'cycle' => 'cyclical',
 			'bump' => 'last_modified',
 			'embed' => 'embed',
-		];
+		);
+
+		$this->threadsPageFields = array(
+			'id' => 'no',
+			'bump' => 'last_modified'
+		);
+
+		$this->fileFields = array(
+			'thumbheight' => 'tn_h',
+			'thumbwidth' => 'tn_w',
+			'height' => 'h',
+			'width' => 'w',
+			'size' => 'fsize',
+		);
 
 		if (isset($config['api']['extra_fields']) && gettype($config['api']['extra_fields']) == 'array'){
 			$this->postFields = array_merge($this->postFields, $config['api']['extra_fields']);
 		}
 	}
 
+	private static $ints = array(
+		'no' => 1,
+		'resto' => 1,
+		'time' => 1,
+		'tn_w' => 1,
+		'tn_h' => 1,
+		'w' => 1,
+		'h' => 1,
+		'fsize' => 1,
+		'omitted_posts' => 1,
+		'omitted_images' => 1,
+		'replies' => 1,
+		'images' => 1,
+		'sticky' => 1,
+		'locked' => 1,
+		'last_modified' => 1
+	);
+
 	private function translateFields($fields, $object, &$apiPost) {
 		foreach ($fields as $local => $translated) {
-			if (!isset($object->$local)) {
+			if (!isset($object->$local))
 				continue;
-			}
 
-			$toInt = isset(self::INTS[$translated]);
+			$toInt = isset(self::$ints[$translated]);
 			$val = $object->$local;
-			if ($this->hide_email && $local === 'email') {
+			if (isset($this->config['hide_email']) && $this->config['hide_email'] && $local === 'email') {
 				$val = '';
 			}
 			if ($val !== null && $val !== '') {
 				$apiPost[$translated] = $toInt ? (int) $val : $val;
 			}
+
 		}
 	}
 
 	private function translateFile($file, $post, &$apiPost) {
-		$this->translateFields(self::FILE_FIELDS, $file, $apiPost);
+		$this->translateFields($this->fileFields, $file, $apiPost);
 		$dotPos = strrpos($file->file, '.');
 		$apiPost['ext'] = substr($file->file, $dotPos);
 		$apiPost['tim'] = substr($file->file, 0, $dotPos);
-
+		if (isset($this->config['show_filename']) && $this->config['show_filename']) {
-		if ($this->show_filename) {
 			$apiPost['filename'] = @substr($file->name, 0, strrpos($file->name, '.'));
-		} else {
+		}
+		else {
 			$apiPost['filename'] = substr($file->file, 0, $dotPos);
 		}
 		if (isset ($file->hash) && $file->hash) {
 			$apiPost['md5'] = base64_encode(hex2bin($file->hash));
-		} elseif (isset ($post->filehash) && $post->filehash) {
+		}
+		else if (isset ($post->filehash) && $post->filehash) {
 			$apiPost['md5'] = base64_encode(hex2bin($post->filehash));
 		}
 	}
 
-	private function translatePost($post, bool $threadsPage = false) {
+	private function translatePost($post, $threadsPage = false) {
 		global $config, $board;
-
+		$apiPost = array();
-		$apiPost = [];
+		$fields = $threadsPage ? $this->threadsPageFields : $this->postFields;
-		$fields = $threadsPage ? self::THREADS_PAGE_FIELDS : $this->postFields;
 		$this->translateFields($fields, $post, $apiPost);
 
-
+		if (isset($config['poster_ids']) && $config['poster_ids']) $apiPost['id'] = poster_id($post->ip, $post->thread, $board['uri']);
-		if (isset($config['poster_ids']) && $config['poster_ids']) {
+		if ($threadsPage) return $apiPost;
-			$apiPost['id'] = poster_id($post->ip, $post->thread ?? $post->id);
-		}
-		if ($threadsPage) {
-			return $apiPost;
-		}
 
 		// Handle country field
-		if (isset($post->body_nomarkup) && $this->country_flags) {
+		if (isset($post->body_nomarkup) && $this->config['country_flags']) {
 			$modifiers = extract_modifiers($post->body_nomarkup);
 			if (isset($modifiers['flag']) && isset($modifiers['flag alt']) && preg_match('/^[a-z]{2}$/', $modifiers['flag'])) {
 				$country = strtoupper($modifiers['flag']);
@@ -148,15 +139,12 @@ class Api {
 		if (isset($post->files) && $post->files && !$threadsPage) {
 			$file = $post->files[0];
 			$this->translateFile($file, $post, $apiPost);
-
 			if (sizeof($post->files) > 1) {
-				$extra_files = [];
+				$extra_files = array();
 				foreach ($post->files as $i => $f) {
-					if ($i == 0) {
+					if ($i == 0) continue;
-						continue;
-					}
 				
-					$extra_file = [];
+					$extra_file = array();
 					$this->translateFile($f, $post, $extra_file);
 
 					$extra_files[] = $extra_file;
@@ -168,8 +156,8 @@ class Api {
 		return $apiPost;
 	}
 
-	public function translateThread(Thread $thread, bool $threadsPage = false) {
+	function translateThread(Thread $thread, $threadsPage = false) {
-		$apiPosts = [];
+		$apiPosts = array();
 		$op = $this->translatePost($thread, $threadsPage);
 		if (!$threadsPage) $op['resto'] = 0;
 		$apiPosts['posts'][] = $op;
@@ -181,16 +169,16 @@ class Api {
 		return $apiPosts;
 	}
 
-	public function translatePage(array $threads) {
+	function translatePage(array $threads) {
-		$apiPage = [];
+		$apiPage = array();
 		foreach ($threads as $thread) {
 			$apiPage['threads'][] = $this->translateThread($thread);
 		}
 		return $apiPage;
 	}
 
-	public function translateCatalogPage(array $threads, bool $threadsPage = false) {
+	function translateCatalogPage(array $threads, $threadsPage = false) {
-		$apiPage = [];
+		$apiPage = array();
 		foreach ($threads as $thread) {
 			$ts = $this->translateThread($thread, $threadsPage);
 			$apiPage['threads'][] = current($ts['posts']);
@@ -198,8 +186,8 @@ class Api {
 		return $apiPage;
 	}
 
-	public function translateCatalog($catalog, bool $threadsPage = false) {
+	function translateCatalog($catalog, $threadsPage = false) {
-		$apiCatalog = [];
+		$apiCatalog = array();
 		foreach ($catalog as $page => $threads) {
 			$apiPage = $this->translateCatalogPage($threads, $threadsPage);
 			$apiPage['page'] = $page;

inc/bans.php

@@ -4,10 +4,6 @@ use Vichan\Functions\Format;
 use Lifo\IP\CIDR;
 
 class Bans {
-	static private function shouldDelete(array $ban, bool $require_ban_view) {
-		return $ban['expires'] && ($ban['seen'] || !$require_ban_view) && $ban['expires'] < time();
-	}
-
 	static private function deleteBans(array $ban_ids) {
 		$len = count($ban_ids);
 		if ($len === 1) {
@@ -15,7 +11,7 @@ class Bans {
 			$query->bindValue(':id', $ban_ids[0], PDO::PARAM_INT);
 			$query->execute() or error(db_error());
 
-			Vichan\Functions\Theme\rebuild_themes('bans');
+			rebuildThemes('bans');
 		} elseif ($len >= 1) {
 			// Build the query.
 			$query = 'DELETE FROM ``bans`` WHERE `id` IN (';
@@ -33,131 +29,10 @@ class Bans {
 
 			$query->execute() or error(db_error());
 
-			Vichan\Functions\Theme\rebuild_themes('bans');
+			rebuildThemes('bans');
 		}
 	}
 
-	static private function findSingleAutoGc(string $ip, int $ban_id, bool $require_ban_view) {
-		// Use OR in the query to also garbage collect bans.
-		$query = prepare(
-			'SELECT ``bans``.* FROM ``bans``
-			 WHERE ((`ipstart` = :ip OR (:ip >= `ipstart` AND :ip <= `ipend`)) OR (``bans``.id = :id))
-			 ORDER BY `expires` IS NULL, `expires` DESC'
-		);
-
-		$query->bindValue(':id', $ban_id);
-		$query->bindValue(':ip', inet_pton($ip));
-
-		$query->execute() or error(db_error($query));
-
-		$found_ban = null;
-		$to_delete_list = [];
-
-		while ($ban = $query->fetch(PDO::FETCH_ASSOC)) {
-			if (self::shouldDelete($ban, $require_ban_view)) {
-				$to_delete_list[] = $ban['id'];
-			} elseif ($ban['id'] === $ban_id) {
-				if ($ban['post']) {
-					$ban['post'] = json_decode($ban['post'], true);
-				}
-				$ban['mask'] = self::range_to_string([$ban['ipstart'], $ban['ipend']]);
-				$found_ban = $ban;
-			}
-		}
-
-		self::deleteBans($to_delete_list);
-
-		return $found_ban;
-	}
-
-	static private function findSingleNoGc(int $ban_id) {
-		$query = prepare(
-			'SELECT ``bans``.* FROM ``bans``
-			 WHERE ``bans``.id = :id
-			 ORDER BY `expires` IS NULL, `expires` DESC
-			 LIMIT 1'
-		);
-
-		$query->bindValue(':id', $ban_id);
-
-		$query->execute() or error(db_error($query));
-		$ret = $query->fetch(PDO::FETCH_ASSOC);
-		if ($query->rowCount() == 0) {
-			return null;
-		} else {
-			if ($ret['post']) {
-				$ret['post'] = json_decode($ret['post'], true);
-			}
-			$ret['mask'] = self::range_to_string([$ret['ipstart'], $ret['ipend']]);
-
-			return $ret;
-		}
-	}
-
-	static private function findAutoGc(?string $ip, $board, bool $get_mod_info, bool $require_ban_view, ?int $ban_id): array {
-		$query = prepare('SELECT ``bans``.*' . ($get_mod_info ? ', `username`' : '') . ' FROM ``bans``
-		' . ($get_mod_info ? 'LEFT JOIN ``mods`` ON ``mods``.`id` = `creator`' : '') . '
-		WHERE
-			(' . ($board !== false ? '(`board` IS NULL OR `board` = :board) AND' : '') . '
-			(`ipstart` = :ip OR (:ip >= `ipstart` AND :ip <= `ipend`)) OR (``bans``.id = :id))
-		ORDER BY `expires` IS NULL, `expires` DESC');
-
-		if ($board !== false) {
-			$query->bindValue(':board', $board, PDO::PARAM_STR);
-		}
-
-		$query->bindValue(':id', $ban_id);
-		$query->bindValue(':ip', inet_pton($ip));
-		$query->execute() or error(db_error($query));
-
-		$ban_list = [];
-		$to_delete_list = [];
-
-		while ($ban = $query->fetch(PDO::FETCH_ASSOC)) {
-			if (self::shouldDelete($ban, $require_ban_view)) {
-				$to_delete_list[] = $ban['id'];
-			} else {
-				if ($ban['post']) {
-					$ban['post'] = json_decode($ban['post'], true);
-				}
-				$ban['mask'] = self::range_to_string([$ban['ipstart'], $ban['ipend']]);
-				$ban_list[] = $ban;
-			}
-		}
-
-		self::deleteBans($to_delete_list);
-
-		return $ban_list;
-	}
-
-	static private function findNoGc(?string $ip, string $board, bool $get_mod_info, ?int $ban_id): array {
-		$query = prepare('SELECT ``bans``.*' . ($get_mod_info ? ', `username`' : '') . ' FROM ``bans``
-		' . ($get_mod_info ? 'LEFT JOIN ``mods`` ON ``mods``.`id` = `creator`' : '') . '
-		WHERE
-			(' . ($board !== false ? '(`board` IS NULL OR `board` = :board) AND' : '') . '
-			(`ipstart` = :ip OR (:ip >= `ipstart` AND :ip <= `ipend`)) OR (``bans``.id = :id))
-			AND (`expires` IS NULL OR `expires` >= :curr_time)
-		ORDER BY `expires` IS NULL, `expires` DESC');
-
-		if ($board !== false) {
-			$query->bindValue(':board', $board, PDO::PARAM_STR);
-		}
-
-		$query->bindValue(':id', $ban_id);
-		$query->bindValue(':ip', inet_pton($ip));
-		$query->bindValue(':curr_time', time());
-		$query->execute() or error(db_error($query));
-
-		$ban_list = $query->fetchAll(PDO::FETCH_ASSOC);
-		array_walk($ban_list, function (&$ban, $_index) {
-			if ($ban['post']) {
-				$ban['post'] = json_decode($ban['post'], true);
-			}
-			$ban['mask'] = self::range_to_string([$ban['ipstart'], $ban['ipend']]);
-		});
-		return $ban_list;
-	}
-
 	static public function range_to_string($mask) {
 		list($ipstart, $ipend) = $mask;
 
@@ -181,7 +56,7 @@ class Bans {
 		$cidr = new CIDR($mask);
 		$range = $cidr->getRange();
 
-		return [ inet_pton($range[0]), inet_pton($range[1]) ];
+		return array(inet_pton($range[0]), inet_pton($range[1]));
 	}
 
 	public static function parse_time($str) {
@@ -265,27 +140,84 @@ class Bans {
 				return false;
 		}
 
-		return [$ipstart, $ipend];
+		return array($ipstart, $ipend);
 	}
 
-	static public function findSingle(string $ip, int $ban_id, bool $require_ban_view, bool $auto_gc) {
+	static public function findSingle(string $ip, int $ban_id, bool $require_ban_view): array|null {
-		if ($auto_gc) {
+		/**
-			return self::findSingleAutoGc($ip, $ban_id, $require_ban_view);
+		 * Use OR in the query to also garbage collect bans. Ideally we should move the whole GC procedure to a separate
-		} else {
+		 * script, but it will require a more important restructuring.
-			return self::findSingleNoGc($ban_id);
+		 */
+		$query = prepare(
+			'SELECT ``bans``.* FROM ``bans``
+			 WHERE ((`ipstart` = :ip OR (:ip >= `ipstart` AND :ip <= `ipend`)) OR (``bans``.id = :id))
+			 ORDER BY `expires` IS NULL, `expires` DESC'
+		);
+
+		$query->bindValue(':id', $ban_id);
+		$query->bindValue(':ip', inet_pton($ip));
+
+		$query->execute() or error(db_error($query));
+
+		$found_ban = null;
+		$to_delete_list = [];
+
+		while ($ban = $query->fetch(PDO::FETCH_ASSOC)) {
+			if ($ban['expires'] && ($ban['seen'] || !$require_ban_view) && $ban['expires'] < time()) {
+				$to_delete_list[] = $ban['id'];
+			} elseif ($ban['id'] === $ban_id) {
+				if ($ban['post']) {
+					$ban['post'] = json_decode($ban['post'], true);
+				}
+				$ban['mask'] = self::range_to_string(array($ban['ipstart'], $ban['ipend']));
+				$ban['cmask'] = cloak_mask($ban['mask']);
+				$found_ban = $ban;
 			}
 		}
 
-	static public function find(?string $ip, $board = false, bool $get_mod_info = false, ?int $ban_id = null, bool $auto_gc = true) {
+		self::deleteBans($to_delete_list);
+
+		return $found_ban;
+	}
+
+	static public function find($ip, $board = false, $get_mod_info = false, $banid = null) {
 		global $config;
 
-		if ($auto_gc) {
+		$query = prepare('SELECT ``bans``.*' . ($get_mod_info ? ', `username`' : '') . ' FROM ``bans``
-			return self::findAutoGc($ip, $board, $get_mod_info, $config['require_ban_view'], $ban_id);
+		' . ($get_mod_info ? 'LEFT JOIN ``mods`` ON ``mods``.`id` = `creator`' : '') . '
+		WHERE
+			(' . ($board !== false ? '(`board` IS NULL OR `board` = :board) AND' : '') . '
+		(`ipstart` = :ip OR (:ip >= `ipstart` AND :ip <= `ipend`)) OR (``bans``.id = :id))
+		ORDER BY `expires` IS NULL, `expires` DESC');
+
+		if ($board !== false)
+			$query->bindValue(':board', $board, PDO::PARAM_STR);
+
+		$query->bindValue(':id', $banid);
+		$query->bindValue(':ip', inet_pton($ip));
+
+		$query->execute() or error(db_error($query));
+
+		$ban_list = array();
+		$to_delete_list = [];
+
+		while ($ban = $query->fetch(PDO::FETCH_ASSOC)) {
+			if ($ban['expires'] && ($ban['seen'] || !$config['require_ban_view']) && $ban['expires'] < time()) {
+				$to_delete_list[] = $ban['id'];
 			} else {
-			return self::findNoGc($ip, $board, $get_mod_info, $ban_id);
+				if ($ban['post'])
+					$ban['post'] = json_decode($ban['post'], true);
+				$ban['mask'] = self::range_to_string(array($ban['ipstart'], $ban['ipend']));
+				$ban['cmask'] = cloak_mask($ban['mask']);
+				$ban_list[] = $ban;
 			}
 		}
 
+		self::deleteBans($to_delete_list);
+
+		return $ban_list;
+	}
+
 	static public function stream_json($out = false, $filter_ips = false, $filter_staff = false, $board_access = false) {
 		$query = query("SELECT ``bans``.*, `username` FROM ``bans``
 			LEFT JOIN ``mods`` ON ``mods``.`id` = `creator`
@@ -299,7 +231,8 @@ class Bans {
 		$end = end($bans);
 
 		foreach ($bans as &$ban) {
-			$ban['mask'] = self::range_to_string([$ban['ipstart'], $ban['ipend']]);
+			$uncloaked_mask = self::range_to_string(array($ban['ipstart'], $ban['ipend']));
+			$ban['mask'] = cloak_mask($uncloaked_mask);
 
 			if ($ban['post']) {
 				$post = json_decode($ban['post']);
@@ -343,24 +276,12 @@ class Bans {
 
 	static public function seen($ban_id) {
 		$query = query("UPDATE ``bans`` SET `seen` = 1 WHERE `id` = " . (int)$ban_id) or error(db_error());
-                Vichan\Functions\Theme\rebuild_themes('bans');
+                rebuildThemes('bans');
 	}
 
-	static public function purge($require_seen, $moratorium) {
+	static public function purge() {
-		if ($require_seen) {
+		$query = query("DELETE FROM ``bans`` WHERE `expires` IS NOT NULL AND `expires` < " . time() . " AND `seen` = 1") or error(db_error());
-			$query = prepare("DELETE FROM ``bans`` WHERE `expires` IS NOT NULL AND `expires` + :moratorium < :curr_time AND `seen` = 1");
+		rebuildThemes('bans');
-		} else {
-			$query = prepare("DELETE FROM ``bans`` WHERE `expires` IS NOT NULL AND `expires` + :moratorium < :curr_time");
-		}
-		$query->bindValue(':moratorium', $moratorium);
-		$query->bindValue(':curr_time', time());
-		$query->execute() or error(db_error($query));
-
-		$affected = $query->rowCount();
-		if ($affected > 0) {
-			Vichan\Functions\Theme\rebuild_themes('bans');
-		}
-		return $affected;
 	}
 
 	static public function delete($ban_id, $modlog = false, $boards = false, $dont_rebuild = false) {
@@ -378,7 +299,8 @@ class Bans {
 			if ($boards !== false && !in_array($ban['board'], $boards))
 		                error($config['error']['noaccess']);
 
-			$mask = self::range_to_string([$ban['ipstart'], $ban['ipend']]);
+			$mask = self::range_to_string(array($ban['ipstart'], $ban['ipend']));
+			$cloaked_mask = cloak_mask($mask);
 
 			modLog("Removed ban #{$ban_id} for " .
 				(filter_var($mask, FILTER_VALIDATE_IP) !== false ? "<a href=\"?/IP/$cloaked_mask\">$cloaked_mask</a>" : $cloaked_mask));
@@ -386,7 +308,7 @@ class Bans {
 
 		query("DELETE FROM ``bans`` WHERE `id` = " . (int)$ban_id) or error(db_error());
 
-		if (!$dont_rebuild) Vichan\Functions\Theme\rebuild_themes('bans');
+		if (!$dont_rebuild) rebuildThemes('bans');
 
 		return true;
 	}
@@ -443,29 +365,23 @@ class Bans {
 				openBoard($post['board']);
 
 			$post['board'] = $board['uri'];
-			/*
-			 * The body can be so long to make the json longer than 64KBs, causing the query to fail.
-			 * Truncate it to a safe length (32KBs). It could probably be longer, but if the deleted body is THAT big
-			 * already, the likelihood of it being just assorted spam/garbage is about 101%.
-			 */
-			// We're on UTF-8 only, right...?
-			$post['body'] = mb_strcut($post['body'], 0, 32768);
-
 			$query->bindValue(':post', json_encode($post));
 		} else
 			$query->bindValue(':post', null, PDO::PARAM_NULL);
 
 		$query->execute() or error(db_error($query));
+		if (isset($mod['id']) && $mod['id'] == $mod_id) {
+			modLog('Created a new ' .
+				($length > 0 ? preg_replace('/^(\d+) (\w+?)s?$/', '$1-$2', Format\until($length)) : 'permanent') .
+				' ban on ' .
+				($ban_board ? '/' . $ban_board . '/' : 'all boards') .
+				' for ' .
+				(filter_var($mask, FILTER_VALIDATE_IP) !== false ? "<a href=\"?/IP/$cloaked_mask\">$cloaked_mask</a>" : $cloaked_mask) .
+				' (<small>#' . $pdo->lastInsertId() . '</small>)' .
+				' with ' . ($reason ? 'reason: ' . utf8tohtml($reason) . '' : 'no reason'));
+		}
 
-		$ban_len = $length > 0 ? preg_replace('/^(\d+) (\w+?)s?$/', '$1-$2', Format\until($length)) : 'permanent';
+		rebuildThemes('bans');
-		$ban_board = $ban_board ? "/$ban_board/" : 'all boards';
-		$ban_ip = filter_var($mask, FILTER_VALIDATE_IP) !== false ? "<a href=\"?/IP/$cloaked_mask\">$cloaked_mask</a>" : $cloaked_mask;
-		$ban_id = $pdo->lastInsertId();
-		$ban_reason = $reason ? 'reason: ' . utf8tohtml($reason) : 'no reason';
-
-		modLog("Created a new $ban_len ban on $ban_board for $ban_ip (<small># $ban_id </small>) with $ban_reason");
-
-		Vichan\Functions\Theme\rebuild_themes('bans');
 
 		return $pdo->lastInsertId();
 	}

inc/cache.php

@@ -4,89 +4,164 @@
  *  Copyright (c) 2010-2013 Tinyboard Development Group
  */
 
-use Vichan\Data\Driver\{CacheDriver, ApcuCacheDriver, ArrayCacheDriver, FsCacheDriver, MemcachedCacheDriver, NoneCacheDriver, RedisCacheDriver};
-
 defined('TINYBOARD') or exit;
 
-
 class Cache {
-	private static function buildCache(): CacheDriver {
+	private static $cache;
+	public static function init() {
 		global $config;
 
 		switch ($config['cache']['enabled']) {
 			case 'memcached':
-				return new MemcachedCacheDriver(
+				self::$cache = new Memcached();
-					$config['cache']['prefix'],
+				self::$cache->addServers($config['cache']['memcached']);
-					$config['cache']['memcached']
+				break;
-				);
 			case 'redis':
-				return new RedisCacheDriver(
+				self::$cache = new Redis();
-					$config['cache']['prefix'],
+				self::$cache->connect($config['cache']['redis'][0], $config['cache']['redis'][1]);
-					$config['cache']['redis'][0],
+				if ($config['cache']['redis'][2]) {
-					$config['cache']['redis'][1],
+					self::$cache->auth($config['cache']['redis'][2]);
-					$config['cache']['redis'][2],
+				}
-					$config['cache']['redis'][3]
+				self::$cache->select($config['cache']['redis'][3]) or die('cache select failure');
-				);
+				break;
-			case 'apcu':
-				return new ApcuCacheDriver;
-			case 'fs':
-				return new FsCacheDriver(
-					$config['cache']['prefix'],
-					"tmp/cache/{$config['cache']['prefix']}",
-					'.lock',
-					$config['auto_maintenance'] ? 1000 : false
-				);
-			case 'none':
-				return new NoneCacheDriver();
 			case 'php':
-			default:
+				self::$cache = array();
-				return new ArrayCacheDriver();
+				break;
 		}
 	}
-
-	public static function getCache(): CacheDriver {
-		static $cache;
-		return $cache ??= self::buildCache();
-	}
-
 	public static function get($key) {
 		global $config, $debug;
 
-		$ret = self::getCache()->get($key);
+		$key = $config['cache']['prefix'] . $key;
-		if ($ret === null) {
+
-			$ret = false;
+		$data = false;
+		switch ($config['cache']['enabled']) {
+			case 'memcached':
+				if (!self::$cache)
+					self::init();
+				$data = self::$cache->get($key);
+				break;
+			case 'apcu':
+				$data = apcu_fetch($key);
+				break;
+			case 'php':
+				$data = isset(self::$cache[$key]) ? self::$cache[$key] : false;
+				break;
+			case 'fs':
+				$key = str_replace('/', '::', $key);
+				$key = str_replace("\0", '', $key);
+				if (!file_exists('tmp/cache/'.$key)) {
+					$data = false;
+				}
+				else {
+					$data = file_get_contents('tmp/cache/'.$key);
+					$data = json_decode($data, true);
+				}
+				break;
+			case 'redis':
+				if (!self::$cache)
+					self::init();
+				$data = json_decode(self::$cache->get($key), true);
+				break;
 		}
 
-		if ($config['debug']) {
+		if ($config['debug'])
-			$debug['cached'][] = $config['cache']['prefix'] . $key . ($ret === false ? ' (miss)' : ' (hit)');
+			$debug['cached'][] = $key . ($data === false ? ' (miss)' : ' (hit)');
-		}
 
-		return $ret;
+		return $data;
 	}
 	public static function set($key, $value, $expires = false) {
 		global $config, $debug;
 
-		if (!$expires) {
+		$key = $config['cache']['prefix'] . $key;
+
+		if (!$expires)
 			$expires = $config['cache']['timeout'];
+
+		switch ($config['cache']['enabled']) {
+			case 'memcached':
+				if (!self::$cache)
+					self::init();
+				self::$cache->set($key, $value, $expires);
+				break;
+			case 'redis':
+				if (!self::$cache)
+					self::init();
+				self::$cache->setex($key, $expires, json_encode($value));
+				break;
+			case 'apcu':
+				apcu_store($key, $value, $expires);
+				break;
+			case 'fs':
+				$key = str_replace('/', '::', $key);
+				$key = str_replace("\0", '', $key);
+				file_put_contents('tmp/cache/'.$key, json_encode($value));
+				break;
+			case 'php':
+				self::$cache[$key] = $value;
+				break;
 		}
 
-		self::getCache()->set($key, $value, $expires);
+		if ($config['debug'])
-
+			$debug['cached'][] = $key . ' (set)';
-		if ($config['debug']) {
-			$debug['cached'][] = $config['cache']['prefix'] . $key . ' (set)';
-		}
 	}
 	public static function delete($key) {
 		global $config, $debug;
 
-		self::getCache()->delete($key);
+		$key = $config['cache']['prefix'] . $key;
 
-		if ($config['debug']) {
+		switch ($config['cache']['enabled']) {
-			$debug['cached'][] = $config['cache']['prefix'] . $key . ' (deleted)';
+			case 'memcached':
+				if (!self::$cache)
+					self::init();
+				self::$cache->delete($key);
+				break;
+			case 'redis':
+				if (!self::$cache)
+					self::init();
+				self::$cache->del($key);
+				break;
+			case 'apcu':
+				apcu_delete($key);
+				break;
+			case 'fs':
+				$key = str_replace('/', '::', $key);
+				$key = str_replace("\0", '', $key);
+				@unlink('tmp/cache/'.$key);
+				break;
+			case 'php':
+				unset(self::$cache[$key]);
+				break;
 		}
+
+		if ($config['debug'])
+			$debug['cached'][] = $key . ' (deleted)';
 	}
 	public static function flush() {
-		self::getCache()->flush();
+		global $config;
+
+		switch ($config['cache']['enabled']) {
+			case 'memcached':
+				if (!self::$cache)
+					self::init();
+				return self::$cache->flush();
+			case 'apcu':
+				return apcu_clear_cache('user');
+			case 'php':
+				self::$cache = array();
+				break;
+			case 'fs':
+				$files = glob('tmp/cache/*');
+				foreach ($files as $file) {
+					unlink($file);
+				}
+				break;
+			case 'redis':
+				if (!self::$cache)
+					self::init();
+				return self::$cache->flushDB();
+		}
+
 		return false;
 	}
 }

inc/config.php

@@ -68,25 +68,18 @@
 	// Deprecated, use 'log_system'.
 	$config['syslog'] = false;
 
-	$config['log_system'] = [
+	$config['log_system'] = [];
-		/*
+	// Log all error messages and unauthorized login attempts.
-		 * Log all error messages and unauthorized login attempts.
+	// Can be "syslog", "error_log" (default), "file", "stderr" or "none".
-		 * Can be "syslog", "error_log" (default), "file", or "stderr".
+	$config['log_system']['type'] = 'error_log';
-		 */
-		'type' => 'error_log',
 	// The application name used by the logging system. Defaults to "tinyboard" for backwards compatibility.
-		'name' => 'tinyboard',
+	$config['log_system']['name'] = 'tinyboard';
-		/*
+	// Only relevant if 'log_system' is set to "syslog". If true, double print the logs also in stderr.
-		 * Only relevant if 'log_system' is set to "syslog". If true, double print the logs also in stderr. Defaults to
+	// Defaults to false.
-		 * false.
+	$config['log_system']['syslog_stderr'] = false;
-		 */
+	// Only relevant if "log_system" is set to `file`. Sets the file that vichan will log to.
-		'syslog_stderr' => false,
+	// Defaults to '/var/log/vichan.log'.
-		/*
+	$config['log_system']['file_path'] = '/var/log/vichan.log';
-		 * Only relevant if "log_system" is set to `file`. Sets the file that vichan will log to. Defaults to
-		 * '/var/log/vichan.log'.
-		 */
-		'file_path' => '/var/log/vichan.log',
-	];
 
 	// Use `host` via shell_exec() to lookup hostnames, avoiding query timeouts. May not work on your system.
 	// Requires safe_mode to be disabled.
@@ -99,11 +92,6 @@
 	// to the environment path (seperated by :).
 	$config['shell_path'] = '/usr/local/bin';
 
-	// Automatically execute some maintenance tasks when some pages are opened, which may result in higher
-	// latencies.
-	// If set to false, ensure to periodically invoke the tools/maintenance.php script.
-	$config['auto_maintenance'] = true;
-
 /*
  * ====================
  *  Database settings
@@ -139,26 +127,17 @@
 
 	/*
 	 * On top of the static file caching system, you can enable the additional caching system which is
-	 * designed to minimize request processing can significantly increase speed when posting or using
+	 * designed to minimize SQL queries and can significantly increase speed when posting or using the
-	 * the moderator interface.
+	 * moderator interface. APC is the recommended method of caching.
 	 *
 	 * https://github.com/vichan-devel/vichan/wiki/cache
 	 */
 
-	// Uses a PHP array. MUST NOT be used in multiprocess environments.
 	$config['cache']['enabled'] = 'php';
-	// The recommended in-memory method of caching. Requires the extension. Due to how APCu works, this should be
-	// disabled when you run tools from the cli.
 	// $config['cache']['enabled'] = 'apcu';
-	// The Memcache server. Requires the memcached extension, with a final D.
 	// $config['cache']['enabled'] = 'memcached';
-	// The Redis server. Requires the extension.
 	// $config['cache']['enabled'] = 'redis';
-	// Use the local cache folder. Slower than native but available out of the box and compatible with multiprocess
-	// environments. You can mount a ram-based filesystem in the cache directory to improve performance.
 	// $config['cache']['enabled'] = 'fs';
-	// Technically available, offers a no-op fake cache. Don't use this outside of testing or debugging.
-	// $config['cache']['enabled'] = 'none';
 
 	// Timeout for cached objects such as posts and HTML.
 	$config['cache']['timeout'] = 60 * 60 * 48; // 48 hours
@@ -226,9 +205,6 @@
 	// Used to salt secure tripcodes ("##trip") and poster IDs (if enabled).
 	$config['secure_trip_salt'] = ')(*&^%$#@!98765432190zyxwvutsrqponmlkjihgfedcba';
 
-	// Used to salt poster passwords.
-	$config['secure_password_salt'] = 'wKJSb7M5SyzMcFWD2gPO3j2RYUSO9B789!@#$%^&*()';
-
 /*
  * ====================
  *  Flood/spam settings
@@ -275,6 +251,83 @@
 	// To prevent bump attacks; returns the thread to last position after the last post is deleted.
 	$config['anti_bump_flood'] = false;
 
+	/*
+	 * Introduction to vichan's spam filter:
+	 *
+	 * In simple terms, whenever a posting form on a page is generated (which happens whenever a
+	 * post is made), vichan will add a random amount of hidden, obscure fields to it to
+	 * confuse bots and upset hackers. These fields and their respective obscure values are
+	 * validated upon posting with a 160-bit "hash". That hash can only be used as many times
+	 * as you specify; otherwise, flooding bots could just keep reusing the same hash.
+	 * Once a new set of inputs (and the hash) are generated, old hashes for the same thread
+	 * and board are set to expire. Because you have to reload the page to get the new set
+	 * of inputs and hash, if they expire too quickly and more than one person is viewing the
+	 * page at a given time, vichan would return false positives (depending on how long the
+	 * user sits on the page before posting). If your imageboard is quite fast/popular, set
+	 * $config['spam']['hidden_inputs_max_pass'] and $config['spam']['hidden_inputs_expire'] to
+	 * something higher to avoid false positives.
+	 *
+	 * See also: https://github.com/vichan-devel/vichan/wiki/your_request_looks_automated
+	 *
+	 */
+
+	// Number of hidden fields to generate.
+	$config['spam']['hidden_inputs_min'] = 4;
+	$config['spam']['hidden_inputs_max'] = 12;
+
+	// How many times can a "hash" be used to post?
+	$config['spam']['hidden_inputs_max_pass'] = 12;
+
+	// How soon after regeneration do hashes expire (in seconds)?
+	$config['spam']['hidden_inputs_expire'] = 60 * 60 * 3; // three hours
+
+	// Whether to use Unicode characters in hidden input names and values.
+	$config['spam']['unicode'] = true;
+
+	// These are fields used to confuse the bots. Make sure they aren't actually used by vichan, or it won't work.
+	$config['spam']['hidden_input_names'] = array(
+		'user',
+		'username',
+		'login',
+		'search',
+		'q',
+		'url',
+		'firstname',
+		'lastname',
+		'text',
+		'message'
+	);
+
+	// Always update this when adding new valid fields to the post form, or EVERYTHING WILL BE DETECTED AS SPAM!
+	$config['spam']['valid_inputs'] = array(
+		'hash',
+		'board',
+		'thread',
+		'mod',
+		'name',
+		'email',
+		'subject',
+		'post',
+		'body',
+		'password',
+		'sticky',
+		'lock',
+		'raw',
+		'embed',
+		'g-recaptcha-response',
+		'h-captcha-response',
+		'captcha_cookie',
+		'captcha_text',
+		'spoiler',
+		'page',
+		'file_url',
+		'json_response',
+		'user_flag',
+		'no_country',
+		'tag',
+		'simple_spam'
+	);
+
 	// Enable simple anti-spam measure. Requires the end-user to answer a question before making a post.
 	// Works very well against uncustomized spam. Answers are case-insensitive.
 	// $config['simple_spam'] = array (
@@ -283,39 +336,39 @@
 	//);
 	$config['simple_spam'] = false;
 
-	$config['captcha'] = [
+	// Enable reCaptcha to make spam even harder. Rarely necessary.
-		// Can be false, 'recaptcha', 'hcaptcha' or 'native'.
+	$config['recaptcha'] = false;
-		'provider' => false,
+
-		/*
+	// Public and private key pair from https://www.google.com/recaptcha/admin/create
-		 * If not false, the captcha is dynamically injected on the client if the web server set the `captcha-required`
+	$config['recaptcha_public'] = '6LcXTcUSAAAAAKBxyFWIt2SO8jwx4W7wcSMRoN3f';
-		 * cookie to 1. The configuration value should be set the IP for which the captcha should be verified.
+	$config['recaptcha_private'] = '6LcXTcUSAAAAAOGVbVdhmEM1_SyRF4xTKe8jbzf_';
-		 *
+
-		 * Example:
+	// Enable hCaptcha as an alternative to reCAPTCHA.
-		 *
+	$config['hcaptcha'] = false;
-		 * // Verify the captcha for users sending posts from the loopback address.
+
-		 * $config['captcha']['dynamic'] = '127.0.0.1';
+	// Public and private key pair for using hCaptcha.
-		 */
+	$config['hcaptcha_public'] = '7a4b21e0-dc53-46f2-a9f8-91d2e74b63a0';
-		'dynamic' => false,
+	$config['hcaptcha_private'] = '0x4e9A01bE637b51dC41a7Ea9865C3fDe4aB72Cf17';
-		'recaptcha' => [
+
-			'sitekey' => '6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI',
+	// Enable Custom Captcha you need to change a couple of settings
-			'secret' => '6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe',
+	//Read more at: /inc/captcha/readme.md
-		],
+	$config['captcha'] = array();
-		'hcaptcha' => [
+
-			'sitekey' => '10000000-ffff-ffff-ffff-000000000001',
+	// Enable custom captcha provider
-			'secret' => '0x0000000000000000000000000000000000000000',
+	$config['captcha']['enabled'] = false;
-		],
+
-		// To enable the native captcha you need to change a couple of settings. Read more at: /inc/captcha/readme.md
+	//New thread captcha
-		'native' => [
+ 	//Require solving a captcha to post a thread.
-			// Custom captcha get provider path (if not working get the absolute path aka your url).
+ 	//Default off.
-			'provider_get' => '/inc/captcha/entrypoint.php',
+ 	$config['new_thread_capt'] = false;
+
+	// Custom captcha get provider path (if not working get the absolute path aka your url.)
+	$config['captcha']['provider_get'] = '../inc/captcha/entrypoint.php';
 	// Custom captcha check provider path
-			'provider_check' => '/inc/captcha/entrypoint.php',
+	$config['captcha']['provider_check'] = '../inc/captcha/entrypoint.php';
+
 	// Custom captcha extra field (eg. charset)
-			'extra' => 'abcdefghijklmnopqrstuvwxyz',
+	$config['captcha']['extra'] = 'abcdefghijklmnopqrstuvwxyz';
-			// New thread captcha. Require solving a captcha to post a thread.
-			'new_thread_capt' => false
-		]
-	];
 
 	// Ability to lock a board for normal users and still allow mods to post.  Could also be useful for making an archive board
 	$config['board_locked'] = false;
@@ -455,17 +508,6 @@
 	// 	'action' => 'reject'
 	// );
 
-	// Example: Expand shortened links in a post, looking for and blocking URLs that lead to an unwanted
-        // endpoint. Many botspam posts include a variety of shortened URLs which all point to the same few
-        // webhosts. You can use this filter to block the endpoint webhost instead of just the apparent URL.
-	// $config['filters'][] = array(
-	// 	'condition' => array(
-	// 		'unshorten' => '/endpoint.net/i',
-	// 	),
-	// 	'action' => 'reject',
-	// 	'message' => 'None of that, please.'
-	// );
-
 	// Filter flood prevention conditions ("flood-match") depend on a table which contains a cache of recent
 	// posts across all boards. This table is automatically purged of older posts, determining the maximum
 	// "age" by looking at each filter. However, when determining the maximum age, vichan does not look
@@ -644,9 +686,6 @@
 	);
 	*/
 
-	// Maximum number inline of dice rolls per markup.
-	$config['max_roll_count'] = 50;
-
 	// Allow dice rolling: an email field of the form "dice XdY+/-Z" will result in X Y-sided dice rolled and summed,
 	// with the modifier Z added, with the result displayed at the top of the post body.
 	$config['allow_roll'] = false;
@@ -694,9 +733,6 @@
 	//);
 	$config['premade_ban_reasons'] = false;
 
-	// How often (minimum) to purge the ban list of expired bans (which have been seen).
-	$config['purge_bans'] = 60 * 60 * 12; // 12 hours
-
 	// Allow users to appeal bans through vichan.
 	$config['ban_appeals'] = false;
 
@@ -718,15 +754,11 @@
  * ====================
  */
 
-	$config['markup'] = [
-		// Inline dice roll markup.
-		[ "/!([-+]?\d+)?([d])([-+]?\d+)([-+]\d+)?/iu", fn($m) => inline_dice_roll_markup($m, 'static/d10.svg') ],
 	// "Wiki" markup syntax ($config['wiki_markup'] in pervious versions):
-		[ "/'''(.+?)'''/", "<strong>\$1</strong>" ],
+	$config['markup'][] = array("/'''(.+?)'''/", "<strong>\$1</strong>");
-		[ "/''(.+?)''/", "<em>\$1</em>" ],
+	$config['markup'][] = array("/''(.+?)''/", "<em>\$1</em>");
-		[ "/\*\*(.+?)\*\*/", "<span class=\"spoiler\">\$1</span>" ],
+	$config['markup'][] = array("/\*\*(.+?)\*\*/", "<span class=\"spoiler\">\$1</span>");
-		[ "/^[ |\t]*==(.+?)==[ |\t]*$/m", "<span class=\"heading\">\$1</span>" ],
+	$config['markup'][] = array("/^[ |\t]*==(.+?)==[ |\t]*$/m", "<span class=\"heading\">\$1</span>");
-	];
 
 	// Code markup. This should be set to a regular expression, using tags you want to use. Examples:
 	// "/\[code\](.*?)\[\/code\]/is"
@@ -831,14 +863,12 @@
 	$config['ie_mime_type_detection'] = '/<(?:body|head|html|img|plaintext|pre|script|table|title|a href|channel|scriptlet)/i';
 
 	// Allowed image file extensions.
-	$config['allowed_ext'] = [
+	$config['allowed_ext'][] = 'jpg';
-		'jpg',
+	$config['allowed_ext'][] = 'jpeg';
-		'jpeg',
+	$config['allowed_ext'][] = 'bmp';
-		'bmp',
+	$config['allowed_ext'][] = 'gif';
-		'gif',
+	$config['allowed_ext'][] = 'png';
-		'png',
+	$config['allowed_ext'][] = 'webp';
-		'webp'
-	];
 	// $config['allowed_ext'][] = 'svg';
 
 	// Allowed extensions for OP. Inherits from the above setting if set to false. Otherwise, it overrides both allowed_ext and
@@ -856,12 +886,10 @@
 	// };
 
 	// Thumbnail to use for the non-image file uploads.
-	$config['file_icons'] = [
+	$config['file_icons']['default'] = 'file.png';
-		'default' => 'file.png',
+	$config['file_icons']['zip'] = 'zip.png';
-		'zip' => 'zip.png',
+	$config['file_icons']['webm'] = 'video.png';
-		'webm' => 'video.png',
+	$config['file_icons']['mp4'] = 'video.png';
-		'mp4' => 'video.png'
-	];
 	// Example: Custom thumbnail for certain file extension.
 	// $config['file_icons']['extension'] = 'some_file.png';
 
@@ -893,13 +921,11 @@
 	$config['show_filename'] = true;
 
 	// WebM Settings
-	$config['webm'] = [
+	$config['webm']['use_ffmpeg'] = false;
-		'use_ffmpeg' => false,
+	$config['webm']['allow_audio'] = false;
-		'allow_audio' => false,
+	$config['webm']['max_length'] = 120;
-		'max_length' => 120,
+	$config['webm']['ffmpeg_path'] = 'ffmpeg';
-		'ffmpeg_path' => 'ffmpeg',
+	$config['webm']['ffprobe_path'] = 'ffprobe';
-		'ffprobe_path' => 'ffprobe'
-	];
 
 	// Display image identification links for ImgOps, regex.info/exif, Google Images and iqdb.
 	$config['image_identification'] = false;
@@ -1008,11 +1034,8 @@
 
 	// Custom stylesheets available for the user to choose. See the "stylesheets/" folder for a list of
 	// available stylesheets (or create your own).
-	$config['stylesheets'] = [
+	$config['stylesheets']['Yotsuba B'] = ''; // Default; there is no additional/custom stylesheet for this.
-		// Default; there is no additional/custom stylesheet for this.
+	$config['stylesheets']['Yotsuba'] = 'yotsuba.css';
-		'Yotsuba B' => '',
-		'Yotsuba' => 'yotsuba.css'
-	];
 	// $config['stylesheets']['Futaba'] = 'futaba.css';
 	// $config['stylesheets']['Dark'] = 'dark.css';
 
@@ -1094,10 +1117,6 @@
 	// <tinyboard flag style>.
 	$config['flag_style'] = 'width:16px;height:11px;';
 
-	// Lazy loading
-	// https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading
-	$config['content_lazy_loading'] = false;
-
 /*
  * ====================
  *  Javascript
@@ -1130,10 +1149,6 @@
 	// Minify Javascript using http://code.google.com/p/minify/.
 	$config['minify_js'] = false;
 
-	// Version number for main.js (or $config['url_javascript']).
-	// You can use this to bypass the user's browsers and CDN caches.
-	$config['resource_version'] = 0;
-
 	// Dispatch thumbnail loading and image configuration with JavaScript. It will need a certain javascript
 	// code to work.
 	$config['javascript_image_dispatch'] = false;
@@ -1152,8 +1167,8 @@
 	// Be careful when creating a new embed, because depending on the URL you end up exposing yourself to an XSS.
 	$config['embedding'] = array(
 		array(
-			'/^https?:\/\/(\w+\.)?(youtube\.com\/watch\?v=|youtu\.be\/)([a-zA-Z0-9\-_]{10,11})?$/i',
+			'/^https?:\/\/(\w+\.)?youtube\.com\/watch\?v=([a-zA-Z0-9\-_]{10,11})?$/i',
-			'<iframe style="float: left; margin: 10px 20px;" width="%%tb_width%%" height="%%tb_height%%" frameborder="0" id="ytplayer" src="https://www.youtube.com/embed/$3"></iframe>'
+			'<iframe style="float: left; margin: 10px 20px;" width="%%tb_width%%" height="%%tb_height%%" frameborder="0" id="ytplayer" src="https://www.youtube.com/embed/$2"></iframe>'
 		),
 		array(
 			'/^https?:\/\/(\w+\.)?vimeo\.com\/(\d{2,10})(\?.+)?$/i',
@@ -1164,37 +1179,13 @@
 			'<iframe style="float: left; margin: 10px 20px;" width="%%tb_width%%" height="%%tb_height%%" frameborder="0" src="https://www.dailymotion.com/embed/video/$2" allowfullscreen></iframe>'
 		),
 		array(
-			'/^https?:\/\/(www\.)?rumble\.com\/embed\/([a-zA-Z0-9]+)(\/\?[^\'"<>]*)?$/i',
+			'/^https?:\/\/(\w+\.)?metacafe\.com\/watch\/(\d+)\/([a-zA-Z0-9_\-.]+)\/(\?[^\'"<>]+)?$/i',
-			'<iframe class="rumble" width="%%tb_width%%" height="%%tb_height%%" src="https://rumble.com/embed/$2/" frameborder="0" allowfullscreen></iframe>'
+			'<iframe style="float: left; margin: 10px 20px;" width="%%tb_width%%" height="%%tb_height%%" frameborder="0"  src="https://www.metacafe.com/embed/$2/$3/" allowfullscreen></iframe>'
 		),
 		array(
-			'/^https?:\/\/(www\.)?bitchute\.com\/(?:video|embed)\/([a-zA-Z0-9]+)(\/)?(\?[^\'"<>]*)?$/i',
+                        '/^https?:\/\/(\w+\.)?vocaroo\.com\/([a-zA-Z0-9]{2,12})$/i',
-			'<iframe allowfullscreen="true" width="%%tb_width%%" height="%%tb_height%%" scrolling="no" frameborder="0" style="border: none;" src="https://www.bitchute.com/embed/$2"></iframe>'
+                        '<iframe style="float: left; margin: 10px 20px;" width="300" height="60" frameborder="0" src="https://vocaroo.com/embed/$2"></iframe>'
-		),
+		)
-		array(
-        		'/^https?:\/\/(?:www\.)?odysee\.com\/(?:@[^\/]+\/)?([-a-zA-Z0-9_]+:[a-zA-Z0-9]+)(\/)?(\?[^\'"<>]*)?$/i',
-        		'<iframe width="%%tb_width%%" height="%%tb_height%%" src="https://odysee.com/$/embed/$1" allowfullscreen></iframe>'
-		),
-		array(
-                        '/^https?:\/\/(www\.)?kick\.com\/([a-zA-Z0-9_]+)(\?[^\'"<>]*)?$/i',
-                        '<iframe src="https://player.kick.com/$2" height="%%tb_height%%" width="%%tb_width%%" frameborder="0" scrolling="no" allowfullscreen="true"></iframe>'
-                ),
-		/*
-  		//Both TikTok and Instagram are commented out since they contain some extra scripting you might not want natively on your website.
-		array(
-			'/^https?:\/\/(www\.)?tiktok\.com\/@([a-zA-Z0-9_.]+)\/video\/([0-9]+)(\?[^\'"<>]*)?$/i',
-			'<blockquote class="tiktok-embed" cite="https://www.tiktok.com/@$2/video/$3" data-video-id="$3" style="max-width: %%tb_width%%px;min-width: 325px;"><section></section></blockquote><script async src="https://www.tiktok.com/embed.js"></script>'
-		),
-		array(
-			'/^https?:\/\/(www\.)?instagram\.com\/(p|reel|tv)\/([a-zA-Z0-9_-]+)(\/)?(\?[^\'"<>]*)?$/i',
-			'<blockquote class="instagram-media" data-instgrm-permalink="https://www.instagram.com/$2/$3/" data-instgrm-version="14" style="max-width: %%tb_width%%px; min-width: 326px; width: 100%;"></blockquote><script async src="//www.instagram.com/embed.js"></script>'
-		),
-  		*/
-		array(
-			'/^https?:\/\/(\w+\.)?(vocaroo\.com\/|voca\.ro\/)([a-zA-Z0-9]{2,12})$/i',
-			'<iframe style="float: left; margin: 10px 20px;" width="300" height="60" frameborder="0" src="https://vocaroo.com/embed/$3"></iframe>'
-		),
-				
 	);
 
 	// Embedding width and height.
@@ -1207,86 +1198,86 @@
  * ====================
  */
 
-	$config['error'] = [
+	// Error messages
-		// General error messages
+	$config['error']['bot']			= _('You look like a bot.');
-		'bot' 					=> _('You look like a bot.'),
+	$config['error']['referer']		= _('Your browser sent an invalid or no HTTP referer.');
-		'referer'				=> _('Your browser sent an invalid or no HTTP referer.'),
+	$config['error']['toolong']		= _('The %s field was too long.');
-		'toolong'				=> _('The %s field was too long.'),
+	$config['error']['toolong_body']	= _('The body was too long.');
-		'toolong_body'			=> _('The body was too long.'),
+	$config['error']['tooshort_body']	= _('The body was too short or empty.');
-		'tooshort_body'			=> _('The body was too short or empty.'),
+	$config['error']['toomanylines']	= _('Your post contains too many lines!');
-		'toomanylines'			=> _('Your post contains too many lines!'),
+	$config['error']['noimage']		= _('You must upload an image.');
-		'noimage'				=> _('You must upload an image.'),
+	$config['error']['toomanyimages'] = _('You have attempted to upload too many images!');
-		'toomanyimages' 		=> _('You have attempted to upload too many images!'),
+	$config['error']['nomove']		= _('The server failed to handle your upload.');
-		'nomove'				=> _('The server failed to handle your upload.'),
+	$config['error']['fileext']		= _('Unsupported image format.');
-		'fileext'				=> _('Unsupported image format.'),
+	$config['error']['noboard']		= _('Invalid board!');
-		'noboard'				=> _('Invalid board!'),
+	$config['error']['nonexistant']		= _('Thread specified does not exist.');
-		'nonexistant'			=> _('Thread specified does not exist.'),
+	$config['error']['nopost']		= _('Post specified does not exist.');
-		'nopost'				=> _('Post specified does not exist.'),
+	$config['error']['locked']		= _('Thread locked. You may not reply at this time.');
-		'locked'				=> _('Thread locked. You may not reply at this time.'),
+	$config['error']['reply_hard_limit']	= _('Thread has reached its maximum reply limit.');
-		'reply_hard_limit'		=> _('Thread has reached its maximum reply limit.'),
+	$config['error']['image_hard_limit']	= _('Thread has reached its maximum image limit.');
-		'image_hard_limit'		=> _('Thread has reached its maximum image limit.'),
+	$config['error']['nopost']		= _('You didn\'t make a post.');
-		'nopost'				=> _('You didn\'t make a post.'),
+	$config['error']['flood']		= _('Flood detected; Post discarded.');
-		'flood'					=> _('Flood detected; Post discarded.'),
+	$config['error']['too_many_threads']	= _('The hourly thread limit has been reached. Please post in an existing thread.');
-		'too_many_threads'		=> _('The hourly thread limit has been reached. Please post in an existing thread.'),
+	$config['error']['spam']		= _('Your request looks automated; Post discarded.');
-		'spam'					=> _('Your request looks automated; Post discarded.'),
+	$config['error']['simple_spam']		= _('You must answer the question to make a new thread. See the last field.');
-		'simple_spam'			=> _('You must answer the question to make a new thread. See the last field.'),
+	$config['error']['unoriginal']		= _('Unoriginal content!');
-		'unoriginal'			=> _('Unoriginal content!'),
+	$config['error']['muted']		= _('Unoriginal content! You have been muted for %d seconds.');
-		'muted'					=> _('Unoriginal content! You have been muted for %d seconds.'),
+	$config['error']['youaremuted']		= _('You are muted! Expires in %d seconds.');
-		'youaremuted'			=> _('You are muted! Expires in %d seconds.'),
+	$config['error']['dnsbl']		= _('Your IP address is listed in %s.');
-		'dnsbl'					=> _('Your IP address is listed in %s.'),
+	$config['error']['toomanylinks']	= _('Too many links; flood detected.');
-		'toomanylinks'			=> _('Too many links; flood detected.'),
+	$config['error']['toomanycites']	= _('Too many cites; post discarded.');
-		'toomanycites'			=> _('Too many cites; post discarded.'),
+	$config['error']['toomanycross']	= _('Too many cross-board links; post discarded.');
-		'toomanycross'			=> _('Too many cross-board links; post discarded.'),
+	$config['error']['nodelete']		= _('You didn\'t select anything to delete.');
-		'nodelete'				=> _('You didn\'t select anything to delete.'),
+	$config['error']['noreport']		= _('You didn\'t select anything to report.');
-		'noreport'				=> _('You didn\'t select anything to report.'),
+	$config['error']['toolongreport']	= _('The reason was too long.');
-		'toolongreport'			=> _('The reason was too long.'),
+	$config['error']['toomanyreports']	= _('You can\'t report that many posts at once.');
-		'toomanyreports'		=> _('You can\'t report that many posts at once.'),
+	$config['error']['noban']			= _('That ban doesn\'t exist or is not for you.');
-		'noban'					=> _('That ban doesn\'t exist or is not for you.'),
+	$config['error']['tooshortban']		= _('You cannot appeal a ban of this length.');
-		'tooshortban'			=> _('You cannot appeal a ban of this length.'),
+	$config['error']['toolongappeal']	= _('The appeal was too long.');
-		'toolongappeal'			=> _('The appeal was too long.'),
+	$config['error']['toomanyappeals']	= _('You cannot appeal this ban again.');
-		'toomanyappeals'		=> _('You cannot appeal this ban again.'),
+	$config['error']['pendingappeal']	= _('There is already a pending appeal for this ban.');
-		'pendingappeal'			=> _('There is already a pending appeal for this ban.'),
+	$config['error']['invalidpassword']	= _('Wrong password…');
-		'invalidpassword'		=> _('Wrong password…'),
+	$config['error']['invalidimg']		= _('Invalid image.');
-		'invalidimg'			=> _('Invalid image.'),
+	$config['error']['phpfileserror']	= _('Upload failure (file #%index%): Error code %code%. Refer to <a href="http://php.net/manual/en/features.file-upload.errors.php">http://php.net/manual/en/features.file-upload.errors.php</a>; post discarded.');
-		'phpfileserror'			=> _('Upload failure (file #%index%): Error code %code%. Refer to <a href=>"http://php.net/manual/en/features.file-upload.errors.php">http://php.net/manual/en/features.file-upload.errors.php</a>; post discarded.'),
+	$config['error']['unknownext']		= _('Unknown file extension.');
-		'unknownext'			=> _('Unknown file extension.'),
+	$config['error']['filesize']		= _('Maximum file size: %maxsz% bytes<br>Your file\'s size: %filesz% bytes');
-		'filesize'				=> _('Maximum file size: %maxsz% bytes<br>Your file\'s size: %filesz% bytes'),
+	$config['error']['maxsize']		= _('The file was too big.');
-		'maxsize'				=> _('The file was too big.'),
+	$config['error']['genwebmerror']	= _('There was a problem processing your webm.');
-		'genwebmerror'			=> _('There was a problem processing your webm.'),
+	$config['error']['webmerror'] 		= _('There was a problem processing your webm.');//Is this error used anywhere ?
-		'invalidwebm' 			=> _('Invalid webm uploaded.'),
+	$config['error']['invalidwebm'] 	= _('Invalid webm uploaded.');
-		'webmhasaudio' 			=> _('The uploaded webm contains an audio or another type of additional stream.'),
+	$config['error']['webmhasaudio'] 	= _('The uploaded webm contains an audio or another type of additional stream.');
-		'webmtoolong'			=>_('The uploaded webm is longer than %d seconds.'),
+	$config['error']['webmtoolong']		=_('The uploaded webm is longer than %d seconds.');
-		'fileexists'			=> _('That file <a href=>"%s">already exists</a>!'),
+	$config['error']['fileexists']		= _('That file <a href="%s">already exists</a>!');
-		'fileexistsinthread'	=> _('That file <a href=>"%s">already exists</a> in this thread!'),
+	$config['error']['fileexistsinthread']	= _('That file <a href="%s">already exists</a> in this thread!');
-		'delete_too_soon'		=> _('You\'ll have to wait another %s before deleting that.'),
+	$config['error']['delete_too_soon']	= _('You\'ll have to wait another %s before deleting that.');
-		'delete_too_late'		=> _('You cannot delete a post this old.'),
+	$config['error']['delete_too_late']	= _('You cannot delete a post this old.');
-		'mime_exploit'			=> _('MIME type detection XSS exploit (IE) detected; post discarded.'),
+	$config['error']['mime_exploit']	= _('MIME type detection XSS exploit (IE) detected; post discarded.');
-		'invalid_embed'			=> _('Couldn\'t make sense of the URL of the video you tried to embed.'),
+	$config['error']['invalid_embed']	= _('Couldn\'t make sense of the URL of the video you tried to embed.');
-		'captcha'				=> _('You seem to have mistyped the verification.'),
+	$config['error']['captcha']		= _('You seem to have mistyped the verification.');
-		'flag_undefined'		=> _('The flag %s is undefined, your PHP version is too old!'),
+	$config['error']['flag_undefined']	= _('The flag %s is undefined, your PHP version is too old!');
-		'flag_wrongtype'		=> _('defined_flags_accumulate(): The flag %s is of the wrong type!'),
+	$config['error']['flag_wrongtype']	= _('defined_flags_accumulate(): The flag %s is of the wrong type!');
-		'remote_io_error'		=> _('IO error while interacting with a remote service.'),
+	$config['error']['remote_io_error']	= _('IO error while interacting with a remote service.');
-		'local_io_error'		=> _('IO error while interacting with a local resource or service.'),
+	$config['error']['local_io_error']	= _('IO error while interacting with a local resource or service.');
+
 
 	// Moderator errors
-		'toomanyunban'	=> _('You are only allowed to unban %s users at a time. You tried to unban %u users.'),
+	$config['error']['toomanyunban']	= _('You are only allowed to unban %s users at a time. You tried to unban %u users.');
-		'invalid'		=> _('Invalid username and/or password.'),
+	$config['error']['invalid']		= _('Invalid username and/or password.');
-		'insecure'		=> _('Login on insecure connections is disabled.'),
+	$config['error']['insecure']		= _('Login on insecure connections is disabled.');
-		'notamod'		=> _('You are not a mod…'),
+	$config['error']['notamod']		= _('You are not a mod…');
-		'invalidafter'	=> _('Invalid username and/or password. Your user may have been deleted or changed.'),
+	$config['error']['invalidafter']	= _('Invalid username and/or password. Your user may have been deleted or changed.');
-		'malformed'		=> _('Invalid/malformed cookies.'),
+	$config['error']['malformed']		= _('Invalid/malformed cookies.');
-		'missedafield'	=> _('Your browser didn\'t submit an input when it should have.'),
+	$config['error']['missedafield']	= _('Your browser didn\'t submit an input when it should have.');
-		'required'		=> _('The %s field is required.'),
+	$config['error']['required']		= _('The %s field is required.');
-		'invalidfield'	=> _('The %s field was invalid.'),
+	$config['error']['invalidfield']	= _('The %s field was invalid.');
-		'boardexists'	=> _('There is already a %s board.'),
+	$config['error']['boardexists']		= _('There is already a %s board.');
-		'noaccess'		=> _('You don\'t have permission to do that.'),
+	$config['error']['noaccess']		= _('You don\'t have permission to do that.');
-		'invalidpost'	=> _('That post doesn\'t exist…'),
+	$config['error']['invalidpost']		= _('That post doesn\'t exist…');
-		'404'			=> _('Page not found.'),
+	$config['error']['404']			= _('Page not found.');
-		'modexists'		=> _('That mod <a href="?/users/%d">already exists</a>!'),
+	$config['error']['modexists']		= _('That mod <a href="?/users/%d">already exists</a>!');
-		'invalidtheme'	=> _('That theme doesn\'t exist!'),
+	$config['error']['invalidtheme']	= _('That theme doesn\'t exist!');
-		'csrf'			=> _('Invalid security token! Please go back and try again.'),
+	$config['error']['csrf']		= _('Invalid security token! Please go back and try again.');
-		'badsyntax'		=> _('Your code contained PHP syntax errors. Please go back and correct them. PHP says: ')
+	$config['error']['badsyntax']		= _('Your code contained PHP syntax errors. Please go back and correct them. PHP says: ');
-	];
 
 /*
  * =========================
@@ -1308,8 +1299,8 @@
 
 	// The scheme and domain. This is used to get the site's absolute URL (eg. for image identification links).
 	// If you use the CLI tools, it would be wise to override this setting.
-	$config['domain'] = ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off') ? 'https://' : 'http://')
+	$config['domain'] = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off') ? 'https://' : 'http://';
-		 . (isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : 'localhost');
+	$config['domain'] .= isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : 'localhost';
 
 	// If for some reason the folders and static HTML index files aren't in the current working direcotry,
 	// enter the directory path here. Otherwise, keep it false.
@@ -1389,22 +1380,22 @@
 	// Board directory, followed by a forward-slash (/).
 	$config['board_path'] = '%s/';
 	// Misc directories.
-	$config['dir'] = [
+	$config['dir']['img'] = 'src/';
-		'img' => 'src/',
+	$config['dir']['thumb'] = 'thumb/';
-		'thumb' => 'thumb/',
+	$config['dir']['res'] = 'res/';
-		'res' => 'res/',
+
 	// For load balancing, having a seperate server (and domain/subdomain) for serving static content is
 	// possible. This can either be a directory or a URL. Defaults to $config['root'] . 'static/'.
 	// $config['dir']['static'] = 'http://static.example.org/';
+
 	// Where to store the .html templates. This folder and the template files must exist.
-		'template' => getcwd() . '/templates',
+	$config['dir']['template'] = getcwd() . '/templates';
 	// Location of vichan "themes".
-		'themes' => getcwd() . '/templates/themes',
+	$config['dir']['themes'] = getcwd() . '/templates/themes';
 	// Same as above, but a URI (accessable by web interface).
-		'themes_uri' => 'templates/themes',
+	$config['dir']['themes_uri'] = 'templates/themes';
 	// Home directory. Used by themes.
-		'home' => ''
+	$config['dir']['home'] = '';
-	];
 
 	// Location of a blank 1x1 gif file. Only used when country_flags_condensed is enabled
 	// $config['image_blank'] = 'static/blank.gif';
@@ -1477,19 +1468,13 @@
 	// 5. enable smart_build_helper (see below)
 	// 6. edit the strategies (see inc/functions.php for the builtin ones). You can use lambdas. I will test
 	//    various ones and include one that works best for me.
-	$config['generation_strategies'] = [
+	$config['generation_strategies'] = array();
-		/*
+	// Add a sane strategy. It forces to immediately generate a page user is about to land on. Otherwise,
-		 * Add a sane strategy. It forces to immediately generate a page user is about to land on. Otherwise,
+	// it has no opinion, so it needs a fallback strategy.
-		 * it has no opinion, so it needs a fallback strategy.
+	$config['generation_strategies'][] = 'strategy_sane';
-		 */
+	// Add an immediate catch-all strategy. This is the default function of imageboards: generate all pages
-		'strategy_sane',
+	// on post time.
-		/*
+	$config['generation_strategies'][] = 'strategy_immediate';
-		 * Add an immediate catch-all strategy. This is the default function of imageboards: generate all pages
-		 * on post time.
-		 */
-		'strategy_immediate',
-	];
-
 	// NOT RECOMMENDED: Instead of an all-"immediate" strategy, you can use an all-"build_on_load" one (used
 	// to be initialized using $config['smart_build']; ) for all pages instead of those to be build
 	// immediately. A rebuild done in this mode should remove all your static files
@@ -1506,7 +1491,7 @@
 	$config['page_404'] = '/404.html';
 
 	// Extra controller entrypoints. Controller is used only by smart_build and advanced build.
-	$config['controller_entrypoints'] = [];
+	$config['controller_entrypoints'] = array();
 
 /*
  * ====================
@@ -1514,84 +1499,33 @@
  * ====================
  */
 
-	// Mod links (full HTML).
-	$config['mod'] = [
 	// Limit how many bans can be removed via the ban list. Set to false (or zero) for no limit.
-		'unban_limit' => false,
+	$config['mod']['unban_limit'] = false;
-		// Whether or not to lock moderator sessions to IP addresses. This makes cookie theft less effective.
+
-		'lock_ip' => true,
+	// Whether or not to lock moderator sessions to IP addresses. This makes cookie theft ineffective.
+	$config['mod']['lock_ip'] = true;
+
 	// The page that is first shown when a moderator logs in. Defaults to the dashboard (?/).
-		'default' => '/',
+	$config['mod']['default'] = '/';
-		// Do DNS lookups on IP addresses to get their hostname for the moderator IP pages (?/IP/x.x.x.x).
-		'dns_lookup' => true,
-		// How many recent posts, per board, to show in ?/IP/x.x.x.x.
-		'ip_recentposts' => 5,
-		// Number of posts to display on the reports page.
-		'recent_reports' => 10,
-		// Number of actions to show per page in the moderation log.
-		'modlog_page' => 350,
-		// Number of bans to show per page in the ban list.
-		'banlist_page'=> 350,
-		// Number of news entries to display per page.
-		'news_page' => 40,
-		// Number of results to display per page.
-		'search_page' => 200,
-		// Number of entries to show per page in the moderator noticeboard.
-		'noticeboard_page' => 50,
-		// Number of entries to summarize and display on the dashboard.
-		'noticeboard_dashboard' => 5,
 
-		// Check public ban message by default.
+	// Mod links (full HTML).
-		'check_ban_message' => false,
+	$config['mod']['link_delete'] = '[D]';
-		// Default public ban message. In public ban messages, %length% is replaced with "for x days" or
+	$config['mod']['link_ban'] = '[B]';
-		// "permanently" (with %LENGTH% being the uppercase equivalent).
+	$config['mod']['link_bandelete'] = '[B&amp;D]';
-		'default_ban_message' => _('USER WAS BANNED FOR THIS POST'),
+	$config['mod']['link_deletefile'] = '[F]';
-		// $config['mod']['default_ban_message'] = 'USER WAS BANNED %LENGTH% FOR THIS POST';
+	$config['mod']['link_spoilerimage'] = '[S]';
-		// HTML to append to post bodies for public bans messages (where "%s" is the message).
+	$config['mod']['link_deletebyip'] = '[D+]';
-		'ban_message' => '<span class="public_ban">(%s)</span>',
+	$config['mod']['link_deletebyip_global'] = '[D++]';
-
+	$config['mod']['link_sticky'] = '[Sticky]';
-		// When moving a thread to another board and choosing to keep a "shadow thread", an automated post (with
+	$config['mod']['link_desticky'] = '[-Sticky]';
-		// a capcode) will be made, linking to the new location for the thread. "%s" will be replaced with a
+	$config['mod']['link_lock'] = '[Lock]';
-		// standard cross-board post citation (>>>/board/xxx)
+	$config['mod']['link_unlock'] = '[-Lock]';
-		'shadow_mesage' => _('Moved to %s.'),
+	$config['mod']['link_bumplock'] = '[Sage]';
-		// Capcode to use when posting the above message.
+	$config['mod']['link_bumpunlock'] = '[-Sage]';
-		'shadow_capcode' => 'Mod',
+	$config['mod']['link_editpost'] = '[Edit]';
-		// Name to use when posting the above message. If false, $config['anonymous'] will be used.
+	$config['mod']['link_move'] = '[Move]';
-		'shadow_name' => false,
+	$config['mod']['link_cycle'] = '[Cycle]';
-
+	$config['mod']['link_uncycle'] = '[-Cycle]';
-		// PHP time limit for ?/rebuild. A value of 0 should cause PHP to wait indefinitely.
-		'rebuild_timelimit' => 0,
-
-		// PM snippet (for ?/inbox) length in characters.
-		'snippet_length' => 75,
-
-		// Edit raw HTML in posts by default.
-		'raw_html_default' => false,
-
-		// Automatically dismiss all reports regarding a thread when it is locked.
-		'dismiss_reports_on_lock' => true,
-
-		// Replace ?/config with a simple text editor for editing inc/instance-config.php.
-		'config_editor_php' => false,
-
-		'link_delete' => '[D]',
-		'link_ban' => '[B]',
-		'link_bandelete' => '[B&amp;D]',
-		'link_deletefile' => '[F]',
-		'link_spoilerimage' => '[S]',
-		'link_deletebyip' => '[D+]',
-		'link_deletebyip_global' => '[D++]',
-		'link_sticky' => '[Sticky]',
-		'link_desticky' => '[-Sticky]',
-		'link_lock' => '[Lock]',
-		'link_unlock' => '[-Lock]',
-		'link_bumplock' => '[Sage]',
-		'link_bumpunlock' => '[-Sage]',
-		'link_editpost' => '[Edit]',
-		'link_move' => '[Move]',
-		'link_cycle' => '[Cycle]',
-		'link_uncycle' => '[-Cycle]'
-	];
 
 	// Moderator capcodes.
 	$config['capcode'] = ' <span class="capcode">## %s</span>';
@@ -1616,6 +1550,63 @@
 	// Enable the moving of single replies
 	$config['move_replies'] = false;
 
+	// How often (minimum) to purge the ban list of expired bans (which have been seen). Only works when
+	//  $config['cache'] is enabled and working.
+	$config['purge_bans'] = 60 * 60 * 12; // 12 hours
+
+	// Do DNS lookups on IP addresses to get their hostname for the moderator IP pages (?/IP/x.x.x.x).
+	$config['mod']['dns_lookup'] = true;
+	// How many recent posts, per board, to show in ?/IP/x.x.x.x.
+	$config['mod']['ip_recentposts'] = 5;
+
+	// Number of posts to display on the reports page.
+	$config['mod']['recent_reports'] = 10;
+	// Number of actions to show per page in the moderation log.
+	$config['mod']['modlog_page'] = 350;
+	// Number of bans to show per page in the ban list.
+	$config['mod']['banlist_page'] = 350;
+	// Number of news entries to display per page.
+	$config['mod']['news_page'] = 40;
+	// Number of results to display per page.
+	$config['mod']['search_page'] = 200;
+	// Number of entries to show per page in the moderator noticeboard.
+	$config['mod']['noticeboard_page'] = 50;
+	// Number of entries to summarize and display on the dashboard.
+	$config['mod']['noticeboard_dashboard'] = 5;
+
+	// Check public ban message by default.
+	$config['mod']['check_ban_message'] = false;
+	// Default public ban message. In public ban messages, %length% is replaced with "for x days" or
+	// "permanently" (with %LENGTH% being the uppercase equivalent).
+	$config['mod']['default_ban_message'] = _('USER WAS BANNED FOR THIS POST');
+	// $config['mod']['default_ban_message'] = 'USER WAS BANNED %LENGTH% FOR THIS POST';
+	// HTML to append to post bodies for public bans messages (where "%s" is the message).
+	$config['mod']['ban_message'] = '<span class="public_ban">(%s)</span>';
+
+	// When moving a thread to another board and choosing to keep a "shadow thread", an automated post (with
+	// a capcode) will be made, linking to the new location for the thread. "%s" will be replaced with a
+	// standard cross-board post citation (>>>/board/xxx)
+	$config['mod']['shadow_mesage'] = _('Moved to %s.');
+	// Capcode to use when posting the above message.
+	$config['mod']['shadow_capcode'] = 'Mod';
+	// Name to use when posting the above message. If false, $config['anonymous'] will be used.
+	$config['mod']['shadow_name'] = false;
+
+	// PHP time limit for ?/rebuild. A value of 0 should cause PHP to wait indefinitely.
+	$config['mod']['rebuild_timelimit'] = 0;
+
+	// PM snippet (for ?/inbox) length in characters.
+	$config['mod']['snippet_length'] = 75;
+
+	// Edit raw HTML in posts by default.
+	$config['mod']['raw_html_default'] = false;
+
+	// Automatically dismiss all reports regarding a thread when it is locked.
+	$config['mod']['dismiss_reports_on_lock'] = true;
+
+	// Replace ?/config with a simple text editor for editing inc/instance-config.php.
+	$config['mod']['config_editor_php'] = false;
+
 /*
  * ====================
  *  Mod permissions
@@ -1625,13 +1616,13 @@
 	// Probably best not to change this unless you are smart enough to figure out what you're doing. If you
 	// decide to change it, remember that it is impossible to redefinite/overwrite groups; you may only add
 	// new ones.
-	$config['mod']['groups'] = [
+	$config['mod']['groups'] = array(
 		10	=> 'Janitor',
 		20	=> 'Mod',
 		30	=> 'Admin',
 		// 98	=> 'God',
 		99	=> 'Disabled'
-	];
+	);
 
 	// If you add stuff to the above, you'll need to call this function immediately after.
 	define_groups();
@@ -1641,11 +1632,11 @@
 	// define_groups();
 
 	// Capcode permissions.
-	$config['mod']['capcode'] = [
+	$config['mod']['capcode'] = array(
-		// JANITOR		=> [ 'Janitor' ],
+	//	JANITOR		=> array('Janitor'),
-		MOD		=> [ 'Mod' ],
+		MOD		=> array('Mod'),
 		ADMIN		=> true
-	];
+	);
 
 	// Example: Allow mods to post with "## Moderator" as well
 	// $config['mod']['capcode'][MOD][] = 'Moderator';
@@ -1847,20 +1838,23 @@
  */
 
 	// Public post search settings
-	$config['search'] = [
+	$config['search'] = array();
+
 	// Enable the search form
-		'enable' => false,
+	$config['search']['enable'] = false;
-		// Maximal number of queries per IP address per minutes
-		'queries_per_minutes' => [ 15, 2 ],
-		// Global maximal number of queries per minutes
-		'queries_per_minutes_all' => [ 50, 2 ],
-		// Limit of search results
-		'search_limit' => 100,
-	];
 
 	// Enable search in the board index.
 	$config['board_search'] = false;
 
+	// Maximal number of queries per IP address per minutes
+	$config['search']['queries_per_minutes'] = Array(15, 2);
+
+	// Global maximal number of queries per minutes
+	$config['search']['queries_per_minutes_all'] = Array(50, 2);
+
+	// Limit of search results
+	$config['search']['search_limit'] = 100;
+
 	// Boards for searching
 	//$config['search']['boards'] = array('a', 'b', 'c', 'd', 'e');
 
@@ -1915,33 +1909,31 @@
  * state. Please join #nntpchan on Rizon in order to peer with someone.
  */
 
-	$config['nntpchan'] = [
+	$config['nntpchan'] = array();
+
 	// Enable NNTPChan integration
-		'enabled'=> false,
+	$config['nntpchan']['enabled'] = false;
+
 	// NNTP server
-		'server' => "localhost:1119",
+	$config['nntpchan']['server'] = "localhost:1119";
-		/*
+
-		 * Global dispatch array. Add your boards to it to enable them. Please make
+	// Global dispatch array. Add your boards to it to enable them. Please make
-		 * sure that this setting is set in a global context.
+	// sure that this setting is set in a global context.
-		 */
+	$config['nntpchan']['dispatch'] = array(); // 'overchan.test' => 'test'
-		'dispatch' => [
+
-			// 'overchan.test' => 'test'
+	// Trusted peer - an IP address of your NNTPChan instance. This peer will have
-		],
+	// increased capabilities, eg.: will evade spamfilter.
-		/*
+	$config['nntpchan']['trusted_peer'] = '127.0.0.1';
-		 * Trusted peer - an IP address of your NNTPChan instance. This peer will have increased capabilities, eg.: will
+
-		 * evade spamfilter.
-		 */
-		'trusted_peer' => '127.0.0.1',
 	// Salt for message ID generation. Keep it long and secure.
-		'salt' => 'change_me+please',
+	$config['nntpchan']['salt'] = 'change_me+please';
+
 	// A local message ID domain. Make sure to change it.
-		'domain' => 'example.vichan.net',
+	$config['nntpchan']['domain'] = 'example.vichan.net';
-		/*
+
-		 * An NNTPChan group name.
+	// An NNTPChan group name.
-		 * Please set this setting in your board/config.php, not globally.
+	// Please set this setting in your board/config.php, not globally.
-		 */
+	$config['nntpchan']['group'] = false; // eg. 'overchan.test'
-		'group' => false, // eg. 'overchan.test'
-	];
 
 
 

inc/context.php

@@ -1,91 +1,66 @@
 <?php
 namespace Vichan;
 
-use Vichan\Data\Driver\{CacheDriver, HttpDriver, ErrorLogLogDriver, FileLogDriver, LogDriver, StderrLogDriver, SyslogLogDriver};
+use Vichan\Driver\{HttpDriver, HttpDrivers, Log, LogDrivers};
-use Vichan\Service\HCaptchaQuery;
-use Vichan\Service\NativeCaptchaQuery;
-use Vichan\Service\ReCaptchaQuery;
-use Vichan\Service\RemoteCaptchaQuery;
 
 defined('TINYBOARD') or exit;
 
-class Context {
-	private array $definitions;
 
-	public function __construct(array $definitions) {
+interface DependencyFactory {
-		$this->definitions = $definitions;
+	public function buildLogDriver(): Log;
+	public function buildHttpDriver(): HttpDriver;
 }
 
-	public function get(string $name){
+class WebDependencyFactory implements DependencyFactory {
-		if (!isset($this->definitions[$name])) {
+	private array $config;
-			throw new \RuntimeException("Could not find a dependency named $name");
+
+
+	public function __construct(array $config) {
+		$this->config = $config;
 	}
 
-		$ret = $this->definitions[$name];
+	public function buildLogDriver(): Log {
-		if (is_callable($ret) && !is_string($ret) && !is_array($ret)) {
+		$name = $this->config['log_system']['name'];
-			$ret = $ret($this);
+		$level = $this->config['debug'] ? Log::DEBUG : Log::NOTICE;
-			$this->definitions[$name] = $ret;
+		$backend = $this->config['log_system']['type'];
-		}
-		return $ret;
-	}
-}
-
-function build_context(array $config): Context {
-	return new Context([
-		'config' => $config,
-		LogDriver::class => function($c) {
-			$config = $c->get('config');
-
-			$name = $config['log_system']['name'];
-			$level = $config['debug'] ? LogDriver::DEBUG : LogDriver::NOTICE;
-			$backend = $config['log_system']['type'];
 
 		// Check 'syslog' for backwards compatibility.
-			if ((isset($config['syslog']) && $config['syslog']) || $backend === 'syslog') {
+		if ((isset($this->config['syslog']) && $this->config['syslog']) || $backend === 'syslog') {
-				return new SyslogLogDriver($name, $level, $this->config['log_system']['syslog_stderr']);
+			return LogDrivers::syslog($name, $level, $this->config['log_system']['syslog_stderr']);
 		} elseif ($backend === 'file') {
-				return new FileLogDriver($name, $level, $this->config['log_system']['file_path']);
+			return LogDrivers::file($name, $level, $this->config['log_system']['file_path']);
 		} elseif ($backend === 'stderr') {
-				return new StderrLogDriver($name, $level);
+			return LogDrivers::stderr($name, $level);
+		} elseif ($backend === 'none') {
+			return LogDrivers::none();
 		} else {
-				return new ErrorLogLogDriver($name, $level);
+			return LogDrivers::error_log($name, $level);
 		}
-		},
+	}
-		HttpDriver::class => function($c) {
+
-			$config = $c->get('config');
+	public function buildHttpDriver(): HttpDriver {
-			return new HttpDriver($config['upload_by_url_timeout'], $config['max_filesize']);
+		return HttpDrivers::getHttpDriver(
-		},
+			$this->config['upload_by_url_timeout'],
-		RemoteCaptchaQuery::class => function($c) {
+			$this->config['max_filesize']
-			$config = $c->get('config');
-			$http = $c->get(HttpDriver::class);
-			switch ($config['captcha']['provider']) {
-				case 'recaptcha':
-					return new ReCaptchaQuery($http, $config['captcha']['recaptcha']['secret']);
-				case 'hcaptcha':
-					return new HCaptchaQuery(
-						$http,
-						$config['captcha']['hcaptcha']['secret'],
-						$config['captcha']['hcaptcha']['sitekey']
 		);
-				default:
-					throw new \RuntimeException('No remote captcha service available');
 	}
-		},
-		NativeCaptchaQuery::class => function($c) {
-			$config = $c->get('config');
-			if ($config['captcha']['provider'] !== 'native') {
-				throw new \RuntimeException('No native captcha service available');
 }
-			return new NativeCaptchaQuery(
+
-				$c->get(HttpDriver::class),
+class Context {
-				$config['domain'],
+	private DependencyFactory $factory;
-				$config['captcha']['native']['provider_check'],
+	private ?Log $log;
-				$config['captcha']['native']['extra']
+	private ?HttpDriver $http;
-			);
+
-		},
+
-		CacheDriver::class => function($c) {
+	public function __construct(DependencyFactory $factory) {
-			// Use the global for backwards compatibility.
+		$this->factory = $factory;
-			return \cache::getCache();
+	}
+
+	public function getLog(): Log {
+		return $this->log ??= $this->factory->buildLogDriver();
+	}
+
+	public function getHttpDriver(): HttpDriver {
+		return $this->http ??= $this->factory->buildHttpDriver();
 	}
-	]);
 }

inc/controller.php

@@ -85,24 +85,24 @@ function sb_api($b) { global $config, $build_pages;
 }
 
 function sb_ukko() {
-  Vichan\Functions\Theme\rebuild_theme("ukko", "post-thread");
+  rebuildTheme("ukko", "post-thread");
   return true;
 }
 
 function sb_catalog($b) {
   if (!openBoard($b)) return false;
 
-  Vichan\Functions\Theme\rebuild_theme("catalog", "post-thread", $b); 
+  rebuildTheme("catalog", "post-thread", $b); 
   return true;
 }
 
 function sb_recent() {
-  Vichan\Functions\Theme\rebuild_theme("recent", "post-thread");
+  rebuildTheme("recent", "post-thread");
   return true;
 }
 
 function sb_sitemap() {
-  Vichan\Functions\Theme\rebuild_theme("sitemap", "all");
+  rebuildTheme("sitemap", "all");
   return true;
 }
 

inc/display.php

@@ -401,18 +401,7 @@ class Post {
 	public function build($index=false) {
 		global $board, $config;
 		
-		$options = [
+		return Element($config['file_post_reply'], array('config' => $config, 'board' => $board, 'post' => &$this, 'index' => $index, 'mod' => $this->mod));
-			'config' => $config,
-			'board' => $board,
-			'post' => &$this,
-			'index' => $index,
-			'mod' => $this->mod
-		];
-		if ($this->mod) {
-			$options['pm'] = create_pm_header();
-		}
-
-		return Element($config['file_post_reply'], $options);
 	}
 };
 
@@ -476,22 +465,10 @@ class Thread {
 		
 		event('show-thread', $this);
 
-		$options = [
-			'config' => $config,
-			'board' => $board,
-			'post' => &$this,
-			'index' => $index,
-			'hasnoko50' => $hasnoko50,
-			'isnoko50' => $isnoko50,
-			'mod' => $this->mod
-		];
-		if ($this->mod) {
-			$options['pm'] = create_pm_header();
-		}
-
 		$file = ($index && $config['file_board']) ? $config['file_post_thread_fileboard'] : $config['file_post_thread'];
-		$built = Element($file, $options);
+		$built = Element($file, array('config' => $config, 'board' => $board, 'post' => &$this, 'index' => $index, 'hasnoko50' => $hasnoko50, 'isnoko50' => $isnoko50, 'mod' => $this->mod));
 		
 		return $built;
 	}
 };
+

inc/driver/http-driver.php

@@ -0,0 +1,151 @@
+<?php // Honestly this is just a wrapper for cURL. Still useful to mock it and have an OOP API on PHP 7.
+namespace Vichan\Driver;
+
+use RuntimeException;
+
+defined('TINYBOARD') or exit;
+
+
+class HttpDrivers {
+	private const DEFAULT_USER_AGENT = 'Tinyboard';
+
+
+	public static function getHttpDriver(int $timeout, int $max_file_size): HttpDriver {
+		return new HttpDriver($timeout, self::DEFAULT_USER_AGENT, $max_file_size);
+	}
+}
+
+class HttpDriver {
+	private mixed $inner;
+	private int $timeout;
+	private string $user_agent;
+	private int $max_file_size;
+
+
+	private function resetTowards(string $url, int $timeout): void {
+		curl_reset($this->inner);
+		curl_setopt_array($this->inner, array(
+			CURLOPT_URL => $url,
+			CURLOPT_TIMEOUT => $this->timeout,
+			CURLOPT_USERAGENT => $this->user_agent,
+			CURLOPT_PROTOCOLS => CURLPROTO_HTTP | CURLPROTO_HTTPS,
+		));
+	}
+
+	private function setSizeLimit(): void {
+		// Adapted from: https://stackoverflow.com/a/17642638
+		curl_setopt($this->inner, CURLOPT_NOPROGRESS, false);
+
+		if (PHP_MAJOR_VERSION >= 8 && PHP_MINOR_VERSION >= 2) {
+			curl_setopt($this->inner, CURLOPT_XFERINFOFUNCTION, function($res, $next_dl, $dl, $next_up, $up) {
+				return (int)($dl <= $this->max_file_size);
+			});
+		} else {
+			curl_setopt($this->inner, CURLOPT_PROGRESSFUNCTION, function($res, $next_dl, $dl, $next_up, $up) {
+				return (int)($dl <= $this->max_file_size);
+			});
+		}
+	}
+
+	function __construct($timeout, $user_agent, $max_file_size) {
+		$this->inner = curl_init();
+		$this->timeout = $timeout;
+		$this->user_agent = $user_agent;
+		$this->max_file_size = $max_file_size;
+	}
+
+	function __destruct() {
+		curl_close($this->inner);
+	}
+
+	/**
+	 * Execute a GET request.
+	 *
+	 * @param string $endpoint Uri endpoint.
+	 * @param ?array $data Optional GET parameters.
+	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
+	 * @return string Returns the body of the response.
+	 * @throws RuntimeException Throws on IO error.
+	 */
+	public function requestGet(string $endpoint, ?array $data, int $timeout = 0): string {
+		if (!empty($data)) {
+			$endpoint .= '?' . http_build_query($data);
+		}
+		if ($timeout == 0) {
+			$timeout = $this->timeout;
+		}
+
+		$this->resetTowards($endpoint, $timeout);
+		curl_setopt($this->inner, CURLOPT_RETURNTRANSFER, true);
+		$ret = curl_exec($this->inner);
+
+		if ($ret === false) {
+			throw new \RuntimeException(curl_error($this->inner));
+		}
+		return $ret;
+	}
+
+	/**
+	 * Execute a POST request.
+	 *
+	 * @param string $endpoint Uri endpoint.
+	 * @param ?array $data Optional POST parameters.
+	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
+	 * @return string Returns the body of the response.
+	 * @throws RuntimeException Throws on IO error.
+	 */
+	public function requestPost(string $endpoint, ?array $data, int $timeout = 0): string {
+		if ($timeout == 0) {
+			$timeout = $this->timeout;
+		}
+
+		$this->resetTowards($endpoint, $timeout);
+		curl_setopt($this->inner, CURLOPT_POST, true);
+		if (!empty($data)) {
+			curl_setopt($this->inner, CURLOPT_POSTFIELDS, http_build_query($data));
+		}
+		curl_setopt($this->inner, CURLOPT_RETURNTRANSFER, true);
+		$ret = curl_exec($this->inner);
+
+		if ($ret === false) {
+			throw new \RuntimeException(curl_error($this->inner));
+		}
+		return $ret;
+	}
+
+	/**
+	 * Download the url's target with curl.
+	 *
+	 * @param string $url Url to the file to download.
+	 * @param ?array $data Optional GET parameters.
+	 * @param resource $fd File descriptor to save the content to.
+	 * @param int $timeout Optional request timeout in seconds. Use the default timeout if 0.
+	 * @return bool Returns true on success, false if the file was too large.
+	 * @throws RuntimeException Throws on IO error.
+	 */
+	public function requestGetInto(string $endpoint, ?array $data, mixed $fd, int $timeout = 0): bool {
+		if (!empty($data)) {
+			$endpoint .= '?' . http_build_query($data);
+		}
+		if ($timeout == 0) {
+			$timeout = $this->timeout;
+		}
+
+		$this->resetTowards($endpoint, $timeout);
+		curl_setopt($this->inner, CURLOPT_FAILONERROR, true);
+		curl_setopt($this->inner, CURLOPT_FOLLOWLOCATION, false);
+		curl_setopt($this->inner, CURLOPT_FILE, $fd);
+		curl_setopt($this->inner, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
+		$this->setSizeLimit();
+		$ret = curl_exec($this->inner);
+
+		if ($ret === false) {
+			if (curl_errno($this->inner) === CURLE_ABORTED_BY_CALLBACK) {
+				return false;
+			}
+
+			throw new \RuntimeException(curl_error($this->inner));
+		}
+		return true;
+	}
+}

inc/driver/log-driver.php

@@ -0,0 +1,189 @@
+<?php // Logging
+namespace Vichan\Driver;
+
+use InvalidArgumentException;
+use RuntimeException;
+
+defined('TINYBOARD') or exit;
+
+
+class LogDrivers {
+	public static function levelToString(int $level): string {
+		switch ($level) {
+			case Log::EMERG:
+				return 'EMERG';
+			case Log::ERROR:
+				return 'ERROR';
+			case Log::WARNING:
+				return 'WARNING';
+			case Log::NOTICE:
+				return 'NOTICE';
+			case Log::INFO:
+				return 'INFO';
+			case Log::DEBUG:
+				return 'DEBUG';
+			default:
+				throw new InvalidArgumentException('Not a logging level');
+		}
+	}
+
+	/**
+	 * Log to syslog.
+	 */
+	public static function syslog(string $name, int $level, bool $print_stderr): Log {
+		$flags = LOG_ODELAY;
+		if ($print_stderr) {
+			$flags |= LOG_PERROR;
+		}
+
+		if (!openlog($name, $flags, LOG_USER)) {
+			throw new RuntimeException('Unable to open syslog');
+		}
+
+		return new class($level) implements Log {
+			private $level;
+
+			public function __construct(int $level) {
+				$this->level = $level;
+			}
+
+			public function log(int $level, string $message): void {
+				if ($level <= $this->level) {
+					if (isset($_SERVER['REMOTE_ADDR'], $_SERVER['REQUEST_METHOD'], $_SERVER['REQUEST_URI'])) {
+						// CGI
+						syslog($level, "$message - client: {$_SERVER['REMOTE_ADDR']}, request: \"{$_SERVER['REQUEST_METHOD']} {$_SERVER['REQUEST_URI']}\"");
+					} else {
+						syslog($level, $message);
+					}
+				}
+			}
+		};
+	}
+
+	/**
+	 * Log via the php function error_log.
+	 */
+	public static function error_log(string $name, int $level): Log {
+		return new class($name, $level) implements Log {
+			private string $name;
+			private int $level;
+
+			public function __construct(string $name, int $level) {
+				$this->name = $name;
+				$this->level = $level;
+			}
+
+			public function log(int $level, string $message): void {
+				if ($level <= $this->level) {
+					$lv = LogDrivers::levelToString($level);
+					$line = "{$this->name} $lv: $message";
+					error_log($line, 0, null, null);
+				}
+			}
+		};
+	}
+
+	/**
+	 * Log to a file.
+	 */
+	public static function file(string $name, int $level, string $file_path): Log {
+		/*
+		 * error_log is slow as hell in it's 3rd mode, so use fopen + file locking instead.
+		 * https://grobmeier.solutions/performance-ofnonblocking-write-to-files-via-php-21082009.html
+		 *
+		 * Whatever file appending is atomic is contentious:
+		 *  - There are no POSIX guarantees: https://stackoverflow.com/a/7237901
+		 *  - But linus suggested they are on linux, on some filesystems: https://web.archive.org/web/20151201111541/http://article.gmane.org/gmane.linux.kernel/43445
+		 *  - But it doesn't seem to be always the case: https://www.notthewizard.com/2014/06/17/are-files-appends-really-atomic/
+		 *
+		 * So we just use file locking to be sure.
+		 */
+
+		$fd = fopen($file_path, 'a');
+		if ($fd === false) {
+			throw new RuntimeException("Unable to open log file at $file_path");
+		}
+
+		$logger = new class($name, $level, $fd) implements Log {
+			private string $name;
+			private int $level;
+			private mixed $fd;
+
+			public function __construct(string $name, int $level, mixed $fd) {
+				$this->name = $name;
+				$this->level = $level;
+				$this->fd = $fd;
+			}
+
+			public function log(int $level, string $message): void {
+				if ($level <= $this->level) {
+					$lv = LogDrivers::levelToString($level);
+					$line = "{$this->name} $lv: $message\n";
+					flock($this->fd, LOCK_EX);
+					fwrite($this->fd, $line);
+					flock($this->fd, LOCK_UN);
+				}
+			}
+
+			public function close() {
+				fclose($this->fd);
+			}
+		};
+
+		// Close the file on shutdown.
+		register_shutdown_function([$logger, 'close']);
+
+		return $logger;
+	}
+
+	/**
+	 * Log to php's standard error file stream.
+	 */
+	public static function stderr(string $name, int $level): Log {
+		return new class($name, $level) implements Log {
+			private $name;
+			private $level;
+
+			public function __construct(string $name, int $level) {
+				$this->name = $name;
+				$this->level = $level;
+			}
+
+			public function log(int $level, string $message): void {
+				if ($level <= $this->level) {
+					$lv = LogDrivers::levelToString($level);
+					fwrite(STDERR, "{$this->name} $lv: $message\n");
+				}
+			}
+		};
+	}
+
+	/**
+	 * No-op logging system.
+	 */
+	public static function none(): Log {
+		return new class() implements Log {
+			public function log($level, $message): void {
+				// No-op.
+			}
+		};
+	}
+}
+
+interface Log {
+	public const EMERG = LOG_EMERG;
+	public const ERROR = LOG_ERR;
+	public const WARNING = LOG_WARNING;
+	public const NOTICE = LOG_NOTICE;
+	public const INFO = LOG_INFO;
+	public const DEBUG = LOG_DEBUG;
+
+
+	/**
+	 * Log a message if the level of relevancy is at least the minimum.
+	 *
+	 * @param int $level Message level. Use Log interface constants.
+	 * @param string $message The message to log.
+	 */
+	public function log(int $level, string $message): void;
+}

inc/filters.php

@@ -136,14 +136,6 @@ class Filter {
 				return $post['board'] == $match;
 			case 'password':
 				return $post['password'] == $match;
-			case 'unshorten':
-				$extracted_urls = get_urls($post['body_nomarkup']);
-				foreach ($extracted_urls as $url) {
-					if (preg_match($match, trace_url($url))) {
-						return true;
-					}
-				}
-				return false;
 			default:
 				error('Unknown filter condition: ' . $condition);
 		}

inc/functions.php

@@ -241,7 +241,7 @@ function loadConfig() {
 		$config['version'] = $__version;
 
 		if ($config['allow_roll']) {
-			event_handler('post', 'email_dice_roll');
+			event_handler('post', 'diceRoller');
 		}
 
 		if (in_array('webm', $config['allowed_ext_files']) || in_array('mp4',  $config['allowed_ext_files'])) {
@@ -391,6 +391,114 @@ function define_groups() {
 	ksort($config['mod']['groups']);
 }
 
+function create_antibot($board, $thread = null) {
+	require_once dirname(__FILE__) . '/anti-bot.php';
+
+	return _create_antibot($board, $thread);
+}
+
+function rebuildThemes($action, $boardname = false) {
+	global $config, $board, $current_locale;
+
+	// Save the global variables
+	$_config = $config;
+	$_board = $board;
+
+	// List themes
+	if ($themes = Cache::get("themes")) {
+		// OK, we already have themes loaded
+	}
+	else {
+		$query = query("SELECT `theme` FROM ``theme_settings`` WHERE `name` IS NULL AND `value` IS NULL") or error(db_error());
+
+		$themes = array();
+
+		while ($theme = $query->fetch(PDO::FETCH_ASSOC)) {
+			$themes[] = $theme;
+		}
+
+		Cache::set("themes", $themes);
+	}
+
+	foreach ($themes as $theme) {
+		// Restore them
+		$config = $_config;
+		$board = $_board;
+
+		// Reload the locale
+		if ($config['locale'] != $current_locale) {
+			$current_locale = $config['locale'];
+			init_locale($config['locale']);
+		}
+
+		if (PHP_SAPI === 'cli') {
+			echo "Rebuilding theme ".$theme['theme']."... ";
+		}
+
+		rebuildTheme($theme['theme'], $action, $boardname);
+
+		if (PHP_SAPI === 'cli') {
+			echo "done\n";
+		}
+	}
+
+	// Restore them again
+	$config = $_config;
+	$board = $_board;
+
+	// Reload the locale
+	if ($config['locale'] != $current_locale) {
+		$current_locale = $config['locale'];
+		init_locale($config['locale']);
+	}
+}
+
+
+function loadThemeConfig($_theme) {
+	global $config;
+
+	if (!file_exists($config['dir']['themes'] . '/' . $_theme . '/info.php'))
+		return false;
+
+	// Load theme information into $theme
+	include $config['dir']['themes'] . '/' . $_theme . '/info.php';
+
+	return $theme;
+}
+
+function rebuildTheme($theme, $action, $board = false) {
+	global $config, $_theme;
+	$_theme = $theme;
+
+	$theme = loadThemeConfig($_theme);
+
+	if (file_exists($config['dir']['themes'] . '/' . $_theme . '/theme.php')) {
+		require_once $config['dir']['themes'] . '/' . $_theme . '/theme.php';
+
+		$theme['build_function']($action, themeSettings($_theme), $board);
+	}
+}
+
+
+function themeSettings($theme) {
+	if ($settings = Cache::get("theme_settings_".$theme)) {
+		return $settings;
+	}
+
+	$query = prepare("SELECT `name`, `value` FROM ``theme_settings`` WHERE `theme` = :theme AND `name` IS NOT NULL");
+	$query->bindValue(':theme', $theme);
+	$query->execute() or error(db_error($query));
+
+	$settings = array();
+	while ($s = $query->fetch(PDO::FETCH_ASSOC)) {
+		$settings[$s['name']] = $s['value'];
+	}
+
+	Cache::set("theme_settings_".$theme, $settings);
+
+	return $settings;
+}
+
 function sprintf3($str, $vars, $delim = '%') {
 	$replaces = array();
 	foreach ($vars as $k => $v) {
@@ -768,13 +876,11 @@ function checkBan($board = false) {
 	}
 
 	foreach ($ips as $ip) {
-		$bans = Bans::find($ip, $board, $config['show_modname'], null, $config['auto_maintenance']);
+		$bans = Bans::find($ip, $board, $config['show_modname']);
 
 		foreach ($bans as &$ban) {
 			if ($ban['expires'] && $ban['expires'] < time()) {
-				if ($config['auto_maintenance']) {
 				Bans::delete($ban['id']);
-				}
 				if ($config['require_ban_view'] && !$ban['seen']) {
 					if (!isset($_POST['json_response'])) {
 						displayBan($ban);
@@ -794,21 +900,18 @@ function checkBan($board = false) {
 		}
 	}
 
-	if ($config['auto_maintenance']) {
 	// I'm not sure where else to put this. It doesn't really matter where; it just needs to be called every
 	// now and then to keep the ban list tidy.
-		if ($config['cache']['enabled']) {
+	if ($config['cache']['enabled'] && $last_time_purged = cache::get('purged_bans_last')) {
-			$last_time_purged = cache::get('purged_bans_last');
+		if (time() - $last_time_purged < $config['purge_bans'] )
-			if ($last_time_purged !== false && time() - $last_time_purged > $config['purge_bans']) {
+			return;
-				Bans::purge($config['require_ban_view'], $config['purge_bans']);
+	}
+
+	Bans::purge();
+
+	if ($config['cache']['enabled'])
 		cache::set('purged_bans_last', time());
 }
-		} else {
-			// Purge every time.
-			Bans::purge($config['require_ban_view'], $config['purge_bans']);
-		}
-	}
-}
 
 function threadLocked($id) {
 	global $board;
@@ -1295,14 +1398,7 @@ function index($page, $mod=false, $brief = false) {
 	}
 
 	if ($config['file_board']) {
-		$options = [
+		$body = Element($config['file_fileboard'], array('body' => $body, 'mod' => $mod));
-			'body' => $body,
-			'mod' => $mod
-		];
-		if ($mod) {
-			$options['pm'] = create_pm_header();
-		}
-		$body = Element($config['file_fileboard'], $options);
 	}
 
 	return array(
@@ -1485,7 +1581,7 @@ function checkMute() {
 
 	if ($config['cache']['enabled']) {
 		// Cached mute?
-		if (($mute = cache::get("mute_{$_SERVER['REMOTE_ADDR']}")) && ($mutetime = cache::get("mutetime_{$_SERVER['REMOTE_ADDR']}"))) {
+		if (($mute = cache::get("mute_${_SERVER['REMOTE_ADDR']}")) && ($mutetime = cache::get("mutetime_${_SERVER['REMOTE_ADDR']}"))) {
 			error(sprintf($config['error']['youaremuted'], $mute['time'] + $mutetime - time()));
 		}
 	}
@@ -1504,8 +1600,8 @@ function checkMute() {
 
 		if ($mute['time'] + $mutetime > time()) {
 			if ($config['cache']['enabled']) {
-				cache::set("mute_{$_SERVER['REMOTE_ADDR']}", $mute, $mute['time'] + $mutetime - time());
+				cache::set("mute_${_SERVER['REMOTE_ADDR']}", $mute, $mute['time'] + $mutetime - time());
-				cache::set("mutetime_{$_SERVER['REMOTE_ADDR']}", $mutetime, $mute['time'] + $mutetime - time());
+				cache::set("mutetime_${_SERVER['REMOTE_ADDR']}", $mutetime, $mute['time'] + $mutetime - time());
 			}
 			// Not expired yet
 			error(sprintf($config['error']['youaremuted'], $mute['time'] + $mutetime - time()));
@@ -1516,10 +1612,34 @@ function checkMute() {
 	}
 }
 
-function purge_old_antispam() {
+function _create_antibot($board, $thread) {
-	$query = prepare('DELETE FROM ``antispam`` WHERE `expires` < UNIX_TIMESTAMP()');
+	global $config, $purged_old_antispam;
-	$query->execute() or error(db_error());
+
-	return $query->rowCount();
+	$antibot = new AntiBot(array($board, $thread));
+
+	if (!isset($purged_old_antispam)) {
+		$purged_old_antispam = true;
+		query('DELETE FROM ``antispam`` WHERE `expires` < UNIX_TIMESTAMP()') or error(db_error());
+	}
+
+	if ($thread)
+		$query = prepare('UPDATE ``antispam`` SET `expires` = UNIX_TIMESTAMP() + :expires WHERE `board` = :board AND `thread` = :thread AND `expires` IS NULL');
+	else
+		$query = prepare('UPDATE ``antispam`` SET `expires` = UNIX_TIMESTAMP() + :expires WHERE `board` = :board AND `thread` IS NULL AND `expires` IS NULL');
+
+	$query->bindValue(':board', $board);
+	if ($thread)
+		$query->bindValue(':thread', $thread);
+	$query->bindValue(':expires', $config['spam']['hidden_inputs_expire']);
+	$query->execute() or error(db_error($query));
+
+	$query = prepare('INSERT INTO ``antispam`` VALUES (:board, :thread, :hash, UNIX_TIMESTAMP(), NULL, 0)');
+	$query->bindValue(':board', $board);
+	$query->bindValue(':thread', $thread);
+	$query->bindValue(':hash', $antibot->hash());
+	$query->execute() or error(db_error($query));
+
+	return $antibot;
 }
 
 function checkSpam(array $extra_salt = array()) {
@@ -1584,18 +1704,15 @@ function incrementSpamHash($hash) {
 }
 
 function buildIndex($global_api = "yes") {
-	global $board, $config, $build_pages, $mod;
+	global $board, $config, $build_pages;
 
 	$catalog_api_action = generation_strategy('sb_api', array($board['uri']));
 
 	$pages = null;
+	$antibot = null;
 
 	if ($config['api']['enabled']) {
-		$api = new Api(
+		$api = new Api();
-			$config['show_filename'],
-			$config['hide_email'],
-			$config['country_flags']
-		);
 		$catalog = array();
 	}
 
@@ -1640,15 +1757,21 @@ function buildIndex($global_api = "yes") {
 				if ($wont_build_this_page) continue;
 			}
 
+			if ($config['try_smarter']) {
+				$antibot = create_antibot($board['uri'], 0 - $page);
+				$content['current_page'] = $page;
+			}
+			elseif (!$antibot) {
+				$antibot = create_antibot($board['uri']);
+			}
+			$antibot->reset();
 			if (!$pages) {
 				$pages = getPages();
 			}
 			$content['pages'] = $pages;
 			$content['pages'][$page-1]['selected'] = true;
 			$content['btn'] = getPageButtons($content['pages']);
-			if ($mod) {
+			$content['antibot'] = $antibot;
-				$content['pm'] = create_pm_header();
-			}
 
 			file_write($filename, Element($config['file_board_index'], $content));
 		}
@@ -2229,8 +2352,9 @@ function buildThread($id, $return = false, $mod = false) {
 			error($config['error']['nonexistant']);
 
 		$hasnoko50 = $thread->postCount() >= $config['noko50_min'];
+		$antibot = $mod || $return ? false : create_antibot($board['uri'], $id);
 
-		$options = [
+		$body = Element($config['file_thread'], array(
 			'board' => $board,
 			'thread' => $thread,
 			'body' => $thread->build(),
@@ -2239,22 +2363,14 @@ function buildThread($id, $return = false, $mod = false) {
 			'mod' => $mod,
 			'hasnoko50' => $hasnoko50,
 			'isnoko50' => false,
+			'antibot' => $antibot,
 			'boardlist' => createBoardlist($mod),
 			'return' => ($mod ? '?' . $board['url'] . $config['file_index'] : $config['root'] . $board['dir'] . $config['file_index'])
-		];
+		));
-		if ($mod) {
-			$options['pm'] = create_pm_header();
-		}
-
-		$body = Element($config['file_thread'], $options);
 
 		// json api
 		if ($config['api']['enabled'] && !$mod) {
-			$api = new Api(
+			$api = new Api();
-				$config['show_filename'],
-				$config['hide_email'],
-				$config['country_flags']
-			);
 			$json = json_encode($api->translateThread($thread));
 			$jsonFilename = $board['dir'] . $config['dir']['res'] . $id . '.json';
 			file_write($jsonFilename, $json);
@@ -2275,17 +2391,20 @@ function buildThread($id, $return = false, $mod = false) {
 	} elseif ($action == 'rebuild') {
 		$noko50fn = $board['dir'] . $config['dir']['res'] . link_for($thread, true);
 		if ($hasnoko50 || file_exists($noko50fn)) {
-			buildThread50($id, $return, $mod, $thread);
+			buildThread50($id, $return, $mod, $thread, $antibot);
 		}
 
 		file_write($board['dir'] . $config['dir']['res'] . link_for($thread), $body);
 	}
 }
 
-function buildThread50($id, $return = false, $mod = false, $thread = null) {
+function buildThread50($id, $return = false, $mod = false, $thread = null, $antibot = false) {
-	global $board, $config;
+	global $board, $config, $build_pages;
 	$id = round($id);
 
+	if ($antibot)
+		$antibot->reset();
+
 	if (!$thread) {
 		$query = prepare(sprintf("SELECT * FROM ``posts_%s`` WHERE (`thread` IS NULL AND `id` = :id) OR `thread` = :id ORDER BY `thread`,`id` DESC LIMIT :limit", $board['uri']));
 		$query->bindValue(':id', $id, PDO::PARAM_INT);
@@ -2338,7 +2457,7 @@ function buildThread50($id, $return = false, $mod = false, $thread = null) {
 
 	$hasnoko50 = $thread->postCount() >= $config['noko50_min'];
 
-	$options = [
+	$body = Element($config['file_thread'], array(
 		'board' => $board,
 		'thread' => $thread,
 		'body' => $thread->build(false, true),
@@ -2347,14 +2466,10 @@ function buildThread50($id, $return = false, $mod = false, $thread = null) {
 		'mod' => $mod,
 		'hasnoko50' => $hasnoko50,
 		'isnoko50' => true,
+		'antibot' => $mod ? false : ($antibot ? $antibot : create_antibot($board['uri'], $id)),
 		'boardlist' => createBoardlist($mod),
 		'return' => ($mod ? '?' . $board['url'] . $config['file_index'] : $config['root'] . $board['dir'] . $config['file_index'])
-	];
+	));
-	if ($mod) {
-		$options['pm'] = create_pm_header();
-	}
-
-	$body = Element($config['file_thread'], $options);
 
 	if ($return) {
 		return $body;
@@ -2541,6 +2656,65 @@ function shell_exec_error($command, $suppress_stdout = false) {
 	return $return === 'TB_SUCCESS' ? false : $return;
 }
 
+/* Die rolling:
+ * If "dice XdY+/-Z" is in the email field (where X or +/-Z may be
+ * missing), X Y-sided dice are rolled and summed, with the modifier Z
+ * added on.  The result is displayed at the top of the post.
+ */
+function diceRoller($post) {
+	global $config;
+	if(strpos(strtolower($post->email), 'dice%20') === 0) {
+		$dicestr = str_split(substr($post->email, strlen('dice%20')));
+
+		// Get params
+		$diceX = '';
+		$diceY = '';
+		$diceZ = '';
+
+		$curd = 'diceX';
+		for($i = 0; $i < count($dicestr); $i ++) {
+			if(is_numeric($dicestr[$i])) {
+				$$curd .= $dicestr[$i];
+			} else if($dicestr[$i] == 'd') {
+				$curd = 'diceY';
+			} else if($dicestr[$i] == '-' || $dicestr[$i] == '+') {
+				$curd = 'diceZ';
+				$$curd = $dicestr[$i];
+			}
+		}
+
+		// Default values for X and Z
+		if($diceX == '') {
+			$diceX = '1';
+		}
+
+		if($diceZ == '') {
+			$diceZ = '+0';
+		}
+
+		// Intify them
+		$diceX = intval($diceX);
+		$diceY = intval($diceY);
+		$diceZ = intval($diceZ);
+
+		// Continue only if we have valid values
+		if($diceX > 0 && $diceY > 0) {
+			$dicerolls = array();
+			$dicesum = $diceZ;
+			for($i = 0; $i < $diceX; $i++) {
+				$roll = rand(1, $diceY);
+				$dicerolls[] = $roll;
+				$dicesum += $roll;
+			}
+
+			// Prepend the result to the post body
+			$modifier = ($diceZ != 0) ? ((($diceZ < 0) ? ' - ' : ' + ') . abs($diceZ)) : '';
+			$dicesum = ($diceX > 1) ? ' = ' . $dicesum : '';
+			$post->body = '<table class="diceroll"><tr><td><img src="'.$config['dir']['static'].'d10.svg" alt="Dice roll" width="24"></td><td>Rolled ' . implode(', ', $dicerolls) . $modifier . $dicesum . '</td></tr></table><br/>' . $post->body;
+		}
+	}
+}
+
 function slugify($post) {
 	global $config;
 
@@ -2646,6 +2820,7 @@ function purify_html($s) {
 function markdown($s) {
 	$pd = new Parsedown();
 	$pd->setMarkupEscaped(true);
+	$pd->setimagesEnabled(false);
 
 	return $pd->text($s);
 }
@@ -2848,34 +3023,3 @@ function check_thread_limit($post) {
 		return $r['count'] >= $config['max_threads_per_hour'];
 	}
 }
-
-function hashPassword($password) {
-	global $config;
-
-	return hash('sha3-256', $password . $config['secure_password_salt']);
-}
-
-// Thanks to https://gist.github.com/marijn/3901938
-function trace_url($url) {
-	$ch = curl_init($url);
-	curl_setopt_array($ch, array(
-		CURLOPT_FOLLOWLOCATION => TRUE,  // the magic sauce
-		CURLOPT_RETURNTRANSFER => TRUE,
-		CURLOPT_SSL_VERIFYHOST => FALSE, // suppress certain SSL errors
-		CURLOPT_SSL_VERIFYPEER => FALSE,
-		CURLOPT_TIMEOUT => 30,
-	));
-	curl_exec($ch);
-	$url = curl_getinfo($ch, CURLINFO_EFFECTIVE_URL);
-	curl_close($ch);
-	return $url;
-}
-
-// Thanks to https://stackoverflow.com/questions/10002227/linkify-regex-function-php-daring-fireball-method/10002262#10002262
-function get_urls($body) {
-	$regex = '(?xi)\b((?:https?://|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}/)(?:[^\s()<>]+|\(([^\s()<>]+|(\([^\s()<>]+\)))*\))+(?:\(([^\s()<>]+|(\([^\s()<>]+\)))*\)|[^\s`!()\[\]{};:\'".,<>?«»“”‘’]))';
-
-	$result = preg_match_all("#$regex#i", $body, $match);
-
-	return $match[0];
-}

inc/functions/dice.php

@@ -1,114 +0,0 @@
-<?php
-namespace Vichan\Functions\Dice;
-
-function _get_or_default_int(array $arr, int $index, int $default) {
-	return (isset($arr[$index]) && is_numeric($arr[$index])) ? (int)$arr[$index] : $default;
-}
-
-
-/* Die rolling:
- * If "dice XdY+/-Z" is in the email field (where X or +/-Z may be
- * missing), X Y-sided dice are rolled and summed, with the modifier Z
- * added on.  The result is displayed at the top of the post.
- */
-function email_dice_roll($post) {
-	global $config;
-	if(strpos(strtolower($post->email), 'dice%20') === 0) {
-		$dicestr = str_split(substr($post->email, strlen('dice%20')));
-
-		// Get params
-		$diceX = '';
-		$diceY = '';
-		$diceZ = '';
-
-		$curd = 'diceX';
-		for($i = 0; $i < count($dicestr); $i ++) {
-			if(is_numeric($dicestr[$i])) {
-				$$curd .= $dicestr[$i];
-			} else if($dicestr[$i] == 'd') {
-				$curd = 'diceY';
-			} else if($dicestr[$i] == '-' || $dicestr[$i] == '+') {
-				$curd = 'diceZ';
-				$$curd = $dicestr[$i];
-			}
-		}
-
-		// Default values for X and Z
-		if($diceX == '') {
-			$diceX = '1';
-		}
-
-		if($diceZ == '') {
-			$diceZ = '+0';
-		}
-
-		// Intify them
-		$diceX = intval($diceX);
-		$diceY = intval($diceY);
-		$diceZ = intval($diceZ);
-
-		// Continue only if we have valid values
-		if($diceX > 0 && $diceY > 0) {
-			$dicerolls = array();
-			$dicesum = $diceZ;
-			for($i = 0; $i < $diceX; $i++) {
-				$roll = rand(1, $diceY);
-				$dicerolls[] = $roll;
-				$dicesum += $roll;
-			}
-
-			// Prepend the result to the post body
-			$modifier = ($diceZ != 0) ? ((($diceZ < 0) ? ' - ' : ' + ') . abs($diceZ)) : '';
-			$dicesum = ($diceX > 1) ? ' = ' . $dicesum : '';
-			$post->body = '<table class="diceroll"><tr><td><img src="'.$config['dir']['static'].'d10.svg" alt="Dice roll" width="24"></td><td>Rolled ' . implode(', ', $dicerolls) . $modifier . $dicesum . '</td></tr></table><br/>' . $post->body;
-		}
-	}
-}
-
-/**
- * Rolls a dice and generates the appropriate html from the markup.
- * @param array $matches The array of the matches according to the default configuration.
- *                       1 -> The number of dices to roll.
- *                       3 -> The number faces of the dices.
- *                       4 -> The offset to apply to the dice.
- * @param string $img_path Path to the image to use relative to the root. Null if none.
- * @return string The html to replace the original markup with.
- */
-function inline_dice_roll_markup(array $matches, ?string $img_path): string {
-	global $config;
-
-	$dice_count = _get_or_default_int($matches, 1, 1);
-	$dice_faces = _get_or_default_int($matches, 3, 6);
-	$dice_offset = _get_or_default_int($matches, 4, 0);
-
-	// Clamp between 1 and max_roll_count.
-	$dice_count = max(min($dice_count, $config['max_roll_count']), 1);
-	// Must be at least 2.
-	if ($dice_faces < 2) {
-		$dice_faces = 6;
-	}
-
-	$tot = 0;
-	for ($i = 0; $i < $dice_count; $i++) {
-		$tot += mt_rand(1, $dice_faces);
-	}
-	// Ensure that final result is at least an integer.
-	$tot = abs((int)($dice_offset + $tot));
-
-
-	if ($img_path !== null) {
-		$img_text = "<img src='{$config['root']}{$img_path}' alt='dice' title='dice' class=\"inline-dice\"/>";
-	} else {
-		$img_text = '';
-	}
-
-	if ($dice_offset === 0) {
-		$dice_offset_text = '';
-	} elseif ($dice_offset > 0) {
-		$dice_offset_text = "+{$dice_offset}";
-	} else {
-		$dice_offset_text = (string)$dice_offset;
-	}
-
-	return "<span>$img_text {$dice_count}d{$dice_faces}{$dice_offset_text} = <b>$tot</b></span>";
-}

inc/functions/theme.php

@@ -1,98 +0,0 @@
-<?php
-namespace Vichan\Functions\Theme;
-
-
-function rebuild_themes(string $action, $boardname = false): void {
-	global $config, $board, $current_locale;
-
-	// Save the global variables
-	$_config = $config;
-	$_board = $board;
-
-	// List themes
-	if ($themes = \Cache::get("themes")) {
-		// OK, we already have themes loaded
-	} else {
-		$query = query("SELECT `theme` FROM ``theme_settings`` WHERE `name` IS NULL AND `value` IS NULL") or error(db_error());
-		$themes = $query->fetchAll(\PDO::FETCH_NUM);
-
-		\Cache::set("themes", $themes);
-	}
-
-	foreach ($themes as $theme) {
-		// Restore them
-		$config = $_config;
-		$board = $_board;
-
-		// Reload the locale
-		if ($config['locale'] != $current_locale) {
-			$current_locale = $config['locale'];
-			init_locale($config['locale']);
-		}
-
-		if (PHP_SAPI === 'cli') {
-			echo "Rebuilding theme ".$theme[0]."... ";
-		}
-
-		rebuild_theme($theme[0], $action, $boardname);
-
-		if (PHP_SAPI === 'cli') {
-			echo "done\n";
-		}
-	}
-
-	// Restore them again
-	$config = $_config;
-	$board = $_board;
-
-	// Reload the locale
-	if ($config['locale'] != $current_locale) {
-		$current_locale = $config['locale'];
-		init_locale($config['locale']);
-	}
-}
-
-function load_theme_config($_theme) {
-	global $config;
-
-	if (!file_exists($config['dir']['themes'] . '/' . $_theme . '/info.php')) {
-		return false;
-	}
-
-	// Load theme information into $theme
-	include $config['dir']['themes'] . '/' . $_theme . '/info.php';
-
-	return $theme;
-}
-
-function rebuild_theme($theme, string $action, $board = false) {
-	global $config, $_theme;
-	$_theme = $theme;
-
-	$theme = load_theme_config($_theme);
-
-	if (file_exists($config['dir']['themes'] . '/' . $_theme . '/theme.php')) {
-		require_once $config['dir']['themes'] . '/' . $_theme . '/theme.php';
-
-		$theme['build_function']($action, theme_settings($_theme), $board);
-	}
-}
-
-function theme_settings($theme): array {
-	if ($settings = \Cache::get("theme_settings_" . $theme)) {
-		return $settings;
-	}
-
-	$query = prepare("SELECT `name`, `value` FROM ``theme_settings`` WHERE `theme` = :theme AND `name` IS NOT NULL");
-	$query->bindValue(':theme', $theme);
-	$query->execute() or error(db_error($query));
-
-	$settings = [];
-	while ($s = $query->fetch(\PDO::FETCH_ASSOC)) {
-		$settings[$s['name']] = $s['value'];
-	}
-
-	\Cache::set("theme_settings_".$theme, $settings);
-
-	return $settings;
-}

inc/lock.php

@@ -1,6 +1,7 @@
 <?php
+
 class Locks {
-    private static function filesystem(string $key) {
+	private static function filesystem(string $key): Lock|false {
 		$key = str_replace('/', '::', $key);
 		$key = str_replace("\0", '', $key);
 
@@ -10,14 +11,15 @@ class Locks {
 		}
 
 		return new class($fd) implements Lock {
-            // Resources have no type in PHP.
+			// Resources have no type in php.
-            private $f;
+			private mixed $f;
 
-            public function __construct($fd) {
+
+			function __construct($fd) {
 				$this->f = $fd;
 			}
 
-            public function get(bool $nonblock = false) {
+			public function get(bool $nonblock = false): Lock|false {
 				$wouldblock = false;
 				flock($this->f, LOCK_SH | ($nonblock ? LOCK_NB : 0), $wouldblock);
 				if ($nonblock && $wouldblock) {
@@ -26,7 +28,7 @@ class Locks {
 				return $this;
 			}
 
-            public function get_ex(bool $nonblock = false) {
+			public function get_ex(bool $nonblock = false): Lock|false {
 				$wouldblock = false;
 				flock($this->f, LOCK_EX | ($nonblock ? LOCK_NB : 0), $wouldblock);
 				if ($nonblock && $wouldblock) {
@@ -35,30 +37,33 @@ class Locks {
 				return $this;
 			}
 
-            public function free() {
+			public function free(): Lock {
 				flock($this->f, LOCK_UN);
 				return $this;
 			}
 		};
 	}
 
-    public static function none() {
+	/**
+	 * No-op. Can be used for mocking.
+	 */
+	public static function none(): Lock|false {
 		return new class() implements Lock {
-            public function get(bool $nonblock = false) {
+			public function get(bool $nonblock = false): Lock|false {
 				return $this;
 			}
 
-            public function get_ex(bool $nonblock = false) {
+			public function get_ex(bool $nonblock = false): Lock|false {
 				return $this;
 			}
 
-            public function free() {
+			public function free(): Lock {
 				return $this;
 			}
 		};
 	}
 
-    public static function get_lock(array $config, string $key) {
+	public static function get_lock(array $config, string $key): Lock|false {
 		if ($config['lock']['enabled'] == 'fs') {
 			return self::filesystem($key);
 		} else {
@@ -68,9 +73,12 @@ class Locks {
 }
 
 interface Lock {
-    public function get(bool $nonblock = false);
+	// Get a shared lock
+	public function get(bool $nonblock = false): Lock|false;
 
-    public function get_ex(bool $nonblock = false);
+	// Get an exclusive lock
+	public function get_ex(bool $nonblock = false): Lock|false;
 
-    public function free();
+	// Free a lock
+	public function free(): Lock;
 }

inc/mod/auth.php

@@ -4,13 +4,12 @@
  *  Copyright (c) 2010-2013 Tinyboard Development Group
  */
 
-use Vichan\Context;
 use Vichan\Functions\Net;
 
 defined('TINYBOARD') or exit;
 
 // create a hash/salt pair for validate logins
-function mkhash(string $username, $password = null, $salt = false) {
+function mkhash(string $username, string $password, mixed $salt = false): array|string {
 	global $config;
 
 	if (!$salt) {
@@ -79,7 +78,7 @@ function calc_cookie_name(bool $is_https, bool $is_path_jailed, string $base_nam
 	}
 }
 
-function login(string $username, string $password) {
+function login(string $username, string $password): array|false {
 	global $mod, $config;
 
 	$query = prepare("SELECT `id`, `type`, `boards`, `password`, `version` FROM ``mods`` WHERE BINARY `username` = :username");
@@ -196,7 +195,7 @@ function modLog(string $action, ?string $_board = null): void {
 	}
 }
 
-function create_pm_header() {
+function create_pm_header(): mixed {
 	global $mod, $config;
 
 	if ($config['cache']['enabled'] && ($header = cache::get('pm_unread_' . $mod['id'])) != false) {
@@ -233,7 +232,7 @@ function make_secure_link_token(string $uri): string {
 	return substr(sha1($config['cookies']['salt'] . '-' . $uri . '-' . $mod['id']), 0, 8);
 }
 
-function check_login(Context $ctx, bool $prompt = false): void {
+function check_login(bool $prompt = false): void {
 	global $config, $mod;
 
 	$is_https = Net\is_connection_secure($config['cookies']['secure_login_only'] === 1);
@@ -247,9 +246,7 @@ function check_login(Context $ctx, bool $prompt = false): void {
 		if (count($cookie) != 3) {
 			// Malformed cookies
 			destroyCookies();
-			if ($prompt) {
+			if ($prompt) mod_login();
-				mod_login($ctx);
-			}
 			exit;
 		}
 
@@ -262,9 +259,7 @@ function check_login(Context $ctx, bool $prompt = false): void {
 		if ($cookie[1] !== mkhash($cookie[0], $user['password'], $cookie[2])) {
 			// Malformed cookies
 			destroyCookies();
-			if ($prompt) {
+			if ($prompt) mod_login();
-				mod_login($ctx);
-			}
 			exit;
 		}
 

inc/mod/config-editor.php

@@ -65,10 +65,6 @@ function config_vars() {
 			$temp_comment = false;
 		}
 		
-		if (preg_match('!^\s*\$config\[(\'log_system\'|\'captcha\')\]!', $line)) {
-            continue;
-        }
-		
 		if (preg_match('!^\s*// ([^$].*)$!', $line, $matches)) {
 			if ($var['default'] !== false) {
 				$line = '';

inc/queue.php

@@ -73,7 +73,7 @@ class Queues {
 		};
 	}
 
-	public static function get_queue(array $config, string $name) {
+	public static function get_queue(array $config, string $name): Queue|false {
 		if (!isset(self::$queues[$name])) {
 			if ($config['queue']['enabled'] == 'fs') {
 				$lock = Locks::get_lock($config, $name);

inc/service/captcha-queries.php

@@ -1,141 +1,100 @@
 <?php // Verify captchas server side.
 namespace Vichan\Service;
 
-use Vichan\Data\Driver\HttpDriver;
+use Vichan\Driver\HttpDriver;
 
 defined('TINYBOARD') or exit;
 
 
-class ReCaptchaQuery implements RemoteCaptchaQuery {
+class RemoteCaptchaQuery {
 	private HttpDriver $http;
 	private string $secret;
+	private string $endpoint;
+
 
 	/**
-	 * Creates a new ReCaptchaQuery using the google recaptcha service.
+	 * Creates a new CaptchaRemoteQueries instance using the google recaptcha service.
 	 *
 	 * @param HttpDriver $http The http client.
 	 * @param string $secret Server side secret.
-	 * @return ReCaptchaQuery A new ReCaptchaQuery query instance.
+	 * @return CaptchaRemoteQueries A new captcha query instance.
 	 */
-	public function __construct(HttpDriver $http, string $secret) {
+	public static function withRecaptcha(HttpDriver $http, string $secret): RemoteCaptchaQuery {
-		$this->http = $http;
+		return new self($http, $secret, 'https://www.google.com/recaptcha/api/siteverify');
-		$this->secret = $secret;
 	}
 
-	public function responseField(): string {
-		return 'g-recaptcha-response';
-	}
-
-	public function verify(string $response, ?string $remote_ip): bool {
-		$data = [
-			'secret' => $this->secret,
-			'response' => $response
-		];
-
-		if ($remote_ip !== null) {
-			$data['remoteip'] = $remote_ip;
-		}
-
-		$ret = $this->http->requestGet('https://www.google.com/recaptcha/api/siteverify', $data);
-		$resp = json_decode($ret, true, 16, JSON_THROW_ON_ERROR);
-
-		return isset($resp['success']) && $resp['success'];
-	}
-}
-
-class HCaptchaQuery implements RemoteCaptchaQuery {
-	private HttpDriver $http;
-	private string $secret;
-	private string $sitekey;
-
 	/**
-	 * Creates a new HCaptchaQuery using the hCaptcha service.
+	 * Creates a new CaptchaRemoteQueries instance using the hcaptcha service.
 	 *
 	 * @param HttpDriver $http The http client.
 	 * @param string $secret Server side secret.
-	 * @return HCaptchaQuery A new hCaptcha query instance.
+	 * @return CaptchaRemoteQueries A new captcha query instance.
 	 */
-	public function __construct(HttpDriver $http, string $secret, string $sitekey) {
+	public static function withHCaptcha(HttpDriver $http, string $secret): RemoteCaptchaQuery {
+		return new self($http, $secret, 'https://hcaptcha.com/siteverify');
+	}
+
+	private function __construct(HttpDriver $http, string $secret, string $endpoint) {
 		$this->http = $http;
 		$this->secret = $secret;
-		$this->sitekey = $sitekey;
+		$this->endpoint = $endpoint;
 	}
 
-	public function responseField(): string {
-		return 'h-captcha-response';
-	}
-
-	public function verify(string $response, ?string $remote_ip): bool {
-		$data = [
-			'secret' => $this->secret,
-			'response' => $response,
-			'sitekey' => $this->sitekey
-		];
-
-		if ($remote_ip !== null) {
-			$data['remoteip'] = $remote_ip;
-		}
-
-		$ret = $this->http->requestGet('https://hcaptcha.com/siteverify', $data);
-		$resp = json_decode($ret, true, 16, JSON_THROW_ON_ERROR);
-
-		return isset($resp['success']) && $resp['success'];
-	}
-}
-
-interface RemoteCaptchaQuery {
-	/**
-	 * Name of the response field in the form data expected by the implementation.
-	 *
-	 * @return string The name of the field.
-	 */
-	public function responseField(): string;
-
 	/**
 	 * Checks if the user at the remote ip passed the captcha.
 	 *
 	 * @param string $response User provided response.
-	 * @param ?string $remote_ip User ip. Leave to null to only check the response value.
+	 * @param string $remote_ip User ip.
 	 * @return bool Returns true if the user passed the captcha.
 	 * @throws RuntimeException|JsonException Throws on IO errors or if it fails to decode the answer.
 	 */
-	public function verify(string $response, ?string $remote_ip): bool;
+	public function verify(string $response, string $remote_ip): bool {
+		$data = array(
+			'secret' => $this->secret,
+			'response' => $response,
+			'remoteip' => $remote_ip
+		);
+
+		$ret = $this->http->requestGet($this->endpoint, $data);
+		$resp = json_decode($ret, true, 16, JSON_THROW_ON_ERROR);
+
+		return isset($resp['success']) && $resp['success'];
+	}
 }
 
 class NativeCaptchaQuery {
 	private HttpDriver $http;
 	private string $domain;
 	private string $provider_check;
-	private string $extra;
+
 
 	/**
 	 * @param HttpDriver $http The http client.
 	 * @param string $domain The server's domain.
 	 * @param string $provider_check Path to the endpoint.
-	 * @param string $extra Extra http parameters.
 	 */
-	function __construct(HttpDriver $http, string $domain, string $provider_check, string $extra) {
+	function __construct(HttpDriver $http, string $domain, string $provider_check) {
 		$this->http = $http;
 		$this->domain = $domain;
 		$this->provider_check = $provider_check;
-		$this->extra = $extra;
 	}
 
 	/**
 	 * Checks if the user at the remote ip passed the native vichan captcha.
 	 *
+	 * @param string $extra Extra http parameters.
 	 * @param string $user_text Remote user's text input.
 	 * @param string $user_cookie Remote user cookie.
 	 * @return bool Returns true if the user passed the check.
 	 * @throws RuntimeException Throws on IO errors.
 	 */
-	public function verify(string $user_text, string $user_cookie): bool {
+	public function verify(string $extra, string $user_text, string $user_cookie): bool {
-		$data = [
+		$data = array(
 			'mode' => 'check',
 			'text' => $user_text,
-			'extra' => $this->extra,
+			'extra' => $extra,
 			'cookie' => $user_cookie
-		];
+		);
 
 		$ret = $this->http->requestGet($this->domain . '/' . $this->provider_check, $data);
 		return $ret === '1';

inc/template.php

@@ -34,6 +34,10 @@ function Element($templateFile, array $options) {
 	if (!$twig)
 		load_twig();
 
+	if (function_exists('create_pm_header') && ((isset($options['mod']) && $options['mod']) || isset($options['__mod'])) && !preg_match('!^mod/!', $templateFile)) {
+		$options['pm'] = create_pm_header();
+	}
+
 	if (isset($options['body']) && $config['debug']) {
 		$_debug = $debug;
 
@@ -163,11 +167,7 @@ function twig_push_filter($array, $value) {
 }
 
 function twig_date_filter($date, $format) {
-    if (is_numeric($date)) {
-        $date = new DateTime("@$date", new DateTimeZone('UTC'));
-    } else {
 	$date = new DateTime($date, new DateTimeZone('UTC'));
-    }
 	return $date->format($format);
 }
 

install.php

@@ -1,7 +1,7 @@
 <?php
 
 // Installation/upgrade file
-define('VERSION', '5.2.1');
+define('VERSION', '5.2.0');
 require 'inc/bootstrap.php';
 loadConfig();
 
@@ -635,6 +635,19 @@ if (file_exists($config['has_installed'])) {
 			  	`created_at` int(11),
 			  	PRIMARY KEY (`cookie`,`extra`)
 				) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;') or error(db_error());
+		case '5.1.4':
+			//This was done in earlier versions, but certain failed checks caused many to still use utf8mb3 and MyISAM.
+                        foreach ($boards as &$board) {
+                                query(sprintf("ALTER TABLE ``posts_%s`` ENGINE=InnoDB, CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci", $board['uri'])) or error(db_error());
+	                        }
+			$tables = [
+			        'antispam', 'bans', 'ban_appeals', 'boards', 'captchas', 'flood', 'ip_notes', 'modlogs', 'mods', 'mutes', 'news', 'nntp_references', 'noticeboard', 'pages', 'pms', 'reports', 'search_queries', 'theme_settings'
+			    ];
+		
+		    foreach ($tables as $table) {
+		        query(sprintf("ALTER TABLE ``%s`` ENGINE=InnoDB, CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci", $table)) or error(db_error());
+		    }
+		//Let's not drop the telegrams table in case board admins still need them for something.
 		case false:
 			// TODO: enhance Tinyboard -> vichan upgrade path.
 			query("CREATE TABLE IF NOT EXISTS ``search_queries`` (  `ip` varchar(39) NOT NULL,  `time` int(11) NOT NULL,  `query` text NOT NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8;") or error(db_error());
@@ -690,7 +703,9 @@ if ($step == 0) {
 	echo Element('page.html', $page);
 } elseif ($step == 1) {
 	//The HTTPS check doesn't work properly when in those arrays, so let's run it here and pass along the result during the actual check.
-	$httpsvalue = !empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off';
+	if (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off') {
+        $httpsvalue = true;
+    }
 	$page['title'] = 'Pre-installation test';
 
 	$can_exec = true;
@@ -872,7 +887,7 @@ if ($step == 0) {
 		array(
 			'category' => 'Misc',
 			'name' => 'HTTPS being used',
-			'result' => $httpsvalue,
+			'result' => $httpsvalue = true,
 			'required' => false,
 			'message' => 'You are not currently using https for vichan, or at least for your backend server. If this intentional, add "$config[\'cookies\'][\'secure_login_only\'] = 0;" (or 1 if using a proxy) on a new line under "Additional configuration" on the next page.'
 		),
@@ -921,7 +936,6 @@ if ($step == 0) {
 	$sg = new SaltGen();
 	$config['cookies']['salt'] = $sg->generate();
 	$config['secure_trip_salt'] = $sg->generate();
-	$config['secure_password_salt'] = $sg->generate();
 
 	echo Element('page.html', array(
 		'body' => Element('installer/config.html', array(

install.sql

@@ -294,8 +294,7 @@ CREATE TABLE IF NOT EXISTS `ban_appeals` (
   `message` text NOT NULL,
   `denied` tinyint(1) NOT NULL,
   PRIMARY KEY (`id`),
-  KEY `ban_id` (`ban_id`),
+  KEY `ban_id` (`ban_id`)
-  CONSTRAINT `fk_ban_id` FOREIGN KEY (`ban_id`) REFERENCES `bans`(`id`) ON DELETE CASCADE
 ) ENGINE=InnoDB  DEFAULT CHARSET=utf8mb4 AUTO_INCREMENT=1 ;
 
 -- --------------------------------------------------------

js/catalog-link.js

@@ -30,7 +30,17 @@ function catalog() {
     var link = document.createElement('a');
     link.href = catalog_url;
 
-    if (!pages) {
+    if (pages) {
+        link.textContent = _('Catalog');
+        link.style.color = '#F10000';
+        link.style.padding = '4px';
+        link.style.paddingLeft = '9px';
+        link.style.borderLeft = '1px solid';
+        link.style.borderLeftColor = '#A8A8A8';
+        link.style.textDecoration = "underline";
+
+        pages.appendChild(link);
+    } else {
         link.textContent = '['+_('Catalog')+']';
         link.style.paddingLeft = '10px';
         link.style.textDecoration = "underline";

js/catalog-search.js

@@ -8,21 +8,21 @@
  *   $config['additional_javascript'][] = 'js/comment-toolbar.js';
  */
 if (active_page == 'catalog') {
-	onReady(function() {
+	onready(function () {
 		'use strict';
 
 		//	'true' = enable shortcuts
-		let useKeybinds = true;
+		var useKeybinds = true;
 
 		//	trigger the search 400ms after last keystroke
-		let delay = 400;
+		var delay = 400;
-		let timeoutHandle;
+		var timeoutHandle;
 
 		//search and hide none matching threads
 		function filter(search_term) {
 			$('.replies').each(function () {
-				let subject = $(this).children('.intro').text().toLowerCase();
+				var subject = $(this).children('.intro').text().toLowerCase();
-				let comment = $(this).clone().children().remove(':lt(2)').end().text().trim().toLowerCase();
+				var comment = $(this).clone().children().remove(':lt(2)').end().text().trim().toLowerCase();
 				search_term = search_term.toLowerCase();
 
 				if (subject.indexOf(search_term) == -1 && comment.indexOf(search_term) == -1) {
@@ -34,7 +34,7 @@ if (active_page == 'catalog') {
 		}
 
 		function searchToggle() {
-			let button = $('#catalog_search_button');
+			var button = $('#catalog_search_button');
 
 			if (!button.data('expanded')) {
 				button.data('expanded', '1');

js/download-original.js

@@ -15,9 +15,9 @@
  *
  */
 
-onReady(function() {
+onready(function(){
-	let doOriginalFilename = function() {
+	var do_original_filename = function() {
-		let filename, truncated;
+		var filename, truncated;
 		if ($(this).attr('title')) {
 			filename = $(this).attr('title');
 			truncated = true;
@@ -34,9 +34,9 @@ onReady(function() {
 			);
 	};
 
-	$('.postfilename').each(doOriginalFilename);
+	$('.postfilename').each(do_original_filename);
 
         $(document).on('new_post', function(e, post) {
-		$(post).find('.postfilename').each(doOriginalFilename);
+		$(post).find('.postfilename').each(do_original_filename);
 	});
 });

js/expand-all-images.js

@@ -16,26 +16,23 @@
  *
  */
 
-if (active_page == 'ukko' || active_page == 'thread' || active_page == 'index') {
+if (active_page == 'ukko' || active_page == 'thread' || active_page == 'index')
-	onReady(function() {
+onready(function(){
 	$('hr:first').before('<div id="expand-all-images" style="text-align:right"><a class="unimportant" href="javascript:void(0)"></a></div>');
 	$('div#expand-all-images a')
 		.text(_('Expand all images'))
 		.click(function() {
 			$('a img.post-image').each(function() {
 				// Don't expand YouTube embeds
-					if ($(this).parent().parent().hasClass('video-container')) {
+				if ($(this).parent().parent().hasClass('video-container'))
 					return;
-					}
 
 				// or WEBM
-					if (/^\/player\.php\?/.test($(this).parent().attr('href'))) {
+				if (/^\/player\.php\?/.test($(this).parent().attr('href')))
 					return;
-					}
 
-					if (!$(this).parent().data('expanded')) {
+				if (!$(this).parent().data('expanded'))
 					$(this).parent().click();
-					}
 			});
 
 			if (!$('#shrink-all-images').length) {
@@ -46,12 +43,10 @@ if (active_page == 'ukko' || active_page == 'thread' || active_page == 'index')
 				.text(_('Shrink all images'))
 				.click(function(){
 					$('a img.full-image').each(function() {
-							if ($(this).parent().data('expanded')) {
+						if ($(this).parent().data('expanded'))
 							$(this).parent().click();
-							}
 					});
 					$(this).parent().remove();
 				});
 		});
 });
-}

js/expand-filename.js

@@ -1,53 +0,0 @@
-/*
- * expand-filename.js
- * https://github.com/vichan-devel/vichan/blob/master/js/expand-filename.js
- *
- * Released under the MIT license
- * Copyright (c) 2024 Perdedora <weav@anche.no>
- *
- * Usage:
- *   $config['additional_javascript'][] = 'js/expand-filename.js';
- *
- */
-
-function doFilename(element) {
-    const filenames = element.querySelectorAll('[data-truncate="true"]');
-    filenames.forEach(filename => {
-        filename.addEventListener('mouseover', event => addHover(event.target));
-        filename.addEventListener('mouseout', event => removeHover(event.target));
-    });
-}
-
-function addHover(element) {
-    element.dataset.truncatedFilename = element.textContent;
-    element.textContent = element.download;
-}
-
-function removeHover(element) {
-    element.textContent = element.dataset.truncatedFilename;
-    delete element.dataset.truncatedFilename;
-}
-
-document.addEventListener('DOMContentLoaded', () => {
-    doFilename(document);
-
-    // Create a MutationObserver to watch for new elements
-    const observer = new MutationObserver(mutationsList => {
-        mutationsList.forEach(mutation => {
-            if (mutation.type === 'childList') {
-                mutation.addedNodes.forEach(addedNode => {
-                    if (addedNode.nodeType === Node.ELEMENT_NODE) {
-                        // Apply `doFilename` to newly added elements
-                        doFilename(addedNode);
-                    }
-                });
-            }
-        });
-    });
-
-    // Start observing the document body for changes
-    observer.observe(document.body, {
-        childList: true,
-        subtree: true
-    });
-});

js/expand-too-long.js

@@ -0,0 +1,39 @@
+/*
+ * expand-too-long.js
+ * https://github.com/vichan-devel/vichan/blob/master/js/expand-too-long.js
+ *
+ * Released under the MIT license
+ * Copyright (c) 2013-2014 Marcin Łabanowski <marcin@6irc.net>
+ *
+ * Usage:
+ *   $config['additional_javascript'][] = 'js/jquery.min.js';
+ *   $config['additional_javascript'][] = 'js/expand-too-long.js';
+ *      
+ */
+
+$(function() {
+	var do_expand = function() {
+		$(this).find('a').click(function(e) {
+			e.preventDefault();
+
+			var url = $(this).attr('href');
+			var body = $(this).parents('.body');
+
+			$.ajax({
+				url: url,
+				context: document.body,
+				success: function(data) {
+					var content = $(data).find('#'+url.split('#')[1]).parent().parent().find(".body").first().html();
+
+					body.html(content);
+				}
+			});
+		});
+	};
+
+        $('.toolong').each(do_expand);
+                       
+        $(document).on("new_post", function(e, post) {
+		$(post).find('.toolong').each(do_expand)
+	});
+});

js/expand-video.js

@@ -2,32 +2,26 @@
 /* Note: This code expects the global variable configRoot to be set. */
 
 if (typeof _ == 'undefined') {
-	var _ = function(a) {
+  var _ = function(a) { return a; };
-		return a;
-	};
 }
 
 function setupVideo(thumb, url) {
-	if (thumb.videoAlreadySetUp) {
+    if (thumb.videoAlreadySetUp) return;
-		return;
-	}
     thumb.videoAlreadySetUp = true;
 
-	let video = null;
+    var video = null;
-	let videoContainer, videoHide;
+    var videoContainer, videoHide;
-	let expanded = false;
+    var expanded = false;
-	let hovering = false;
+    var hovering = false;
-	let loop = true;
+    var loop = true;
-	let loopControls = [document.createElement("span"), document.createElement("span")];
+    var loopControls = [document.createElement("span"), document.createElement("span")];
-	let fileInfo = thumb.parentNode.querySelector(".fileinfo");
+    var fileInfo = thumb.parentNode.querySelector(".fileinfo");
-	let mouseDown = false;
+    var mouseDown = false;
 
     function unexpand() {
         if (expanded) {
             expanded = false;
-			if (video.pause) {
+            if (video.pause) video.pause();
-				video.pause();
-			}
             videoContainer.style.display = "none";
             thumb.style.display = "inline";
             video.style.maxWidth = "inherit";
@@ -38,9 +32,7 @@ function setupVideo(thumb, url) {
     function unhover() {
         if (hovering) {
             hovering = false;
-			if (video.pause) {
+            if (video.pause) video.pause();
-				video.pause();
-			}
             videoContainer.style.display = "none";
             video.style.maxWidth = "inherit";
             video.style.maxHeight = "inherit";
@@ -89,12 +81,6 @@ function setupVideo(thumb, url) {
         }
     }
 
-	function setVolume() {
-		const volume = setting("videovolume");
-		video.volume = volume;
-		video.muted = (volume === 0);
-	}
-
     // Clicking on thumbnail expands video
     thumb.addEventListener("click", function(e) {
         if (setting("videoexpand") && !e.shiftKey && !e.ctrlKey && !e.altKey && !e.metaKey) {
@@ -111,21 +97,15 @@ function setupVideo(thumb, url) {
             video.parentNode.parentNode.removeAttribute('style');
             thumb.style.display = "none";
 
-			setVolume();
+            video.muted = (setting("videovolume") == 0);
+            video.volume = setting("videovolume");
             video.controls = true;
             if (video.readyState == 0) {
                 video.addEventListener("loadedmetadata", expand2, false);
             } else {
                 setTimeout(expand2, 0);
             }
-			let promise = video.play();
-			if (promise !== undefined) {
-				promise.then(_ => {
-				}).catch(_ => {
-					video.muted = true;
             video.play();
-				});
-			}
             e.preventDefault();
         }
     }, false);
@@ -149,18 +129,16 @@ function setupVideo(thumb, url) {
             expanded = false;
             hovering = true;
 
-			let docRight = document.documentElement.getBoundingClientRect().right;
+            var docRight = document.documentElement.getBoundingClientRect().right;
-			let thumbRight = thumb.querySelector("img, video").getBoundingClientRect().right;
+            var thumbRight = thumb.querySelector("img, video").getBoundingClientRect().right;
-			let maxWidth = docRight - thumbRight - 20;
+            var maxWidth = docRight - thumbRight - 20;
-			if (maxWidth < 250) {
+            if (maxWidth < 250) maxWidth = 250;
-				maxWidth = 250;
-			}
 
             video.style.position = "fixed";
             video.style.right = "0px";
             video.style.top = "0px";
-			docRight = document.documentElement.getBoundingClientRect().right;
+            var docRight = document.documentElement.getBoundingClientRect().right;
-			thumbRight = thumb.querySelector("img, video").getBoundingClientRect().right;
+            var thumbRight = thumb.querySelector("img, video").getBoundingClientRect().right;
             video.style.maxWidth = maxWidth + "px";
             video.style.maxHeight = "100%";
             video.style.pointerEvents = "none";
@@ -170,16 +148,10 @@ function setupVideo(thumb, url) {
             videoContainer.style.display = "inline";
             videoContainer.style.position = "fixed";
 
-			setVolume();
+            video.muted = (setting("videovolume") == 0);
+            video.volume = setting("videovolume");
             video.controls = false;
-			let promise = video.play();
-			if (promise !== undefined) {
-				promise.then(_ => {
-				}).catch(_ => {
-					video.muted = true;
             video.play();
-				});
-			}
         }
     }, false);
 
@@ -189,18 +161,10 @@ function setupVideo(thumb, url) {
     thumb.addEventListener("wheel", function(e) {
         if (setting("videohover")) {
             var volume = setting("videovolume");
-			if (e.deltaY > 0) {
+            if (e.deltaY > 0) volume -= 0.1;
-				volume -= 0.1;
+            if (e.deltaY < 0) volume += 0.1;
-			}
+            if (volume < 0) volume = 0;
-			if (e.deltaY < 0) {
+            if (volume > 1) volume = 1;
-				volume += 0.1;
-			}
-			if (volume < 0) {
-				volume = 0;
-			}
-			if (volume > 1) {
-				volume = 1;
-			}
             if (video != null) {
                 video.muted = (volume == 0);
                 video.volume = volume;
@@ -238,41 +202,36 @@ function setupVideo(thumb, url) {
 }
 
 function setupVideosIn(element) {
-	let thumbs = element.querySelectorAll("a.file");
+    var thumbs = element.querySelectorAll("a.file");
-	for (let i = 0; i < thumbs.length; i++) {
+    for (var i = 0; i < thumbs.length; i++) {
         if (/\.webm$|\.mp4$/.test(thumbs[i].pathname)) {
             setupVideo(thumbs[i], thumbs[i].href);
         } else {
-			let m = thumbs[i].search.match(/\bv=([^&]*)/);
+            var m = thumbs[i].search.match(/\bv=([^&]*)/);
             if (m != null) {
-				let url = decodeURIComponent(m[1]);
+                var url = decodeURIComponent(m[1]);
-				if (/\.webm$|\.mp4$/.test(url)) {
+                if (/\.webm$|\.mp4$/.test(url)) setupVideo(thumbs[i], url);
-					setupVideo(thumbs[i], url);
-				}
             }
         }
     }
 }
 
-onReady(function(){
+onready(function(){
     // Insert menu from settings.js
-	if (typeof settingsMenu != "undefined" && typeof Options == "undefined") {
+    if (typeof settingsMenu != "undefined" && typeof Options == "undefined")
       document.body.insertBefore(settingsMenu, document.getElementsByTagName("hr")[0]);
-	}
 
     // Setup Javascript events for videos in document now
     setupVideosIn(document);
 
     // Setup Javascript events for videos added by updater
     if (window.MutationObserver) {
-		let observer = new MutationObserver(function(mutations) {
+        var observer = new MutationObserver(function(mutations) {
-			for (let i = 0; i < mutations.length; i++) {
+            for (var i = 0; i < mutations.length; i++) {
-				let additions = mutations[i].addedNodes;
+                var additions = mutations[i].addedNodes;
-				if (additions == null) {
+                if (additions == null) continue;
-					continue;
+                for (var j = 0; j < additions.length; j++) {
-				}
+                    var node = additions[j];
-				for (let j = 0; j < additions.length; j++) {
-					let node = additions[j];
                     if (node.nodeType == 1) {
                         setupVideosIn(node);
                     }
@@ -282,3 +241,4 @@ onReady(function(){
         observer.observe(document.body, {childList: true, subtree: true});
     }
 });
+

js/inline-expanding-filename.js

@@ -13,10 +13,10 @@
  *
  */
 
-onReady(function() {
+onready(function(){
-	let inlineExpandingFilename = function() {
+	var inline_expanding_filename = function() {
 		$(this).find(".fileinfo > a").click(function(){
-			let imagelink = $(this).parent().parent().find('a[target="_blank"]:first');
+			var imagelink = $(this).parent().parent().find('a[target="_blank"]:first');
 			if(imagelink.length > 0) {
 				imagelink.click();
 				return false;
@@ -24,10 +24,10 @@ onReady(function() {
 		});
 	};
 
-	$('div[id^="thread_"]').each(inlineExpandingFilename);
+        $('div[id^="thread_"]').each(inline_expanding_filename);
                                         
         // allow to work with auto-reload.js, etc.
         $(document).on('new_post', function(e, post) {
-		inlineExpandingFilename.call(post);
+                inline_expanding_filename.call(post);
         });
 });

js/local-time.js

@@ -17,45 +17,29 @@ $(document).ready(function(){
 	'use strict';
 
 	var iso8601 = function(s) {
-		var parts = s.split('T');
+		s = s.replace(/\.\d\d\d+/,""); // remove milliseconds
-		if (parts.length === 2) {
+		s = s.replace(/-/,"/").replace(/-/,"/");
-			var timeParts = parts[1].split(':');
+		s = s.replace(/T/," ").replace(/Z/," UTC");
-			if (timeParts.length === 3) {
+		s = s.replace(/([\+\-]\d\d)\:?(\d\d)/," $1$2"); // -04:00 -> -0400
-				var seconds = timeParts[2];
-				if (seconds.length > 2) {
-					seconds = seconds.substr(0, 2) + '.' + seconds.substr(2);
-				}
-				// Ensure seconds part is valid
-				if (parseFloat(seconds) > 59) {
-					seconds = '59';
-				}
-				timeParts[2] = seconds;
-			}
-			parts[1] = timeParts.join(':');
-		}
-		s = parts.join('T');
-
-		if (!s.endsWith('Z')) {
-			s += 'Z';
-		}
 		return new Date(s);
 	};
-
 	var zeropad = function(num, count) {
 		return [Math.pow(10, count - num.toString().length), num].join('').substr(1);
 	};
 
 	var dateformat = (typeof strftime === 'undefined') ? function(t) {
 		return zeropad(t.getMonth() + 1, 2) + "/" + zeropad(t.getDate(), 2) + "/" + t.getFullYear().toString().substring(2) +
-				" (" + ["Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"][t.getDay()] + ") " +
+				" (" + [_("Sun"), _("Mon"), _("Tue"), _("Wed"), _("Thu"), _("Fri"), _("Sat"), _("Sun")][t.getDay()]  + ") " +
 				// time
 				zeropad(t.getHours(), 2) + ":" + zeropad(t.getMinutes(), 2) + ":" + zeropad(t.getSeconds(), 2);
+
 	} : function(t) {
 		// post_date is defined in templates/main.js
 		return strftime(window.post_date, t, datelocale);
 	};
 
 	function timeDifference(current, previous) {
+
 		var msPerMinute = 60 * 1000;
 		var msPerHour = msPerMinute * 60;
 		var msPerDay = msPerHour * 24;
@@ -85,17 +69,18 @@ $(document).ready(function(){
 
 		for(var i = 0; i < times.length; i++) {
 			var t = times[i].getAttribute('datetime');
-			var postTime = iso8601(t);
+			var postTime = new Date(t);
 
 			times[i].setAttribute('data-local', 'true');
 
 			if (localStorage.show_relative_time === 'false') {
-				times[i].innerHTML = dateformat(postTime);
+				times[i].innerHTML = dateformat(iso8601(t));
 				times[i].setAttribute('title', timeDifference(currentTime, postTime.getTime()));
 			} else {
 				times[i].innerHTML = timeDifference(currentTime, postTime.getTime());
-				times[i].setAttribute('title', dateformat(postTime));
+				times[i].setAttribute('title', dateformat(iso8601(t)));
 			}
+		
 		}
 	};
 
@@ -128,4 +113,3 @@ $(document).ready(function(){
 
 	do_localtime(document);
 });
-

js/mod/ban-list.js

@@ -60,8 +60,8 @@ var banlist_init = function(token, my_boards, inMod) {
       // duration?
       expires: {name: _("Expires"), width: "235px", fmt: function(f) {
 	if (!f.expires || f.expires == 0) return "<em>"+_("never")+"</em>";
-  var formattedDate = strftime("%m/%d/%Y (%a) %H:%M:%S", new Date((f.expires|0)*1000), datelocale);
+        return strftime(window.post_date, new Date((f.expires|0)*1000), datelocale) + 
-  return formattedDate + ((f.expires < time()) ? "" : " <small>"+_("in ")+until(f.expires|0)+"</small>");
+          ((f.expires < time()) ? "" : " <small>"+_("in ")+until(f.expires|0)+"</small>");
       } },
       username: {name: _("Staff"), width: "100px", fmt: function(f) {
 	var pre='',suf='',un=f.username;
@@ -129,7 +129,6 @@ var banlist_init = function(token, my_boards, inMod) {
     $(".banform").on("submit", function() { return false; });
 
     $("#unban").on("click", function() {
-      if (confirm('Are you sure you want to unban the selected IPs?')) {
       $(".banform .hiddens").remove();
       $("<input type='hidden' name='unban' value='unban' class='hiddens'>").appendTo(".banform");
 
@@ -138,7 +137,6 @@ var banlist_init = function(token, my_boards, inMod) {
       });
 
       $(".banform").off("submit").submit();
-      }
     });
 
     if (device_type == 'desktop') {

js/post-hover.js

@@ -13,62 +13,59 @@
  *
  */
 
-onReady(function() {
+onready(function(){
-	let dontFetchAgain = [];
+	var dont_fetch_again = [];
-	initHover = function() {
+	init_hover = function() {
-		let link = $(this);
+		var $link = $(this);
-		let id;
-		let matches;
 		
-		if (link.is('[data-thread]')) {
+		var id;
-			id = link.attr('data-thread');
+		var matches;
-		} else if (matches = link.text().match(/^>>(?:>\/([^\/]+)\/)?(\d+)$/)) {
+
+                if ($link.is('[data-thread]')) {
+                        id = $link.attr('data-thread');
+                }
+		else if(matches = $link.text().match(/^>>(?:>\/([^\/]+)\/)?(\d+)$/)) {
 			id = matches[2];
-		} else {
+		}
+		else {
 			return;
 		}
 		
-		let board = $(this);
+		var board = $(this);
 		while (board.data('board') === undefined) {
 			board = board.parent();
 		}
-		let threadid;
+		var threadid;
-		if (link.is('[data-thread]')) {
+		if ($link.is('[data-thread]')) threadid = 0;
-			threadid = 0;
+		else threadid = board.attr('id').replace("thread_", "");
-		} else {
-			threadid = board.attr('id').replace("thread_", "");
-		}
 
 		board = board.data('board');
 
-		let parentboard = board;
+		var parentboard = board;
 		
-		if (link.is('[data-thread]')) {
+		if ($link.is('[data-thread]')) parentboard = $('form[name="post"] input[name="board"]').val();
-			parentboard = $('form[name="post"] input[name="board"]').val();
+		else if (matches[1] !== undefined) board = matches[1];
-		} else if (matches[1] !== undefined) {
-			board = matches[1];
-		}
 
-		let post = false;
+		var $post = false;
-		let hovering = false;
+		var hovering = false;
-		let hoveredAt;
+		var hovered_at;
-		link.hover(function(e) {
+		$link.hover(function(e) {
 			hovering = true;
-			hoveredAt = {'x': e.pageX, 'y': e.pageY};
+			hovered_at = {'x': e.pageX, 'y': e.pageY};
 			
-			let startHover = function(link) {
+			var start_hover = function($link) {
-				if (post.is(':visible') &&
+				if ($post.is(':visible') &&
-						post.offset().top >= $(window).scrollTop() &&
+						$post.offset().top >= $(window).scrollTop() &&
-						post.offset().top + post.height() <= $(window).scrollTop() + $(window).height()) {
+						$post.offset().top + $post.height() <= $(window).scrollTop() + $(window).height()) {
 					// post is in view
-					post.addClass('highlighted');
+					$post.addClass('highlighted');
 				} else {
-					let newPost = post.clone();
+					var $newPost = $post.clone();
-					newPost.find('>.reply, >br').remove();
+					$newPost.find('>.reply, >br').remove();
-					newPost.find('span.mentioned').remove();
+					$newPost.find('span.mentioned').remove();
-					newPost.find('a.post_anchor').remove();
+					$newPost.find('a.post_anchor').remove();
 
-					newPost
+					$newPost
 						.attr('id', 'post-hover-' + id)
 						.attr('data-board', board)
 						.addClass('post-hover')
@@ -79,28 +76,28 @@ onReady(function() {
 						.css('font-style', 'normal')
 						.css('z-index', '100')
 						.addClass('reply').addClass('post')
-						.insertAfter(link.parent())
+						.insertAfter($link.parent())
 
-					link.trigger('mousemove');
+					$link.trigger('mousemove');
 				}
 			};
 			
-			post = $('[data-board="' + board + '"] div.post#reply_' + id + ', [data-board="' + board + '"]div#thread_' + id);
+			$post = $('[data-board="' + board + '"] div.post#reply_' + id + ', [data-board="' + board + '"]div#thread_' + id);
-			if (post.length > 0) {
+			if($post.length > 0) {
-				startHover($(this));
+				start_hover($(this));
 			} else {
-				let url = link.attr('href').replace(/#.*$/, '');
+				var url = $link.attr('href').replace(/#.*$/, '');
 				
-				if ($.inArray(url, dontFetchAgain) != -1) {
+				if($.inArray(url, dont_fetch_again) != -1) {
 					return;
 				}
-				dontFetchAgain.push(url);
+				dont_fetch_again.push(url);
 				
 				$.ajax({
 					url: url,
 					context: document.body,
 					success: function(data) {
-						let mythreadid = $(data).find('div[id^="thread_"]').attr('id').replace("thread_", "");
+						var mythreadid = $(data).find('div[id^="thread_"]').attr('id').replace("thread_", "");
 
 						if (mythreadid == threadid && parentboard == board) {
 							$(data).find('div.post.reply').each(function() {
@@ -108,70 +105,66 @@ onReady(function() {
 									$('[data-board="' + board + '"]#thread_' + threadid + " .post.reply:first").before($(this).hide().addClass('hidden'));
 								}
 							});
-						} else if ($('[data-board="' + board + '"]#thread_' + mythreadid).length > 0) {
+						}
+						else if ($('[data-board="' + board + '"]#thread_'+mythreadid).length > 0) {
 							$(data).find('div.post.reply').each(function() {
 								if($('[data-board="' + board + '"] #' + $(this).attr('id')).length == 0) {
 									$('[data-board="' + board + '"]#thread_' + mythreadid + " .post.reply:first").before($(this).hide().addClass('hidden'));
 								}
 							});
-						} else {
+						}
+						else {
 							$(data).find('div[id^="thread_"]').hide().attr('data-cached', 'yes').prependTo('form[name="postcontrols"]');
 						}
 
-						post = $('[data-board="' + board + '"] div.post#reply_' + id + ', [data-board="' + board + '"]div#thread_' + id);
+						$post = $('[data-board="' + board + '"] div.post#reply_' + id + ', [data-board="' + board + '"]div#thread_' + id);
 
-						if (hovering && post.length > 0) {
+						if(hovering && $post.length > 0) {
-							startHover(link);
+							start_hover($link);
 						}
 					}
 				});
 			}
 		}, function() {
 			hovering = false;
-			if (!post) {
+			if(!$post)
 				return;
-			}
 			
-			post.removeClass('highlighted');
+			$post.removeClass('highlighted');
-			if (post.hasClass('hidden') || post.data('cached') == 'yes') {
+			if($post.hasClass('hidden') || $post.data('cached') == 'yes')
-				post.css('display', 'none');
+				$post.css('display', 'none');
-			}
 			$('.post-hover').remove();
 		}).mousemove(function(e) {
-			if (!post) {
+			if(!$post)
 				return;
-			}
 			
-			let hover = $('#post-hover-' + id + '[data-board="' + board + '"]');
+			var $hover = $('#post-hover-' + id + '[data-board="' + board + '"]');
-			if (hover.length == 0) {
+			if($hover.length == 0)
 				return;
-			}
 
-			let scrollTop = $(window).scrollTop();
+			var scrollTop = $(window).scrollTop();
-			if (link.is("[data-thread]")) {
+			if ($link.is("[data-thread]")) scrollTop = 0;
-				scrollTop = 0;
+			var epy = e.pageY;
-			}
+			if ($link.is("[data-thread]")) epy -= $(window).scrollTop();			
-			let epy = e.pageY;
-			if (link.is("[data-thread]")) {
-				epy -= $(window).scrollTop();
-			}
 
-			let top = (epy ? epy : hoveredAt['y']) - 10;
+			var top = (epy ? epy : hovered_at['y']) - 10;
 			
 			if(epy < scrollTop + 15) {
 				top = scrollTop;
-			} else if (epy > scrollTop + $(window).height() - hover.height() - 15) {
+			} else if(epy > scrollTop + $(window).height() - $hover.height() - 15) {
-				top = scrollTop + $(window).height() - hover.height() - 15;
+				top = scrollTop + $(window).height() - $hover.height() - 15;
 			}
 			
-			hover.css('left', (e.pageX ? e.pageX : hoveredAt['x'])).css('top', top);
+			
+			$hover.css('left', (e.pageX ? e.pageX : hovered_at['x'])).css('top', top);
 		});
 	};
 	
-	$('div.body a:not([rel="nofollow"])').each(initHover);
+	$('div.body a:not([rel="nofollow"])').each(init_hover);
 	
 	// allow to work with auto-reload.js, etc.
 	$(document).on('new_post', function(e, post) {
-		$(post).find('div.body a:not([rel="nofollow"])').each(initHover);
+		$(post).find('div.body a:not([rel="nofollow"])').each(init_hover);
 	});
 });
+

js/quote-selection.js

@@ -10,12 +10,12 @@
  * Usage:
  *   $config['additional_javascript'][] = 'js/jquery.min.js';
  *   $config['additional_javascript'][] = 'js/quote-selection.js';
+ *
  */
 
 $(document).ready(function(){
-	if (!window.getSelection) {
+	if (!window.getSelection)
 		return;
-	}
 	
 	$.fn.selectRange = function(start, end) {
 		return this.each(function() {
@@ -23,7 +23,7 @@ $(document).ready(function() {
 				this.focus();
 				this.setSelectionRange(start, end);
 			} else if (this.createTextRange) {
-				let range = this.createTextRange();
+				var range = this.createTextRange();
 				range.collapse(true);
 				range.moveEnd('character', end);
 				range.moveStart('character', start);
@@ -32,74 +32,81 @@ $(document).ready(function() {
 		});
 	};
 	
-	let altKey = false;
+	var altKey = false;
-	let ctrlKey = false;
+	var ctrlKey = false;
-	let metaKey = false;
+	var metaKey = false;
 	
 	$(document).keyup(function(e) {
-		if (e.keyCode == 18) {
+		if (e.keyCode == 18)
 			altKey = false;
-		} else if (e.keyCode == 17) {
+		else if (e.keyCode == 17)
 			ctrlKey = false;
-		} else if (e.keyCode == 91) {
+		else if (e.keyCode == 91)
 			metaKey = false;
-		}
 	});
 	
 	$(document).keydown(function(e) {
-		if (e.altKey) {
+		if (e.altKey)
 			altKey = true;
-		} else if (e.ctrlKey) {
+		else if (e.ctrlKey)
 			ctrlKey = true;
-		} else if (e.metaKey) {
+		else if (e.metaKey)
 			metaKey = true;
-		}
 		
 		if (altKey || ctrlKey || metaKey) {
+			// console.log('CTRL/ALT/Something used. Ignoring');
 			return;
 		}
 		
-		if (e.keyCode < 48 || e.keyCode > 90) {
+		if (e.keyCode < 48 || e.keyCode > 90)
+			return;
+		
+		var selection = window.getSelection();
+		var $post = $(selection.anchorNode).parents('.post');
+		if ($post.length == 0) {
+			// console.log('Start of selection was not post div', $(selection.anchorNode).parent());
 			return;
 		}
 		
-		let selection = window.getSelection();
+		var postID = $post.find('.post_no:eq(1)').text();
-		let post = $(selection.anchorNode).parents('.post');
-		if (post.length == 0) {
-			return;
-		}
-
-		let postID = post.find('.post_no:eq(1)').text();
 		
 		if (postID != $(selection.focusNode).parents('.post').find('.post_no:eq(1)').text()) {
+			// console.log('Selection left post div', $(selection.focusNode).parent());
 			return;
 		}
 		
-		let selectedText = selection.toString();
+		;
+		var selectedText = selection.toString();
+		// console.log('Selected text: ' + selectedText.replace(/\n/g, '\\n').replace(/\r/g, '\\r'));
 		
-		if ($('body').hasClass('debug')) {
+		if ($('body').hasClass('debug'))
 			alert(selectedText);
-		}
 		
-		if (selectedText.length == 0) {
+		if (selectedText.length == 0)
 			return;
-		}
 		
-		let body = $('textarea#body')[0];
+		var body = $('textarea#body')[0];
 		
-		let last_quote = body.value.match(/[\S.]*(^|[\S\s]*)>>(\d+)/);
+		var last_quote = body.value.match(/[\S.]*(^|[\S\s]*)>>(\d+)/);
-		if (last_quote) {
+		if (last_quote)
 			last_quote = last_quote[2];
-		}
 		
 		/* to solve some bugs on weird browsers, we need to replace \r\n with \n and then undo that after */
-		let quote = (last_quote != postID ? '>>' + postID + '\r\n' : '') + $.trim(selectedText).replace(/\r\n/g, '\n').replace(/^/mg, '>').replace(/\n/g, '\r\n') + '\r\n';
+		var quote = (last_quote != postID ? '>>' + postID + '\r\n' : '') + $.trim(selectedText).replace(/\r\n/g, '\n').replace(/^/mg, '>').replace(/\n/g, '\r\n') + '\r\n';
 		
+		// console.log('Deselecting text');
 		selection.removeAllRanges();
 		
-		if (body.selectionStart || body.selectionStart == '0') {
+		if (document.selection) {
-			let start = body.selectionStart;
+			// IE
-			let end = body.selectionEnd;
+			body.focus();
+			var sel = document.selection.createRange();
+			sel.text = quote;
+			body.focus();
+		} else if (body.selectionStart || body.selectionStart == '0') {
+			// Mozilla
+			var start = body.selectionStart;
+			var end = body.selectionEnd;
 			
 			if (!body.value.substring(0, start).match(/(^|\n)$/)) {
 				quote = '\r\n\r\n' + quote;
@@ -114,3 +121,4 @@ $(document).ready(function() {
 		}
 	});
 });
+

js/show-backlinks.js

@@ -13,42 +13,38 @@
  *
  */
 
-onReady(function() {
+onready(function(){
-	let showBackLinks = function() {
+	var showBackLinks = function() {
-		let reply_id = $(this).attr('id').replace(/(^reply_)|(^op_)/, '');
+		var reply_id = $(this).attr('id').replace(/(^reply_)|(^op_)/, '');
 		
 		$(this).find('div.body a:not([rel="nofollow"])').each(function() {
-			let id, post, $mentioned;
+			var id, post, $mentioned;
 		
-			if (id = $(this).text().match(/^>>(\d+)$/)) {
+			if(id = $(this).text().match(/^>>(\d+)$/))
 				id = id[1];
-			} else {
+			else
 				return;
-			}
 		
 			$post = $('#reply_' + id);
 			if($post.length == 0){
 				$post = $('#op_' + id);
-				if ($post.length == 0) {
+				if($post.length == 0)
 					return;
 			}
-			}
 		
 			$mentioned = $post.find('p.intro span.mentioned');
-			if($mentioned.length == 0) {
+			if($mentioned.length == 0)
 				$mentioned = $('<span class="mentioned unimportant"></span>').appendTo($post.find('p.intro'));
-			}
 			
-			if ($mentioned.find('a.mentioned-' + reply_id).length != 0) {
+			if ($mentioned.find('a.mentioned-' + reply_id).length != 0)
 				return;
-			}
 			
-			let link = $('<a class="mentioned-' + reply_id + '" onclick="highlightReply(\'' + reply_id + '\');" href="#' + reply_id + '">&gt;&gt;' +
+			var $link = $('<a class="mentioned-' + reply_id + '" onclick="highlightReply(\'' + reply_id + '\');" href="#' + reply_id + '">&gt;&gt;' +
 				reply_id + '</a>');
-			link.appendTo($mentioned)
+			$link.appendTo($mentioned)
 			
 			if (window.init_hover) {
-				link.each(init_hover);
+				$link.each(init_hover);
 			}
 		});
 	};
@@ -57,10 +53,9 @@ onReady(function() {
 	$('div.post.op').each(showBackLinks);
 
         $(document).on('new_post', function(e, post) {
+		showBackLinks.call(post);
 		if ($(post).hasClass("op")) {
 			$(post).find('div.post.reply').each(showBackLinks);
-		} else {
-			$(post).parent().find('div.post.reply').each(showBackLinks);
 		}
 	});
 });

js/smartphone-spoiler.js

@@ -12,11 +12,11 @@
  *
  */
 
-onReady(function() {
+onready(function(){
 	if(device_type == 'mobile') {
-		let fix_spoilers = function(where) {
+		var fix_spoilers = function(where) {
-			let spoilers = where.getElementsByClassName('spoiler');
+			var spoilers = where.getElementsByClassName('spoiler');
-			for (let i = 0; i < spoilers.length; i++) {
+			for(var i = 0; i < spoilers.length; i++) {
 				spoilers[i].onmousedown = function() {
 					this.style.color = 'white';
 				};
@@ -31,3 +31,4 @@ onReady(function() {
 	
 	}
 });
+

js/style-select.js

@@ -14,18 +14,17 @@
  *
  */
 
-onReady(function() {
+onready(function(){
-	let stylesDiv = $('div.styles');
+	var stylesDiv = $('div.styles');
-	let stylesSelect = $('<select></select>');
+	var stylesSelect = $('<select></select>');
 	
-	let i = 1;
+	var i = 1;
 	stylesDiv.children().each(function() {
-		let opt = $('<option></option>')
+		var opt = $('<option></option>')
 			.html(this.innerHTML.replace(/(^\[|\]$)/g, ''))
 			.val(i);
-		if ($(this).hasClass('selected')) {
+		if ($(this).hasClass('selected'))
 			opt.attr('selected', true);
-		}
 		stylesSelect.append(opt);
 		$(this).attr('id', 'style-select-' + i);
 		i++;
@@ -43,3 +42,4 @@ onReady(function() {
 			.append(stylesSelect)
 	);
 });
+

js/youtube.js

@@ -22,10 +22,11 @@
 *
 */
 
-onReady(function() {
+
-	let do_embed_yt = function(tag) {
+onready(function(){
+	var do_embed_yt = function(tag) {
 		$('div.video-container a', tag).click(function() {
-			let videoID = $(this.parentNode).data('video');
+			var videoID = $(this.parentNode).data('video');
 		
 			$(this.parentNode).html('<iframe style="float:left;margin: 10px 20px" type="text/html" '+
 				'width="360" height="270" src="//www.youtube.com/embed/' + videoID +
@@ -41,3 +42,4 @@ onReady(function() {
                 do_embed_yt(post);
         });
 });
+

mod.php

@@ -1,24 +1,21 @@
 <?php
+
 /*
  *  Copyright (c) 2010-2014 Tinyboard Development Group
  */
 
 require_once 'inc/bootstrap.php';
 
-if ($config['debug']) {
+if ($config['debug'])
 	$parse_start_time = microtime(true);
-}
 
 require_once 'inc/mod/pages.php';
 
-
+check_login(true);
-$ctx = Vichan\build_context($config);
-
-check_login($ctx, true);
 
 $query = isset($_SERVER['QUERY_STRING']) ? rawurldecode($_SERVER['QUERY_STRING']) : '';
 
-$pages = [
+$pages = array(
 	''					=> ':?/',			// redirect to dashboard
 	'/'					=> 'dashboard',			// dashboard
 	'/confirm/(.+)'				=> 'confirm',			// confirm action (if javascript didn't work)
@@ -112,14 +109,14 @@ $pages = [
 			str_replace('%d', '(\d+)', preg_quote($config['file_page'], '!'))	=> 'view_thread',
 
 	'/(\%b)/' . preg_quote($config['dir']['res'], '!') .
-			str_replace([ '%d','%s' ], [ '(\d+)', '[a-z0-9-]+' ], preg_quote($config['file_page50_slug'], '!'))	=> 'view_thread50',
+			str_replace(array('%d','%s'), array('(\d+)', '[a-z0-9-]+'), preg_quote($config['file_page50_slug'], '!'))	=> 'view_thread50',
 	'/(\%b)/' . preg_quote($config['dir']['res'], '!') .
-			str_replace([ '%d','%s' ], [ '(\d+)', '[a-z0-9-]+' ], preg_quote($config['file_page_slug'], '!'))	=> 'view_thread',
+			str_replace(array('%d','%s'), array('(\d+)', '[a-z0-9-]+'), preg_quote($config['file_page_slug'], '!'))	=> 'view_thread',
-];
+);
 
 
 if (!$mod) {
-	$pages = [ '!^(.+)?$!' => 'login' ];
+	$pages = array('!^(.+)?$!' => 'login');
 } elseif (isset($_GET['status'], $_GET['r'])) {
 	header('Location: ' . $_GET['r'], true, (int)$_GET['status']);
 	exit;
@@ -129,11 +126,10 @@ if (isset($config['mod']['custom_pages'])) {
 	$pages = array_merge($pages, $config['mod']['custom_pages']);
 }
 
-$new_pages = [];
+$new_pages = array();
 foreach ($pages as $key => $callback) {
-	if (is_string($callback) && preg_match('/^secure /', $callback)) {
+	if (is_string($callback) && preg_match('/^secure /', $callback))
 		$key .= '(/(?P<token>[a-f0-9]{8}))?';
-	}
 	$key = str_replace('\%b', '?P<board>' . sprintf(substr($config['board_path'], 0, -1), $config['board_regex']), $key);
 	$new_pages[(!empty($key) and $key[0] == '!') ? $key : '!^' . $key . '(?:&[^&=]+=[^&]*)*$!u'] = $callback;
 }
@@ -141,7 +137,7 @@ $pages = $new_pages;
 
 foreach ($pages as $uri => $handler) {
 	if (preg_match($uri, $query, $matches)) {
-		$matches[0] = $ctx; // Replace the text captured by the full pattern with a reference to the context.
+		$matches = array_slice($matches, 1);
 
 		if (isset($matches['board'])) {
 			$board_match = $matches['board'];
@@ -161,7 +157,7 @@ foreach ($pages as $uri => $handler) {
 					if ($secure_post_only)
 						error($config['error']['csrf']);
 					else {
-						mod_confirm($ctx, substr($query, 1));
+						mod_confirm(substr($query, 1));
 						exit;
 					}
 				}
@@ -176,20 +172,24 @@ foreach ($pages as $uri => $handler) {
 		}
 
 		if ($config['debug']) {
-			$debug['mod_page'] = [
+			$debug['mod_page'] = array(
 				'req' => $query,
 				'match' => $uri,
 				'handler' => $handler,
-			];
+			);
 			$debug['time']['parse_mod_req'] = '~' . round((microtime(true) - $parse_start_time) * 1000, 2) . 'ms';
 		}
 
-		// We don't want to call named parameters (PHP 8).
+		if (is_array($matches)) {
+			// we don't want to call named parameters (PHP 8)
 			$matches = array_values($matches);
+		}
 
 		if (is_string($handler)) {
 			if ($handler[0] == ':') {
 				header('Location: ' . substr($handler, 1),  true, $config['redirect_http']);
+			} elseif (is_callable("mod_page_$handler")) {
+				call_user_func_array("mod_page_$handler", $matches);
 			} elseif (is_callable("mod_$handler")) {
 				call_user_func_array("mod_$handler", $matches);
 			} else {
@@ -206,3 +206,4 @@ foreach ($pages as $uri => $handler) {
 }
 
 error($config['error']['404']);
+

post.php

@@ -6,7 +6,7 @@
 require_once 'inc/bootstrap.php';
 
 use Vichan\{Context, WebDependencyFactory};
-use Vichan\Data\Driver\{LogDriver, HttpDriver};
+use Vichan\Driver\{HttpDriver, Log};
 use Vichan\Service\{RemoteCaptchaQuery, NativeCaptchaQuery};
 use Vichan\Functions\Format;
 
@@ -167,47 +167,12 @@ function strip_image_metadata(string $img_path): int {
 	return $ret;
 }
 
-/**
- * Delete posts in a cyclical thread.
- *
- * @param string $boardUri The URI of the board.
- * @param int $threadId The ID of the thread.
- * @param int $cycleLimit The number of most recent posts to retain.
- */
-function delete_cyclical_posts(string $boardUri, int $threadId, int $cycleLimit): void
-{
-    $query = prepare(sprintf('
-        SELECT p.`id`
-        FROM ``posts_%s`` p
-        LEFT JOIN (
-            SELECT `id`
-            FROM ``posts_%s``
-            WHERE `thread` = :thread
-            ORDER BY `id` DESC
-            LIMIT :limit
-        ) recent_posts ON p.id = recent_posts.id
-        WHERE p.thread = :thread
-        AND recent_posts.id IS NULL',
-        $boardUri, $boardUri
-    ));
-
-    $query->bindValue(':thread', $threadId, PDO::PARAM_INT);
-    $query->bindValue(':limit', $cycleLimit, PDO::PARAM_INT);
-
-    $query->execute() or error(db_error($query));
-    $ids = $query->fetchAll(PDO::FETCH_COLUMN);
-
-    foreach ($ids as $id) {
-        deletePost($id, false);
-    }
-}
-
 /**
  * Method handling functions
  */
 
 $dropped_post = false;
-$context = Vichan\build_context($config);
+$context = new Context(new WebDependencyFactory($config));
 
 // Is it a post coming from NNTP? Let's extract it and pretend it's a normal post.
 if (isset($_GET['Newsgroups']) && $config['nntpchan']['enabled']) {
@@ -286,7 +251,7 @@ if (isset($_GET['Newsgroups']) && $config['nntpchan']['enabled']) {
 		$content = file_get_contents("php://input");
 	}
 	elseif ($ct == 'multipart/mixed' || $ct == 'multipart/form-data') {
-		$context->get(LogDriver::class)->log(LogDriver::DEBUG, 'MM: Files: ' . print_r($GLOBALS, true));
+		$context->getLog()->log(Log::DEBUG, 'MM: Files: ' . print_r($GLOBALS, true));
 
 		$content = '';
 
@@ -382,11 +347,10 @@ if (isset($_POST['delete'])) {
 	if (!isset($_POST['board'], $_POST['password']))
 		error($config['error']['bot']);
 
-	if (empty($_POST['password'])){
+	$password = &$_POST['password'];
-		error($config['error']['invalidpassword']);
-	}
 
-	$password = hashPassword($_POST['password']);
+	if ($password == '')
+		error($config['error']['invalidpassword']);
 
 	$delete = array();
 	foreach ($_POST as $post => $value) {
@@ -434,12 +398,10 @@ if (isset($_POST['delete'])) {
 				error(sprintf($config['error']['delete_too_late'], Format\until($post['time'] + $config['max_delete_time'])));
 			}
 
-			if (!hash_equals($post['password'], $password) && (!$thread || !hash_equals($thread['password'], $password))) {
+			if ($password != '' && $post['password'] != $password && (!$thread || $thread['password'] != $password))
 				error($config['error']['invalidpassword']);
-			}
 
-
+			if ($post['time'] > time() - $config['delete_time'] && (!$thread || $thread['password'] != $password)) {
-			if ($post['time'] > time() - $config['delete_time'] && (!$thread || !hash_equals($thread['password'], $password))) {
 				error(sprintf($config['error']['delete_too_soon'], Format\until($post['time'] + $config['delete_time'])));
 			}
 
@@ -454,8 +416,8 @@ if (isset($_POST['delete'])) {
 				modLog("User at $ip deleted their own post #$id");
 			}
 
-			$context->get(LogDriver::class)->log(
+			$context->getLog()->log(
-				LogDriver::INFO,
+				Log::INFO,
 				'Deleted post: /' . $board['dir'] . $config['dir']['res'] . link_for($post) . ($post['thread'] ? '#' . $id : '')
 			);
 		}
@@ -477,7 +439,7 @@ if (isset($_POST['delete'])) {
 	if (function_exists('fastcgi_finish_request'))
 		@fastcgi_finish_request();
 
-	Vichan\Functions\Theme\rebuild_themes('post-delete', $board['uri']);
+	rebuildThemes('post-delete', $board['uri']);
 
 } elseif (isset($_POST['report'])) {
 	if (!isset($_POST['board'], $_POST['reason']))
@@ -517,12 +479,12 @@ if (isset($_POST['delete'])) {
 
 		try {
 			$query = new NativeCaptchaQuery(
-				$context->get(HttpDriver::class),
+				$context->getHttpDriver(),
 				$config['domain'],
-				$config['captcha']['provider_check'],
+				$config['captcha']['provider_check']
-				$config['captcha']['extra']
 			);
 			$success = $query->verify(
+				$config['captcha']['extra'],
 				$_POST['captcha_text'],
 				$_POST['captcha_cookie']
 			);
@@ -531,7 +493,7 @@ if (isset($_POST['delete'])) {
 				error($config['error']['captcha']);
 			}
 		} catch (RuntimeException $e) {
-			$context->get(LogDriver::class)->log(LogDriver::ERROR, "Native captcha IO exception: {$e->getMessage()}");
+			$context->getLog()->log(Log::ERROR, "Native captcha IO exception: {$e->getMessage()}");
 			error($config['error']['local_io_error']);
 		}
 	}
@@ -550,7 +512,7 @@ if (isset($_POST['delete'])) {
 
 		$post = $query->fetch(PDO::FETCH_ASSOC);
 		if ($post === false) {
-			$context->get(LogDriver::class)->log(LogDriver::INFO, "Failed to report non-existing post #{$id} in {$board['dir']}");
+			$context->getLog()->log(Log::INFO, "Failed to report non-existing post #{$id} in {$board['dir']}");
 			error($config['error']['nopost']);
 		}
 
@@ -559,8 +521,8 @@ if (isset($_POST['delete'])) {
 			error($error);
 		}
 
-		$context->get(LogDriver::class)->log(
+		$context->getLog()->log(
-			LogDriver::INFO,
+			Log::INFO,
 			'Reported post: /'
 				 . $board['dir'] . $config['dir']['res'] . link_for($post) . ($post['thread'] ? '#' . $id : '')
 				 . " for \"$reason\""
@@ -629,15 +591,10 @@ if (isset($_POST['delete'])) {
 
 		// Check for CAPTCHA right after opening the board so the "return" link is in there.
 		try {
-			$provider = $config['captcha']['provider'];
-			$new_thread_capt = $config['captcha']['native']['new_thread_capt'];
-			$dynamic = $config['captcha']['dynamic'];
-
 			// With our custom captcha provider
-			if (($provider === 'native' && !$new_thread_capt)
+			if ($config['captcha']['enabled'] || ($post['op'] && $config['new_thread_capt'])) {
-				|| ($provider === 'native' && $new_thread_capt && $post['op'])) {
+				$query = new NativeCaptchaQuery($context->getHttpDriver(), $config['domain'], $config['captcha']['provider_check']);
-				$query = $context->get(NativeCaptchaQuery::class);
+				$success = $query->verify($config['captcha']['extra'], $_POST['captcha_text'], $_POST['captcha_cookie']);
-				$success = $query->verify($_POST['captcha_text'], $_POST['captcha_cookie']);
 
 				if (!$success) {
 					error(
@@ -653,30 +610,36 @@ if (isset($_POST['delete'])) {
 				}
 			}
 			// Remote 3rd party captchas.
-			elseif ($provider && (!$dynamic || $dynamic === $_SERVER['REMOTE_ADDR'])) {
+			else {
-				$query = $content->get(RemoteCaptchaQuery::class);
+				// recaptcha
-				$field = $query->responseField();
+				if ($config['recaptcha']) {
-
+					if (!isset($_POST['g-recaptcha-response'])) {
-				if (!isset($_POST[$field])) {
 						error($config['error']['bot']);
 					}
-				$response = $_POST[$field];
+					$response = $_POST['g-recaptcha-response'];
-				/*
+					$query = RemoteCaptchaQuery::withRecaptcha($context->getHttpDriver(), $config['recaptcha_private']);
-				 * Do not query with the IP if the mode is dynamic. This config is meant for proxies and internal
+				}
-				 * loopback addresses.
+				// hCaptcha
-				 */
+				elseif ($config['hcaptcha']) {
-				$ip = $dynamic ? null : $_SERVER['REMOTE_ADDR'];
+					if (!isset($_POST['h-captcha-response'])) {
+						error($config['error']['bot']);
+					}
+					$response = $_POST['h-captcha-response'];
+					$query = RemoteCaptchaQuery::withHCaptcha($context->getHttpDriver(), $config['hcaptcha_private']);
+				}
 
-				$success = $query->verify($response, $ip);
+				if (isset($query, $response)) {
+					$success = $query->verify($response, $_SERVER['REMOTE_ADDR']);
 					if (!$success) {
 						error($config['error']['captcha']);
 					}
 				}
+			}
 		} catch (RuntimeException $e) {
-			$context->get(LogDriver::class)->log(LogDriver::ERROR, "Captcha IO exception: {$e->getMessage()}");
+			$context->getLog()->log(Log::ERROR, "Captcha IO exception: {$e->getMessage()}");
 			error($config['error']['remote_io_error']);
 		} catch (JsonException $e) {
-			$context->get(LogDriver::class)->log(LogDriver::ERROR, "Bad JSON reply to captcha: {$e->getMessage()}");
+			$context->getLog()->log(Log::ERROR, "Bad JSON reply to captcha: {$e->getMessage()}");
 			error($config['error']['remote_io_error']);
 		}
 
@@ -694,7 +657,7 @@ if (isset($_POST['delete'])) {
 
 
 		if ($post['mod'] = isset($_POST['mod']) && $_POST['mod']) {
-			check_login($context, false);
+			check_login(false);
 			if (!$mod) {
 				// Liar. You're not a mod.
 				error($config['error']['notamod']);
@@ -712,6 +675,12 @@ if (isset($_POST['delete'])) {
 				error($config['error']['noaccess']);
 		}
 
+		if (!$post['mod']) {
+			$post['antispam_hash'] = checkSpam(array($board['uri'], isset($post['thread']) ? $post['thread'] : ($config['try_smarter'] && isset($_POST['page']) ? 0 - (int)$_POST['page'] : null)));
+			if ($post['antispam_hash'] === true)
+				error($config['error']['spam']);
+		}
+
 		if ($config['robot_enable'] && $config['robot_mute']) {
 			checkMute();
 		}
@@ -778,7 +747,7 @@ if (isset($_POST['delete'])) {
 
 		try {
 			$ret = download_file_from_url(
-				$context->get(HttpDriver::class),
+				$context->getHttpDriver(),
 				$_POST['file_url'],
 				$config['upload_by_url_timeout'],
 				$allowed_extensions,
@@ -801,7 +770,7 @@ if (isset($_POST['delete'])) {
 	$post['subject'] = $_POST['subject'];
 	$post['email'] = str_replace(' ', '%20', htmlspecialchars($_POST['email']));
 	$post['body'] = $_POST['body'];
-	$post['password'] = hashPassword($_POST['password']);
+	$post['password'] = $_POST['password'];
 	$post['has_file'] = (!isset($post['embed']) && (($post['op'] && !isset($post['no_longer_require_an_image_for_op']) && $config['force_image_op']) || count($_FILES) > 0));
 
 	if (!$dropped_post) {
@@ -881,7 +850,7 @@ if (isset($_POST['delete'])) {
 
 	$trip = generate_tripcode($post['name']);
 	$post['name'] = $trip[0];
-	if ($config['disable_tripcodes'] && !$mod) {
+	if ($config['disable_tripcodes'] = true && !$mod) {
 		$post['trip'] = '';
 	}
 	else {
@@ -959,6 +928,8 @@ if (isset($_POST['delete'])) {
 			error($config['error']['toolong_body']);
 		if (!$mod && substr_count($post['body'], "\n") >= $config['maximum_lines'])
 			error($config['error']['toomanylines']);
+		if (mb_strlen($post['password']) > 20)
+			error(sprintf($config['error']['toolong'], 'password'));
 	}
 	wordfilters($post['body']);
 
@@ -1085,6 +1056,9 @@ if (isset($_POST['delete'])) {
 				error($config['error']['maxsize']);
 			}
 
+			// If, on the basis of the file extension, the image file has metadata we can operate on.
+			$file_image_has_operable_metadata = $file['extension'] === 'jpg' || $file['extension'] === 'jpeg' || $file['extension'] === 'webp' || $file['extension'] == 'png';
+
 			$file['exif_stripped'] = false;
 
 			if ($file_image_has_operable_metadata && $config['convert_auto_orient']) {
@@ -1156,7 +1130,7 @@ if (isset($_POST['delete'])) {
 					try {
 						$file['size'] = strip_image_metadata($file['tmp_name']);
 					} catch (RuntimeException $e) {
-						$context->get(LogDriver::class)->log(LogDriver::ERROR, "Could not strip image metadata: {$e->getMessage()}");
+						$context->getLog()->log(Log::ERROR, "Could not strip image metadata: {$e->getMessage()}");
 						// Since EXIF metadata can countain sensible info, fail the request.
 						error(_('Could not strip EXIF metadata!'), null, $error);
 					}
@@ -1191,10 +1165,10 @@ if (isset($_POST['delete'])) {
 					if ($txt !== '') {
 						// This one has an effect, that the body is appended to a post body. So you can write a correct
 						// spamfilter.
-						$post['body_nomarkup'] .= "<tinyboard ocr image $key>" . htmlspecialchars($txt) . "</tinyboard>";
+						$post['body_nomarkup'] .= "<tinyboard ocr image $key>" . htmlspecialchars($value) . "</tinyboard>";
 					}
 				} catch (RuntimeException $e) {
-					$context->get(LogDriver::class)->log(LogDriver::ERROR, "Could not OCR image: {$e->getMessage()}");
+					$context->getLog()->log(Log::ERROR, "Could not OCR image: {$e->getMessage()}");
 				}
 			}
 		}
@@ -1320,7 +1294,11 @@ if (isset($_POST['delete'])) {
 
 	// Handle cyclical threads
 	if (!$post['op'] && isset($thread['cycle']) && $thread['cycle']) {
-		delete_cyclical_posts($board['uri'], $post['thread'], $config['cycle_limit']);
+		// Query is a bit weird due to "This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'" (MariaDB Ver 15.1 Distrib 10.0.17-MariaDB, for Linux (x86_64))
+		$query = prepare(sprintf('DELETE FROM ``posts_%s`` WHERE `thread` = :thread AND `id` NOT IN (SELECT `id` FROM (SELECT `id` FROM ``posts_%s`` WHERE `thread` = :thread ORDER BY `id` DESC LIMIT :limit) i)', $board['uri'], $board['uri']));
+		$query->bindValue(':thread', $post['thread']);
+		$query->bindValue(':limit', $config['cycle_limit'], PDO::PARAM_INT);
+		$query->execute() or error(db_error($query));
 	}
 
 	if (isset($post['antispam_hash'])) {
@@ -1388,8 +1366,8 @@ if (isset($_POST['delete'])) {
 
 	buildThread($post['op'] ? $id : $post['thread']);
 
-	$context->get(LogDriver::class)->log(
+	$context->getLog()->log(
-		LogDriver::INFO,
+		Log::INFO,
 		'New post: /' . $board['dir'] . $config['dir']['res'] . link_for($post) . (!$post['op'] ? '#' . $id : '')
 	);
 
@@ -1422,9 +1400,9 @@ if (isset($_POST['delete'])) {
 		@fastcgi_finish_request();
 
 	if ($post['op'])
-		Vichan\Functions\Theme\rebuild_themes('post-thread', $board['uri']);
+		rebuildThemes('post-thread', $board['uri']);
 	else
-		Vichan\Functions\Theme\rebuild_themes('post', $board['uri']);
+		rebuildThemes('post', $board['uri']);
 
 } elseif (isset($_POST['appeal'])) {
 	if (!isset($_POST['ban_id']))
@@ -1432,7 +1410,7 @@ if (isset($_POST['delete'])) {
 
 	$ban_id = (int)$_POST['ban_id'];
 
-	$ban = Bans::findSingle($_SERVER['REMOTE_ADDR'], $ban_id, $config['require_ban_view'], $config['auto_maintenance']);
+	$ban = Bans::findSingle($_SERVER['REMOTE_ADDR'], $ban_id, $config['require_ban_view']);
 
 	if (empty($ban)) {
 		error($config['error']['noban']);

stylesheets/style.css

@@ -917,6 +917,10 @@ pre {
 .poster_id {
   cursor: pointer;
   display: inline-block;
+  -webkit-user-select: none;
+  -moz-user-select: none;
+  -ms-user-select: none;
+  -o-user-select: none;
   user-select: none;
 }
 .poster_id:hover {
@@ -1042,20 +1046,6 @@ div.boardlist a {
   cursor: pointer;
 }
 
-/* Inline dice */
-.dice-option table {
-    border: 1px dotted black;
-    margin: 0;
-    border-collapse: collapse;
-}
-.dice-option table td {
-    text-align: center;
-    border-left: 1px dotted black;
-    padding-left: 2px;
-    padding-right: 2px;
-    padding-bottom: 2px;
-}
-
 #youtube-size input {
   width: 50px;
 }
@@ -1206,6 +1196,7 @@ table.fileboard .intro a {
 
 #gallery_images img {
   opacity: 0.6;
+  -webkit-transition: all 0.5s;
           transition: all 0.5s;
 }
 
@@ -1214,6 +1205,8 @@ table.fileboard .intro a {
 }
 
 #gallery_images img.active {
+  -webkit-box-shadow: 0px 0px 29px 2px rgba(255,255,255,1);
+     -moz-box-shadow: 0px 0px 29px 2px rgba(255,255,255,1);
           box-shadow: 0px 0px 29px 2px rgba(255,255,255,1);
   z-index: 1;
 }
@@ -1234,35 +1227,12 @@ div.mix {
 	display: inline-block;
 }
 
-.ban-reason-table {
+.ban-reason-table .warning-reason-table tr td:first-child {
-  margin: 10px auto;
+  text-align: right;
-  border-collapse: collapse;
+  padding-right: 10px;
-  width: auto;
-  font-size: 10pt;
 }
 
-.ban-reason-table th,
+.ban-reason-table .warning-reason-table tr:hover td {
-.ban-reason-table td {
-  border: 1px solid #98E;
-  padding: 4px 8px;
-  text-align: left;
-}
-
-.ban-reason-table th {
-  background-color: #98E;
-  color: black;
-  font-weight: bold;
-}
-
-.ban-reason-table tr:nth-child(even) td {
-  background-color: #EEF2FF;
-}
-
-.ban-reason-table tr:nth-child(odd) td {
-  background-color: #FFFFFF;
-}
-
-.ban-reason-table tr:hover td {
-  background-color: #D6DAF0;
   cursor: pointer;
+  background-color: rgba(100%,100%,100%,0.2);
 }

stylesheets/uboachan-gray.css

@@ -1,121 +0,0 @@
-body {
-	background: #1C1C1C;
-	color: #AAA;
-}
-a:link, a:visited, p.intro a.email span.name {
-	color: #8080E0;
-}
-a:hover, a:link:hover, a:visited:hover {
-	color: #f33;
-}
-a.post_no {
-	color: 999;
-}
-div.post.reply {
-	background: #383838;
-	border: 1px solid #000000;
-	transition: 0.3s;
-}
-div.post.reply.highlighted {
-	/*background: #202020;*/
-	border: 1px solid #000000;
-	border-left: 1px solid #D03030;
-	background: #282828;
-	/*border: none;*/
-	transition: 0.3s;
-}
-/*Changed this*/
-div.post.reply div.body a {
-	color: #8080E0;
-}
-p.intro span.subject {
-	color: #8080E0;
-}
-p.intro span.capcode, p.intro a.capcode, p.intro a.nametag {
-        color: #F33;
-        margin-left: 0;
-}
-form table tr th {
-	background: #383838;
-	color: #CCC;
-}
-div.ban h2 {
-	background: #504040;
-	color: inherit;
-}
-div.ban {
-	border-color: #cccccc;
-	background: #404040;
-}
-div.ban p {
-	color: black;
-}
-div.pages {
-	background: #404040;
-	border-color: #000000;
-}
-div.pages a.selected {
-	color: #101010;
-}
-hr {
-	border-color: gray;
-}
-div.boardlist {
-	color: #a0a0a0;
-}
-div.boardlist a {
-	color: #a9a9a9;
-}
-div.report {
-	color: gray;
-}
-table.modlog tr th {
-	background: #555;
-}
-input, input[type="text"], input[type="password"], textarea {
-	color: #AAA;
-	background: #111;
-	border: 1px solid #000;
-}
-div.banner {
-	background-color: #833;
-}
-div.banner, div.banner a {
-	color: #000000;
-}
-div.title, h1 {
-	color: #B03030;
-}
-h2 {
-	color: #B03030;
-}
-div.blotter {
-	color: #D33;
-}
-.category {
-	background: #603030;
-	color: #141414;
-	border-color: #a9a9a9;
-}
-#maintable {
-	background: #404040;
-}
-#announcement {
-	background: #404040;
-	color: #D04040;
-}
-.post_wrap {
-	background: #404040;
-}
-.post_body {
-	background: #303030;
-}
-header div.subtitle {
-	color: #B03030;
-}
-span.heading {
-	color: #D03030;
-}
-#options_div {
-    background-color: #404040;
-}

templates/footer.html

@@ -2,6 +2,6 @@
     <p class="unimportant" style="margin-top:20px;text-align:center;">- Tinyboard + 
         <a href="https://github.com/vichan-devel/vichan">vichan</a> {{ config.version }} -
     <br>Tinyboard Copyright &copy; 2010-2014 Tinyboard Development Group    
-    <br><a href="https://github.com/vichan-devel/vichan">vichan</a> Copyright &copy; 2012-2025 vichan-devel</p>
+    <br><a href="https://github.com/vichan-devel/vichan">vichan</a> Copyright &copy; 2012-2024 vichan-devel</p>
     {% for footer in config.footer %}<p class="unimportant" style="text-align:center;">{{ footer }}</p>{% endfor %}
 </footer>

templates/header.html

@@ -1,26 +1,26 @@
-<link rel="stylesheet" media="screen" href="{{ config.url_stylesheet }}?v={{ config.resource_version }}">
+ <link rel="stylesheet" media="screen" href="{{ config.url_stylesheet }}">
                 {% if config.url_favicon %}<link rel="shortcut icon" href="{{ config.url_favicon }}">{% endif %}
                 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
                 <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes">
                 {% if config.meta_keywords %}<meta name="keywords" content="{{ config.meta_keywords }}">{% endif %}
-{% if config.default_stylesheet.1 != '' %}<link rel="stylesheet" type="text/css" id="stylesheet" href="{{ config.uri_stylesheets }}{{ config.default_stylesheet.1 }}?v={{ config.resource_version }}">{% endif %}
+                {% if config.default_stylesheet.1 != '' %}<link rel="stylesheet" type="text/css" id="stylesheet" href="{{ config.uri_stylesheets }}{{ config.default_stylesheet.1 }}">{% endif %}
-{% if config.font_awesome %}<link rel="stylesheet" href="{{ config.root }}{{ config.font_awesome_css }}?v={{ config.resource_version }}">{% endif %}
+                {% if config.font_awesome %}<link rel="stylesheet" href="{{ config.root }}{{ config.font_awesome_css }}">{% endif %}
-{% if config.country_flags_condensed %}<link rel="stylesheet" href="{{ config.root }}{{ config.country_flags_condensed_css }}?v={{ config.resource_version }}">{% endif %}
+                {% if config.country_flags_condensed %}<link rel="stylesheet" href="{{ config.root }}{{ config.country_flags_condensed_css }}">{% endif %}
                 <script type="text/javascript">
                         var configRoot="{{ config.root }}";
                         var inMod = {% if mod %}true{% else %}false{% endif %};
                         var modRoot="{{ config.root }}"+(inMod ? "mod.php?/" : "");
                 </script>
                 {% if not nojavascript %}
-	<script type="text/javascript" src="{{ config.url_javascript }}?v={{ config.resource_version }} data-resource-version="{{ config.resource_version }}"></script>
+                        <script type="text/javascript" src="{{ config.url_javascript }}"></script>
                         {% if not config.additional_javascript_compile %}
-	{% for javascript in config.additional_javascript %}<script type="text/javascript" src="{{ config.additional_javascript_url }}{{ javascript }}?v={{ config.resource_version }}"></script>{% endfor %}
+                        {% for javascript in config.additional_javascript %}<script type="text/javascript" src="{{ config.additional_javascript_url }}{{ javascript }}"></script>{% endfor %}
                         {% endif %}
                         {% if mod %}
-	<script type="text/javascript" src="/js/mod/mod_snippets.js?v={{ config.resource_version }}"></script>
+                        <script type="text/javascript" src="/js/mod/mod_snippets.js"></script>
                         {% endif %}
                 {% endif %}
-{% if config.captcha.provider == 'recaptcha' %}<script src="//www.recaptcha.net/recaptcha/api.js"></script>
+                {% if config.recaptcha %}<script src="//www.recaptcha.net/recaptcha/api.js"></script>
                 <style type="text/css">{% verbatim %}
                         #recaptcha_area {
                                 float: none !important;
@@ -50,6 +50,6 @@
                                 padding: 0 !important;
                         }
                 {% endverbatim %}</style>{% endif %}
-{% if config.captcha.provider.hcaptcha %}
+                {% if config.hcaptcha %}
                 <script src="https://js.hcaptcha.com/1/api.js" async defer></script>
                 {% endif %}

templates/installer/config.html

@@ -88,9 +88,6 @@
 		<label for="secure_trip_salt">Secure trip (##) salt:</label> 
 		<input type="text" id="secure_trip_salt" name="secure_trip_salt" value="{{ config.secure_trip_salt }}" size="40">
 
-		<label for="secure_password_salt">Poster password salt:</label>
-		<input type="text" id="secure_password_salt" name="secure_password_salt" value="{{ config.secure_password_salt }}" size="40">
-
 		<label for="more">Additional configuration:</label>
 		<textarea id="more" name="more">{{ more }}</textarea>
 	</fieldset>

templates/main.js

@@ -22,39 +22,39 @@ function fmt(s, a) {
 	return s.replace(/\{([0-9]+)\}/g, function(x) { return a[x[1]]; });
 }
 
-function until(timestamp) {
+function until($timestamp) {
-	let difference = timestamp - Date.now() / 1000 | 0;
+        var $difference = $timestamp - Date.now()/1000|0, $num;
         switch(true){
-	case (difference < 60):
+        case ($difference < 60):
-		return "" + difference + ' ' + _('second(s)');
+                return "" + $difference + ' ' + _('second(s)');
-	case (difference < 3600): // 60 * 60 = 3600
+        case ($difference < 3600): //60*60 = 3600
-		return "" + Math.round(difference / 60) + ' ' + _('minute(s)');
+                return "" + ($num = Math.round($difference/(60))) + ' ' + _('minute(s)');
-	case (difference < 86400): // 60 * 60 * 24 = 86400
+        case ($difference < 86400): //60*60*24 = 86400
-		return "" + Math.round(difference / 3600) + ' ' + _('hour(s)');
+                return "" + ($num = Math.round($difference/(3600))) + ' ' + _('hour(s)');
-	case (difference < 604800): // 60 * 60 * 24 * 7 = 604800
+        case ($difference < 604800): //60*60*24*7 = 604800
-		return "" + Math.round(difference / 86400) + ' ' + _('day(s)');
+                return "" + ($num = Math.round($difference/(86400))) + ' ' + _('day(s)');
-	case (difference < 31536000): // 60 * 60 * 24 * 365 = 31536000
+        case ($difference < 31536000): //60*60*24*365 = 31536000
-		return "" + Math.round(difference / 604800) + ' ' + _('week(s)');
+                return "" + ($num = Math.round($difference/(604800))) + ' ' + _('week(s)');
         default:
-		return "" + Math.round(difference / 31536000) + ' ' + _('year(s)');
+                return "" + ($num = Math.round($difference/(31536000))) + ' ' + _('year(s)');
         }
 }
 
-function ago(timestamp) {
+function ago($timestamp) {
-	let difference = (Date.now() / 1000 | 0) - timestamp;
+        var $difference = (Date.now()/1000|0) - $timestamp, $num;
         switch(true){
-	case (difference < 60):
+        case ($difference < 60) :
-		return "" + difference + ' ' + _('second(s)');
+                return "" + $difference + ' ' + _('second(s)');
-	case (difference < 3600): /// 60 * 60 = 3600
+        case ($difference < 3600): //60*60 = 3600 
-		return "" + Math.round(difference/(60)) + ' ' + _('minute(s)');
+                return "" + ($num = Math.round($difference/(60))) + ' ' + _('minute(s)');
-	case (difference < 86400): // 60 * 60 * 24 = 86400
+        case ($difference <  86400): //60*60*24 = 86400
-		return "" + Math.round(difference/(3600)) + ' ' + _('hour(s)');
+                return "" + ($num = Math.round($difference/(3600))) + ' ' + _('hour(s)');
-	case (difference < 604800): // 60 * 60 * 24 * 7 = 604800
+        case ($difference < 604800): //60*60*24*7 = 604800
-		return "" + Math.round(difference/(86400)) + ' ' + _('day(s)');
+                return "" + ($num = Math.round($difference/(86400))) + ' ' + _('day(s)');
-	case (difference < 31536000): // 60 * 60 * 24 * 365 = 31536000
+        case ($difference < 31536000): //60*60*24*365 = 31536000
-		return "" + Math.round(difference/(604800)) + ' ' + _('week(s)');
+                return "" + ($num = Math.round($difference/(604800))) + ' ' + _('week(s)');
         default:
-		return "" + Math.round(difference/(31536000)) + ' ' + _('year(s)');
+                return "" + ($num = Math.round($difference/(31536000))) + ' ' + _('year(s)');
         }
 }
 
@@ -71,8 +71,8 @@ var datelocale =
 
 
 function alert(a, do_confirm, confirm_ok_action, confirm_cancel_action) {
-	let handler, div, bg, closebtn, okbtn;
+      var handler, div, bg, closebtn, okbtn;
-	let close = function() {
+      var close = function() {
               handler.fadeOut(400, function() { handler.remove(); });
               return false;
       };
@@ -133,46 +133,20 @@ function changeStyle(styleName, link) {
 	{% verbatim %}
 	
 	if (!document.getElementById('stylesheet')) {
-		let s = document.createElement('link');
+		var s = document.createElement('link');
 		s.rel = 'stylesheet';
 		s.type = 'text/css';
 		s.id = 'stylesheet';
-		let x = document.getElementsByTagName('head')[0];
+		var x = document.getElementsByTagName('head')[0];
 		x.appendChild(s);
 	}
 	
-	let mainStylesheetElement = document.getElementById('stylesheet');
+	document.getElementById('stylesheet').href = styles[styleName];
-	let userStylesheetElement = document.getElementById('stylesheet-user');
-
-	// Override main stylesheet with the user selected one.
-	if (!userStylesheetElement) {
-		userStylesheetElement = document.createElement('link');
-		userStylesheetElement.rel = 'stylesheet';
-		userStylesheetElement.media = 'none';
-		userStylesheetElement.type = 'text/css';
-		userStylesheetElement.id = 'stylesheet';
-		let x = document.getElementsByTagName('head')[0];
-		x.appendChild(userStylesheetElement);
-	}
-
-	// When the new one is loaded, disable the old one
-	userStylesheetElement.onload = function() {
-		this.media = 'all';
-		mainStylesheetElement.media = 'none';
-	}
-
-	let style = styles[styleName];
-	if (style !== '') {
-		// Add the version of the resource if the style is not the embedded one.
-		style += `?v=${resourceVersion}`;
-	}
-
-	document.getElementById('stylesheet').href = style;
 	selectedstyle = styleName;
 	
 	if (document.getElementsByClassName('styles').length != 0) {
-		let styleLinks = document.getElementsByClassName('styles')[0].childNodes;
+		var styleLinks = document.getElementsByClassName('styles')[0].childNodes;
-		for (let i = 0; i < styleLinks.length; i++) {
+		for (var i = 0; i < styleLinks.length; i++) {
 			styleLinks[i].className = '';
 		}
 	}
@@ -181,14 +155,12 @@ function changeStyle(styleName, link) {
 		link.className = 'selected';
 	}
 	
-	if (typeof $ != 'undefined') {
+	if (typeof $ != 'undefined')
 		$(window).trigger('stylesheet', styleName);
 }
-}
 
 
 {% endverbatim %}
-var resourceVersion = document.currentScript.getAttribute('data-resource-version');
 {% if config.stylesheets_board %}
 	{% verbatim %}
 	
@@ -198,7 +170,7 @@ var resourceVersion = document.currentScript.getAttribute('data-resource-version
 	
 	var stylesheet_choices = JSON.parse(localStorage.board_stylesheets);
 	if (board_name && stylesheet_choices[board_name]) {
-		for (let styleName in styles) {
+		for (var styleName in styles) {
 			if (styleName == stylesheet_choices[board_name]) {
 				changeStyle(styleName);
 				break;
@@ -209,7 +181,7 @@ var resourceVersion = document.currentScript.getAttribute('data-resource-version
 {% else %}
 	{% verbatim %}
 	if (localStorage.stylesheet) {
-		for (let styleName in styles) {
+		for (var styleName in styles) {
 			if (styleName == localStorage.stylesheet) {
 				changeStyle(styleName);
 				break;
@@ -220,12 +192,12 @@ var resourceVersion = document.currentScript.getAttribute('data-resource-version
 {% endif %}
 {% verbatim %}
 
-function initStyleChooser() {
+function init_stylechooser() {
-	let newElement = document.createElement('div');
+	var newElement = document.createElement('div');
 	newElement.className = 'styles';
 	
 	for (styleName in styles) {
-		let style = document.createElement('a');
+		var style = document.createElement('a');
 		style.innerHTML = '[' + styleName + ']';
 		style.onclick = function() {
 			changeStyle(this.innerHTML.substring(1, this.innerHTML.length - 1), this);
@@ -240,44 +212,13 @@ function initStyleChooser() {
 	document.getElementsByTagName('body')[0].insertBefore(newElement, document.getElementsByTagName('body')[0].lastChild.nextSibling);
 }
 
-function getCookie(cookie_name) {
+function get_cookie(cookie_name) {
-	let results = document.cookie.match('(^|;) ?' + cookie_name + '=([^;]*)(;|$)');
+	var results = document.cookie.match ( '(^|;) ?' + cookie_name + '=([^;]*)(;|$)');
-	if (results) {
+	if (results)
-		return unescape(results[2]);
+		return (unescape(results[2]));
-	} else {
+	else
 		return null;
 }
-}
-
-{% endverbatim %}
-{% if config.captcha.dynamic %}
-function is_dynamic_captcha_enabled() {
-	let cookie = get_cookie('require-captcha');
-	return cookie === '1';
-}
-
-function get_captcha_pub_key() {
-{% if config.captcha.provider == 'recaptcha' %}
-	return "{{ config.captcha.recaptcha.sitekey }}";
-{% else %}
-	return null;
-{% endif %}
-}
-
-function init_dynamic_captcha() {
-	if (!is_dynamic_captcha_enabled()) {
-		let pub_key = get_captcha_pub_key();
-		if (!pub_key) {
-			console.error("Missing public captcha key!");
-			return;
-		}
-
-		let captcha_hook = document.getElementById('captcha');
-		captcha_hook.style = "";
-	}
-}
-{% endif %}
-{% verbatim %}
 
 function highlightReply(id) {
 	if (typeof window.event != "undefined" && event.which == 2) {
@@ -285,33 +226,32 @@ function highlightReply(id) {
 		return true;
 	}
 	
-	let divs = document.getElementsByTagName('div');
+	var divs = document.getElementsByTagName('div');
-	for (let i = 0; i < divs.length; i++) {
+	for (var i = 0; i < divs.length; i++)
-		if (divs[i].className.indexOf('post') != -1) {
+	{
+		if (divs[i].className.indexOf('post') != -1)
 			divs[i].className = divs[i].className.replace(/highlighted/, '');
 	}
-	}
 	if (id) {
-		let post = document.getElementById('reply_' + id);
+		var post = document.getElementById('reply_'+id);
-		if (post) {
+		if (post)
 			post.className += ' highlighted';
-		}
 			window.location.hash = id;
 	}
 	return true;
 }
 
 function generatePassword() {
-	let pass = '';
+	var pass = '';
-	let chars = '{% endverbatim %}{{ config.genpassword_chars }}{% verbatim %}';
+	var chars = '{% endverbatim %}{{ config.genpassword_chars }}{% verbatim %}';
-	for (let i = 0; i < 8; i++) {
+	for (var i = 0; i < 8; i++) {
-		let rnd = Math.floor(Math.random() * chars.length);
+		var rnd = Math.floor(Math.random() * chars.length);
 		pass += chars.substring(rnd, rnd + 1);
 	}
 	return pass;
 }
 
-function doPost(form) {
+function dopost(form) {
 	if (form.elements['name']) {
 		localStorage.name = form.elements['name'].value.replace(/( |^)## .+$/, '');
 	}
@@ -329,14 +269,18 @@ function doPost(form) {
 }
 
 function citeReply(id, with_link) {
-	let textarea = document.getElementById('body');
+	var textarea = document.getElementById('body');
-	if (!textarea) {
-		return false;
-	}
 
-	if (textarea.selectionStart || textarea.selectionStart == '0') {
+	if (!textarea) return false;
-		let start = textarea.selectionStart;
+	
-		let end = textarea.selectionEnd;
+	if (document.selection) {
+		// IE
+		textarea.focus();
+		var sel = document.selection.createRange();
+		sel.text = '>>' + id + '\n';
+	} else if (textarea.selectionStart || textarea.selectionStart == '0') {
+		var start = textarea.selectionStart;
+		var end = textarea.selectionEnd;
 		textarea.value = textarea.value.substring(0, start) + '>>' + id + '\n' + textarea.value.substring(end, textarea.value.length);
 		
 		textarea.selectionStart += ('>>' + id).length + 1;
@@ -346,10 +290,10 @@ function citeReply(id, with_link) {
 		textarea.value += '>>' + id + '\n';
 	}
 	if (typeof $ != 'undefined') {
-		let select = document.getSelection().toString();
+		var select = document.getSelection().toString();
 		if (select) {
-			let body = $('#reply_' + id + ', #op_' + id).find('div.body');  // TODO: support for OPs
+			var body = $('#reply_' + id + ', #op_' + id).find('div.body');  // TODO: support for OPs
-			let index = body.text().indexOf(select.replace('\n', ''));  // for some reason this only works like this
+			var index = body.text().indexOf(select.replace('\n', ''));  // for some reason this only works like this
 			if (index > -1) {
 				textarea.value += '>' + select + '\n';
 			}
@@ -364,29 +308,25 @@ function citeReply(id, with_link) {
 function rememberStuff() {
 	if (document.forms.post) {
 		if (document.forms.post.password) {
-			if (!localStorage.password) {
+			if (!localStorage.password)
 				localStorage.password = generatePassword();
-			}
 			document.forms.post.password.value = localStorage.password;
 		}
 		
-		if (localStorage.name && document.forms.post.elements['name']) {
+		if (localStorage.name && document.forms.post.elements['name'])
 			document.forms.post.elements['name'].value = localStorage.name;
-		}
+		if (localStorage.email && document.forms.post.elements['email'])
-		if (localStorage.email && document.forms.post.elements['email']) {
 			document.forms.post.elements['email'].value = localStorage.email;
-		}
 		
-		if (window.location.hash.indexOf('q') == 1) {
+		if (window.location.hash.indexOf('q') == 1)
 			citeReply(window.location.hash.substring(2), true);
-		}
 		
 		if (sessionStorage.body) {
-			let saved = JSON.parse(sessionStorage.body);
+			var saved = JSON.parse(sessionStorage.body);
-			if (getCookie('{% endverbatim %}{{ config.cookies.js }}{% verbatim %}')) {
+			if (get_cookie('{% endverbatim %}{{ config.cookies.js }}{% verbatim %}')) {
 				// Remove successful posts
-				let successful = JSON.parse(getCookie('{% endverbatim %}{{ config.cookies.js }}{% verbatim %}'));
+				var successful = JSON.parse(get_cookie('{% endverbatim %}{{ config.cookies.js }}{% verbatim %}'));
-				for (let url in successful) {
+				for (var url in successful) {
 					saved[url] = null;
 				}
 				sessionStorage.body = JSON.stringify(saved);
@@ -410,15 +350,14 @@ var script_settings = function(script_name) {
 	this.get = function(var_name, default_val) {
 		if (typeof tb_settings == 'undefined' ||
 			typeof tb_settings[this.script_name] == 'undefined' ||
-			typeof tb_settings[this.script_name][var_name] == 'undefined') {
+			typeof tb_settings[this.script_name][var_name] == 'undefined')
 			return default_val;
-		}
 		return tb_settings[this.script_name][var_name];
 	}
 };
 
 function init() {
-	initStyleChooser();
+	init_stylechooser();
 
 	{% endverbatim %}	
 	{% if config.allow_delete %}
@@ -437,12 +376,12 @@ var RecaptchaOptions = {
 };
 
 onready_callbacks = [];
-function onReady(fnc) {
+function onready(fnc) {
 	onready_callbacks.push(fnc);
 }
 
 function ready() {
-	for (let i = 0; i < onready_callbacks.length; i++) {
+	for (var i = 0; i < onready_callbacks.length; i++) {
 		onready_callbacks[i]();
 	}
 }
@@ -452,11 +391,11 @@ function ready() {
 var post_date = "{{ config.post_date }}";
 var max_images = {{ config.max_images }};
 
-onReady(init);
+onready(init);
 
 {% if config.google_analytics %}{% verbatim %}
 
-var _gaq = _gaq || [];_gaq.push(['_setAccount', '{% endverbatim %}{{ config.google_analytics }}{% verbatim %}']);{% endverbatim %}{% if config.google_analytics_domain %}{% verbatim %}_gaq.push(['_setDomainName', '{% endverbatim %}{{ config.google_analytics_domain }}{% verbatim %}']){% endverbatim %}{% endif %}{% if not config.google_analytics_domain %}{% verbatim %}_gaq.push(['_setDomainName', 'none']){% endverbatim %}{% endif %}{% verbatim %};_gaq.push(['_trackPageview']);(function() {var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;ga.src = ('https:' == document.location.protocol ? 'https://' : 'http://') + 'stats.g.doubleclick.net/dc.js';let s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);})();{% endverbatim %}{% endif %}
+var _gaq = _gaq || [];_gaq.push(['_setAccount', '{% endverbatim %}{{ config.google_analytics }}{% verbatim %}']);{% endverbatim %}{% if config.google_analytics_domain %}{% verbatim %}_gaq.push(['_setDomainName', '{% endverbatim %}{{ config.google_analytics_domain }}{% verbatim %}']){% endverbatim %}{% endif %}{% if not config.google_analytics_domain %}{% verbatim %}_gaq.push(['_setDomainName', 'none']){% endverbatim %}{% endif %}{% verbatim %};_gaq.push(['_trackPageview']);(function() {var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;ga.src = ('https:' == document.location.protocol ? 'https://' : 'http://') + 'stats.g.doubleclick.net/dc.js';var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);})();{% endverbatim %}{% endif %}
 
 {% if config.statcounter_project and config.statcounter_security %}
 var sc = document.createElement('script');
@@ -465,3 +404,4 @@ sc.innerHTML = 'var sc_project={{ config.statcounter_project }};var sc_invisible
 var s = document.getElementsByTagName('script')[0];
 s.parentNode.insertBefore(sc, s);
 {% endif %}
+

templates/mod/ban_history.html

@@ -11,7 +11,7 @@
 	</tr>
 	<tr>
 		<th>{% trans 'IP' %}</th>
-		<td><a class="ip-link" style="margin:0;" href="?/IP/{{ ban.mask|cloak_mask }}">{{ ban.mask|cloak_mask }}</a></td>
+		<td>{{ ban.cmask }}</td>
 	</tr>
 	<tr>
 		<th>{% trans 'Reason' %}</th>

templates/mod/ban_list.html

@@ -1,11 +1,11 @@
-<script src='main.js?v={{ config.resource_version }}' data-resource-version="{{ config.resource_version }}"></script>
+<script src='main.js'></script>
-<script src='js/jquery.min.js?v={{ config.resource_version }}'></script>
+<script src='js/jquery.min.js'></script>
-<script src='js/mobile-style.js?v={{ config.resource_version }}'></script>
+<script src='js/mobile-style.js'></script>
-<script src='js/strftime.min.js?v={{ config.resource_version }}'></script>
+<script src='js/strftime.min.js'></script>
-<script src='js/longtable/longtable.js?v={{ config.resource_version }}'></script>
+<script src='js/longtable/longtable.js'></script>
-<script src='js/mod/ban-list.js?v={{ config.resource_version }}'></script>
+<script src='js/mod/ban-list.js'></script>
-<link rel='stylesheet' href='stylesheets/longtable/longtable.css?v={{ config.resource_version }}'>
+<link rel='stylesheet' href='stylesheets/longtable/longtable.css'>
-<link rel='stylesheet' href='stylesheets/mod/ban-list.css?v={{ config.resource_version }}'>
+<link rel='stylesheet' href='stylesheets/mod/ban-list.css'>
 
 	<form action="?/bans" method="post" class="banform">
 		{% if token %}
@@ -21,7 +21,7 @@
 			<div class='buttons'>
 				<input type="text" id="search" placeholder="{% trans %}Search{% endtrans %}">
 				{% if mod %}
-				<input type="submit" name="unban" id="unban" value="{% trans 'Unban selected' %}">
+				<input type="submit" name="unban" id="unban" onclick="return confirm('Are you sure you want to unban the selected IPs?');" value="{% trans 'Unban selected' %}">
 				{% endif %}
 			</div>
 

templates/mod/dashboard.html

@@ -166,7 +166,7 @@
 			<li>
 				A newer version of vichan
 				(<strong>v{{ newer_release.massive }}.{{ newer_release.major }}.{{ newer_release.minor }}</strong>) is available!
-				See <a href="https://vichan.info">https://vichan.info/</a> for upgrade instructions.
+				See <a href="https://engine.vichan.net">https://engine.vichan.net/</a> for upgrade instructions.
 			</li>
 		</ul>
 	</fieldset>

templates/mod/edit_page.html

@@ -5,7 +5,7 @@
 		<tr>
 		<th>{% trans %}Markup method{% endtrans %}
 			{% set allowed_html = config.allowed_html %}
-			{% trans %}<p class="unimportant">"markdown" is provided by <a href="http://parsedown.org/">parsedown</a></p>
+			{% trans %}<p class="unimportant">"markdown" is provided by <a href="http://parsedown.org/">parsedown</a>. Note: images disabled.</p>
 			<p class="unimportant">"html" allows the following tags:<br/>{{ allowed_html }}</p>
 			<p class="unimportant">"infinity" is the same as what is used in posts.</p>
 			<p class="unimportant">This page will not convert between formats,<br/>choose it once or do the conversion yourself!</p>{% endtrans %}

templates/mod/login.html

@@ -7,7 +7,7 @@
 			{% trans 'Username' %}
 		</th>
 		<td>
-			<input type="text" name="username" size="20" maxlength="30" value="{{ username|e }}" autofocus>
+			<input type="text" name="username" size="20" maxlength="30" value="{{ username|e }}">
 		</td>
 	</tr>
 	<tr>

templates/mod/pages.html

@@ -1,4 +1,4 @@
-<script type="text/javascript" src="js/jquery.min.js?v={{ config.resource_version }}"></script>
+<script type="text/javascript" src="js/jquery.min.js"></script>
 <div style="text-align:center">
 <p class="unimportant">
 {% if board %}

templates/mod/recent_posts.html

@@ -1,4 +1,4 @@
-<script src="{{ config.additional_javascript_url }}js/mod/recent-posts.js?v={{ config.resource_version }}"></script>
+<script src="{{ config.additional_javascript_url }}js/mod/recent-posts.js"></script>
 {% if not posts|length %}
 	<p style="text-align:center" class="unimportant">({% trans 'There are no active posts.' %})</p>
 {% else %}

templates/mod/view_ip.html

@@ -103,7 +103,7 @@
 	<fieldset>
 		<legend>{% trans 'New ban' %}</legend>
 		{% set redirect = '?/IP/' ~ ip|cloak_ip ~ '#bans' %}
-		{% include 'mod/ban_form.html' with { 'reasons': config.premade_ban_reasons } %}
+		{% include 'mod/ban_form.html' %}
 	</fieldset>
 {% endif %}
 

templates/post/fileinfo.html

@@ -1,13 +1,13 @@
 	{% if post.embed %}
 		{{ post.embed }}
     {% else %}
-	<div class="files {% if post.num_files > 1 %} multifile{% endif %}">
+    <div class="files">
     {% for file in post.files %}
         <div class="file{% if post.num_files > 1 %} multifile" style="width:{{ file.thumbwidth + 40 }}px"{% else %}"{% endif %}>
 	{% if file.file == 'deleted' %}
 		<img class="post-image deleted" src="{{ config.root }}{{ config.image_deleted }}" alt="" />
 	{% else %}
-		<p class="fileinfo"><span>File: <a href="{{ config.uri_img }}{{ file.file }}">{{ file.file }}</a></span><span class="unimportant">
+		<p class="fileinfo">File: <a href="{{ config.uri_img }}{{ file.file }}">{{ file.file }}</a> <span class="unimportant">
 		(
 			{% if file.thumb == 'spoiler' %}
 				{% trans %}Spoiler Image{% endtrans %}, 
@@ -21,19 +21,15 @@
 			{% endif %}
 			{% if config.show_filename and file.filename %}
 				, 
-				{% if file.thumb == 'spoiler' %}
+				{% if file.filename|length > config.max_filename_display %}
-					<a href="{{ config.uri_img }}{{ file.file|e|bidi_cleanup }}" download="{{ file.filename|e|bidi_cleanup }}" title="{% trans %}Spoiler Image{% endtrans %}">{% trans %}Spoiler Image{% endtrans %}</a>
+					<span class="postfilename" title="{{ file.filename|e|bidi_cleanup }}">{{ file.filename|truncate_filename(config.max_filename_display)|e|bidi_cleanup }}</span>
-				{% elseif file.filename|length > config.max_filename_display %}
-					<a href="{{ config.uri_img }}{{ file.file|e|bidi_cleanup }}" download="{{ file.filename|e|bidi_cleanup }}" title="Save as original filename: {{ file.filename|e|bidi_cleanup }}">{{ file.filename|truncate_filename(config.max_filename_display)|e|bidi_cleanup }}</a>
 				{% else %}
-					<a href="{{ config.uri_img }}{{ file.file|e|bidi_cleanup }}" download="{{ file.filename|e|bidi_cleanup }}" title="Save as original filename">{{ file.filename|e|bidi_cleanup }}</a>
+					<span class="postfilename">{{ file.filename|e|bidi_cleanup }}</span>
 				{% endif %}
 			{% endif %}
 		)
-		</span>
 		{% include "post/image_identification.html" %}
-		{% include "post/file_controls.html" %}
+		{% include "post/file_controls.html" %}</span></p>
-		</p>
 	{% include "post/image.html" with {'post':file} %}
 	{% endif %}
 </div>

templates/post/image.html

@@ -20,7 +20,7 @@
 					{{ config.file_thumb|sprintf(config.file_icons.default) }}
 				{% endif %}
 			"
-			 style="width:{{ post.thumbwidth }}px;height:{{ post.thumbheight }}px" {% if config.content_lazy_loading %}loading="lazy"{% endif %}
+			 style="width:{{ post.thumbwidth }}px;height:{{ post.thumbheight }}px"
 		>
 		</video>
 	{% else %}
@@ -39,7 +39,7 @@
 					{{ config.uri_thumb }}{{ post.thumb }}
 				{% endif %}
 			"
-			 style="width:{{ post.thumbwidth }}px;height:{{ post.thumbheight }}px" {% if config.content_lazy_loading %}loading="lazy"{% endif %} alt="" 
+			 style="width:{{ post.thumbwidth }}px;height:{{ post.thumbheight }}px" alt="" 
 		/>
 	{% endif %}
 </a>

templates/post_form.html

@@ -1,6 +1,9 @@
-<form name="post" onsubmit="return doPost(this);" enctype="multipart/form-data" action="{{ config.post_url }}" method="post">
+<form name="post" onsubmit="return dopost(this);" enctype="multipart/form-data" action="{{ config.post_url }}" method="post">
+{{ antibot.html() }}
 {% if id %}<input type="hidden" name="thread" value="{{ id }}">{% endif %}
+{{ antibot.html() }}
 <input type="hidden" name="board" value="{{ board.uri }}">
+{{ antibot.html() }}
 {% if current_page %}
 	<input type="hidden" name="page" value="{{ current_page }}">
 {% endif %}
@@ -9,9 +12,11 @@
 		{% if not config.field_disable_name or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri)) %}<tr>
 			<th>
 				{% trans %}Name{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<input type="text" name="name" size="25" maxlength="35" autocomplete="off"> {% if config.allow_no_country and config.country_flags %}<input id="no_country" name="no_country" type="checkbox"> <label for="no_country">{% trans %}Don't show my flag{% endtrans %}</label>{% endif %}
+				{{ antibot.html() }}
 			</td>
 		</tr>{% endif %}
 		{% if not config.field_disable_email or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri)) %}<tr>
@@ -21,6 +26,7 @@
 				{% else %}
 				{% trans %}Email{% endtrans %}
 				{% endif %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				{% if (mod and not post.mod|hasPermission(config.mod.bypass_field_disable, board.uri) and config.field_email_selectbox) or (not mod and config.field_email_selectbox) %}
@@ -33,14 +39,17 @@
 				{% else %}
 				<input type="text" name="email" size="25" maxlength="40" autocomplete="off">
 				{% endif %}
+				{{ antibot.html() }}
 				{% if not (not (config.field_disable_subject or (id and config.field_disable_reply_subject)) or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri))) %}
 				<input accesskey="s" style="margin-left:2px;" type="submit" name="post" value="{% if id %}{{ config.button_reply }}{% else %}{{ config.button_newtopic }}{% endif %}" />{% if config.spoiler_images %} <input id="spoiler" name="spoiler" type="checkbox"> <label for="spoiler">{% trans %}Spoiler Image{% endtrans %}</label>				{% endif %}
 				{% endif %}
+				{{ antibot.html() }}
 			</td>
 		</tr>{% endif %}
 		{% if not (config.field_disable_subject or (id and config.field_disable_reply_subject)) or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri)) %}<tr>
 			<th>
 				{% trans %}Subject{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<input style="float:left;" type="text" name="subject" size="25" maxlength="100" autocomplete="off">
@@ -51,9 +60,11 @@
 		<tr>
 			<th>
 				{% trans %}Comment{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<textarea name="body" id="body" rows="5" cols="35"></textarea>
+				{{ antibot.html() }}
 				{% if not (not (config.field_disable_subject or (id and config.field_disable_reply_subject)) or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri))) %}
 				{% if not (not config.field_disable_email or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri))) %}
 				<input accesskey="s" style="margin-left:2px;" type="submit" name="post" value="{% if id %}{{ config.button_reply }}{% else %}{{ config.button_newtopic }}{% endif %}" />{% if config.spoiler_images %} <input id="spoiler" name="spoiler" type="checkbox"> <label for="spoiler">{% trans %}Spoiler Image{% endtrans %}</label>{% endif %}
@@ -61,57 +72,57 @@
 				{% endif %}
 			</td>
 		</tr>
-		{% if config.captcha.provider == 'recaptcha' %}
+		{% if config.recaptcha %}
-		{% if config.captcha.dynamic %}
-		<tr id="captcha" style="display: none;">
-		{% else %}
-		<tr>
-		{% endif %}
-			<th>
-				{% trans %}Verification{% endtrans %}
-			</th>
-			<td>
-				<div class="g-recaptcha" data-sitekey="{{ config.captcha.recaptcha.sitekey }}"></div>
-			</td>
-		</tr>
-		{% endif %}
-		{% if config.captcha.provider == 'hcaptcha' %}
 		<tr>
 			<th>
 				{% trans %}Verification{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
-				<div class="h-captcha" data-sitekey="{{ config.captcha.hcaptcha.sitekey }}"></div>
+				<div class="g-recaptcha" data-sitekey="{{ config.recaptcha_public }}"></div>
+				{{ antibot.html() }}
 			</td>
 		</tr>
 		{% endif %}
-		{% if config.captcha.provider == 'native' %}
+		{% if config.hcaptcha %}
+		<tr>
+			<th>
+				{% trans %}Verification{% endtrans %}
+				{{ antibot.html() }}
+			</th>
+			<td>
+				<div class="h-captcha" data-sitekey="{{ config.hcaptcha_public }}"></div>
+				{{ antibot.html() }}
+			</td>
+		</tr>
+		{% endif %}
+		{% if config.captcha.enabled %}
 		<tr class='captcha'>
 			<th>
 				{% trans %}Verification{% endtrans %}
 			</th>
 			<td>
-				<script>load_captcha("{{ config.captcha.native.provider_get }}", "{{ config.captcha.native.extra }}");</script>
+				<script>load_captcha("{{ config.captcha.provider_get }}", "{{ config.captcha.extra }}");</script>
 				<noscript>
 					<input class='captcha_text' type='text' name='captcha_text' size='32' maxlength='6' autocomplete='off'>
 					<div class="captcha_html">
-						<img src="/{{ config.captcha.native.provider_get }}?mode=get&raw=1">
+						<img src="/{{ config.captcha.provider_get }}?mode=get&raw=1">
 					</div>
 				</noscript>
 			</td>
 		</tr>
-		{% elseif config.captcha.native.new_thread_capt %}
+			{% elseif config.new_thread_capt %}
  			{% if not id %} 
  			<tr class='captcha'>
                         <th>
                                 {% trans %}Verification{% endtrans %}
                         </th>
                         <td>
-                                <script>load_captcha("{{ config.captcha.native.provider_get }}", "{{ config.captcha.native.extra }}");</script>
+                                <script>load_captcha("{{ config.captcha.provider_get }}", "{{ config.captcha.extra }}");</script>
 				<noscript>
 					<input class='captcha_text' type='text' name='captcha_text' size='32' maxlength='6' autocomplete='off'>
 					<div class="captcha_html">
-						<img src="/{{ config.captcha.native.provider_get }}?mode=get&raw=1">
+						<img src="/{{ config.captcha.provider_get }}?mode=get&raw=1">
 					</div>
 				</noscript>
                         </td>
@@ -158,12 +169,14 @@
 						<input style="display:inline" type="text" id="file_url" name="file_url" size="35">
 					</div>
 				{% endif %}
+				{{ antibot.html() }}
 			</td>
 		</tr>
 		{% if config.enable_embedding %}
 		<tr id="upload_embed">
 			<th>
 				{% trans %}Embed{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<input type="text" name="embed" value="" size="30" maxlength="120" autocomplete="off">
@@ -194,21 +207,27 @@
 		{% if not config.field_disable_password or (mod and post.mod|hasPermission(config.mod.bypass_field_disable, board.uri)) %}<tr>
 			<th>
 				{% trans %}Password{% endtrans %}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<input type="text" name="password" value="" size="12" maxlength="18" autocomplete="off"> 
 				<span class="unimportant">{% trans %}(For file deletion.){% endtrans %}</span>
+				{{ antibot.html() }}
 			</td>
 		</tr>{% endif %}
 		{% if config.simple_spam and not id %}<tr>
 			<th>
 				{{ config.simple_spam.question }}
+				{{ antibot.html() }}
 			</th>
 			<td>
 				<input type="text" name="simple_spam" value="" size="12" maxlength="18" autocomplete="off"> 
+				{{ antibot.html() }}
 			</td>
 		</tr>{% endif %}
 	</table>
+{{ antibot.html(true) }}
+<input type="hidden" name="hash" value="{{ antibot.hash() }}">
 </form>
 
 <script type="text/javascript">{% verbatim %}

templates/posts.sql

@@ -13,7 +13,7 @@ CREATE TABLE IF NOT EXISTS ``posts_{{ board }}`` (
    `files` text DEFAULT NULL,
    `num_files` int(11) DEFAULT 0,
    `filehash` text CHARACTER SET ascii,
-   `password` varchar(64) DEFAULT NULL,
+   `password` varchar(20) DEFAULT NULL,
    `ip` varchar(39) CHARACTER SET ascii NOT NULL,
    `sticky` int(1) NOT NULL,
    `locked` int(1) NOT NULL,

templates/themes/catalog/catalog.html

@@ -51,7 +51,7 @@
 						{% else %}
 							<img src="{{post.file}}"
 						{% endif %}
-						id="img-{{ post.id }}" data-subject="{% if post.subject %}{{ post.subject|e }}{% endif %}" data-name="{{ post.name|e }}" data-muhdifference="{{ post.muhdifference }}" class="{{post.board}} thread-image" title="{{post.bump|date('%b %d %H:%M')}} {% if config.content_lazy_loading %}loading="lazy"{% endif %}">
+						 id="img-{{ post.id }}" data-subject="{% if post.subject %}{{ post.subject|e }}{% endif %}" data-name="{{ post.name|e }}" data-muhdifference="{{ post.muhdifference }}" class="{{post.board}} thread-image" title="{{post.bump|date('M d H:i')}}">
 					</a>
 						<div class="replies">
 							<strong>R: {{ post.reply_count }} / I: {{ post.image_count }}{% if post.sticky %} (sticky){% endif %}</strong>
@@ -80,7 +80,7 @@
 			{% endverbatim %}
 			{% for name, uri in config.stylesheets %}{% verbatim %}'{% endverbatim %}{{ name|addslashes }}{% verbatim %}' : '{% endverbatim %}/stylesheets/{{ uri|addslashes }}{% verbatim %}',
 			{% endverbatim %}{% endfor %}{% verbatim %}
-		}; onReady(init);
+		}; onready(init);
 	{% endverbatim %}</script>
 
 	<script type="text/javascript">{% verbatim %}

templates/themes/catalog/info.php

@@ -17,12 +17,17 @@
 		'default' => 'Catalog'
 	);
 	
+	$__boards = listBoards();
+	$__default_boards = Array();
+	foreach ($__boards as $__board)
+		$__default_boards[] = $__board['uri'];
+	
 	$theme['config'][] = Array(
 		'title' => 'Included boards',
 		'name' => 'boards',
 		'type' => 'text',
 		'comment' => '(space seperated)',
-		'default' => '*'
+		'default' => implode(' ', $__default_boards)
 	);
 	
 	$theme['config'][] = Array(

templates/themes/catalog/theme.php

@@ -1,15 +1,6 @@
 <?php
 	require 'info.php';
 
-	function get_all_boards() {
-		$boards = [];
-		$query = query("SELECT uri FROM ``boards``") or error(db_error());
-		while ($board = $query->fetch(PDO::FETCH_ASSOC)) {
-			$boards[] = $board['uri'];
-		}
-		return $boards;
-	}
-
 	function catalog_build($action, $settings, $board) {
 		global $config;
 
@@ -22,11 +13,6 @@
 
 		$boards = explode(' ', $settings['boards']);
 
-		if (in_array('*', $boards)) {
-			$boards = get_all_boards();
-		}
-
-
 		if ($action == 'all') {
 			foreach ($boards as $board) {
 				$b = new Catalog();

templates/themes/index/index.html

@@ -34,28 +34,17 @@
 		</ul>
 	    </fieldset>
 	    <br>
-		{% if settings.description or settings.imageofnow or settings.quoteofnow or settings.videoofnow %}
 	    <div class="mainBox">
 	        <br>
-				{% if settings.description %}
 	        <div class="description">{{ settings.description }}</div>
 	        <br>
-				{% endif %}
-				{% if settings.imageofnow %}
 	        <img class="imageofnow" src="{{ settings.imageofnow }}">
 	        <br>
-				{% endif %}
-				{% if settings.quoteofnow %}
 	        <div class="quoteofnow">{{ settings.quoteofnow }}</div>
 	        <br>
-				{% endif %}
-				{% if settings.videoofnow %}
 	        <iframe class ="videoofnow" width="560" height="315" src="{{ settings.videoofnow }}"></iframe>
 	        <br>
-				{% endif %}
 	    </div>
-		{% endif %}
-	
 	    <div class="ban">
 		{% if news|length == 0 %}
 			<p style="text-align:center" class="unimportant">(No news to show.)</p>

templates/themes/index/info.php

@@ -74,19 +74,12 @@
 	);
 	
 	$theme['config'][] = Array(
-		'title' => 'Excluded boards (recent posts)',
+		'title' => 'Excluded boards',
 		'name' => 'exclude',
 		'type' => 'text',
 		'comment' => '(space seperated)'
 	);
 	
-	$theme['config'][] = Array(
-		'title' => 'Excluded boards (boardlist)',
-		'name' => 'excludeboardlist',
-		'type' => 'text',
-		'comment' => '(space seperated)'
-	);
-	
 	$theme['config'][] = Array(
 		'title' => '# of recent images',
 		'name' => 'limit_images',

templates/themes/index/theme.php

@@ -159,13 +159,6 @@
 			$query = query("SELECT * FROM ``news`` ORDER BY `time` DESC" . ($settings['no_recent'] ? ' LIMIT ' . $settings['no_recent'] : '')) or error(db_error());
 			$news = $query->fetchAll(PDO::FETCH_ASSOC);
 			
-			// Excluded boards for the boardlist
-			$excluded_boards = isset($settings['excludeboardlist']) ? explode(' ', $settings['excludeboardlist']) : [];
-			$boardlist = array_filter($boards, function($board) use ($excluded_boards) {
-				return !in_array($board['uri'], $excluded_boards);
-			});
-			
-			
 			return Element('themes/index/index.html', Array(
 				'settings' => $settings,
 				'config' => $config,
@@ -174,7 +167,7 @@
 				'recent_posts' => $recent_posts,
 				'stats' => $stats,
 				'news' => $news,
-				'boards' => $boardlist
+				'boards' => listBoards()
 			));
 		}
 	};

templates/themes/recent/recent.html

@@ -4,11 +4,11 @@
 <head>
         <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
 	<title>{{ settings.title }}</title>
-	<link rel="stylesheet" media="screen" href="{{ config.url_stylesheet }}?v={{ config.resource_version }}"/>
+	<link rel="stylesheet" media="screen" href="{{ config.url_stylesheet }}"/>
-	<link rel="stylesheet" media="screen" href="{{ config.root }}{{ settings.css }}?v={{ config.resource_version }}"/>
+	<link rel="stylesheet" media="screen" href="{{ config.root }}{{ settings.css }}"/>
 	{% if config.url_favicon %}<link rel="shortcut icon" href="{{ config.url_favicon }}" />{% endif %}
-	{% if config.default_stylesheet.1 != '' %}<link rel="stylesheet" type="text/css" id="stylesheet" href="{{ config.uri_stylesheets }}{{ config.default_stylesheet.1 }}?v={{ config.resource_version }}">{% endif %}
+	{% if config.default_stylesheet.1 != '' %}<link rel="stylesheet" type="text/css" id="stylesheet" href="{{ config.uri_stylesheets }}{{ config.default_stylesheet.1 }}">{% endif %}
-	{% if config.font_awesome %}<link rel="stylesheet" href="{{ config.root }}{{ config.font_awesome_css }}?v={{ config.resource_version }}">{% endif %}
+	{% if config.font_awesome %}<link rel="stylesheet" href="{{ config.root }}{{ config.font_awesome_css }}">{% endif %}
 	{% include 'header.html' %}
 </head>
 <body>

templates/thread.html

@@ -16,7 +16,7 @@
 	<meta name="description" content="{{ board.url }} - {{ board.title|e }} - {{ meta_subject }}" />
 	<meta name="twitter:card" value="summary">
 	<meta name="twitter:title" content="{{ meta_subject }}" />
-	<meta name="twitter:description" content="{{ thread.body_nomarkup|remove_modifiers|e }}" />
+	<meta name="twitter:description" content="{{ thread.body_nomarkup|e }}" />
 	{% if thread.files.0.thumb %}<meta name="twitter:image" content="{{ config.domain }}/{{ board.uri }}/{{ config.dir.thumb }}{{ thread.files.0.thumb }}" />{% endif %}
 	<meta property="og:title" content="{{ meta_subject }}" />
 	<meta property="og:type" content="article" />

tools/hash-passwords.php

@@ -1,17 +0,0 @@
-<?php
-
-require_once dirname(__FILE__) . '/inc/cli.php';
-
-$boards = listBoards();
-		foreach ($boards as &$_board) {
-			query(sprintf('ALTER TABLE ``posts_%s`` MODIFY `password` varchar(64) DEFAULT NULL;', $_board['uri'])) or error(db_error());
-		    $query = prepare(sprintf("SELECT DISTINCT `password` FROM ``posts_%s``", $_board['uri']));
-            $query->execute() or error(db_error($query));
-
-		    while($entry = $query->fetch(PDO::FETCH_ASSOC)) {
-		        $update_query = prepare(sprintf("UPDATE ``posts_%s`` SET `password` = :password WHERE `password` = :password_org", $_board['uri']));
-		        $update_query->bindValue(':password', hashPassword($entry['password']));
-		        $update_query->bindValue(':password_org', $entry['password']);
-		        $update_query->execute() or  error(db_error());
-		    }
-		}

tools/maintenance.php

@@ -1,40 +0,0 @@
-<?php
-/**
- * Performs maintenance tasks. Invoke this periodically if the auto_maintenance configuration option is turned off.
- */
-
-require dirname(__FILE__) . '/inc/cli.php';
-
-echo "Clearing expired bans...\n";
-$start = microtime(true);
-$deleted_count = Bans::purge($config['require_ban_view'], $config['purge_bans']);
-$delta = microtime(true) - $start;
-echo "Deleted $deleted_count expired bans in $delta seconds!\n";
-$time_tot = $delta;
-$deleted_tot = $deleted_count;
-
-echo "Clearing old antispam...\n";
-$start = microtime(true);
-$deleted_count = purge_old_antispam();
-$delta = microtime(true) - $start;
-echo "Deleted $deleted_count expired antispam in $delta seconds!\n";
-$time_tot = $delta;
-$deleted_tot = $deleted_count;
-
-if ($config['cache']['enabled'] === 'fs') {
-	$fs_cache = new Vichan\Data\Driver\FsCacheDriver(
-		$config['cache']['prefix'],
-		"tmp/cache/{$config['cache']['prefix']}",
-		'.lock',
-		false
-	);
-	$start = microtime(true);
-	$fs_cache->collect();
-	$delta = microtime(true) - $start;
-	echo "Deleted $deleted_count expired filesystem cache items in $delta seconds!\n";
-	$time_tot = $delta;
-	$deleted_tot = $deleted_count;
-}
-
-$time_tot = number_format((float)$time_tot, 4, '.', '');
-modLog("Deleted $deleted_tot expired entries in {$time_tot}s with maintenance tool");