From 37658f18174da959f69bf22329a35bd9d131aee3 Mon Sep 17 00:00:00 2001 From: Zankaria Date: Fri, 17 May 2024 14:13:40 +0200 Subject: [PATCH] install.php: fix HTTPS check --- install.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/install.php b/install.php index abdd9337..b0403420 100644 --- a/install.php +++ b/install.php @@ -689,10 +689,8 @@ if ($step == 0) { echo Element('page.html', $page); } elseif ($step == 1) { - //The HTTPS check doesn't work properly when in those arrays, so let's run it here and pass along the result during the actual check. - if (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off') { - $httpsvalue = true; - } + // The HTTPS check doesn't work properly when in those arrays, so let's run it here and pass along the result during the actual check. + $httpsvalue = !empty($_SERVER['HTTPS'] && $_SERVER['HTTPS'] !== 'off'; $page['title'] = 'Pre-installation test'; $can_exec = true; @@ -874,7 +872,7 @@ if ($step == 0) { array( 'category' => 'Misc', 'name' => 'HTTPS not being used', - 'result' => $httpsvalue = true, + 'result' => $httpsvalue, 'required' => false, 'message' => 'You are not currently using https for vichan, or at least for your backend server. If this intentional, add "$config[\'cookies\'][\'secure_login_only\'] = 0;" (or 1 if using a proxy) on a new line under "Additional configuration" on the next page.' ),