From 12b4356a6a46cd72d47dbfba61f5fd112c5afdde Mon Sep 17 00:00:00 2001 From: Zankaria Date: Fri, 25 Apr 2025 17:58:48 +0200 Subject: [PATCH 1/4] cache.php: use local vars --- inc/cache.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/inc/cache.php b/inc/cache.php index 33e03746..6e81039a 100644 --- a/inc/cache.php +++ b/inc/cache.php @@ -12,10 +12,10 @@ defined('TINYBOARD') or exit; class Cache { private static function buildCache(): CacheDriver { global $config; - // Determine if Redis is configured via environment variables - getenv('VICHAN_CACHE_ENGINE') && $config['cache']['enabled'] = getenv('VICHAN_CACHE_ENGINE'); + // Determine if the cache engine is configured via environment variables. + $engine = \getenv('VICHAN_CACHE_ENGINE') ?: $config['cache']['enabled']; - switch ($config['cache']['enabled']) { + switch ($engine) { case 'memcached': return new MemcachedCacheDriver( $config['cache']['prefix'], @@ -31,7 +31,7 @@ class Cache { $port = getenv('VICHAN_CACHE_PORT') ?: $port; $password = getenv('VICHAN_CACHE_PASSWORD') ?: $password; $database = getenv('VICHAN_CACHE_DATABASE') ?: $database; - + return new RedisCacheDriver( $config['cache']['prefix'], $host, From 553c925f404557ad6568f66570e9019f297e84cd Mon Sep 17 00:00:00 2001 From: Zankaria Date: Fri, 25 Apr 2025 17:59:17 +0200 Subject: [PATCH 2/4] template.php: use PHP style comments --- inc/template.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/inc/template.php b/inc/template.php index 47b7bc0f..db206ab1 100644 --- a/inc/template.php +++ b/inc/template.php @@ -226,11 +226,11 @@ function twig_secure_link($href) { return $href . '/' . make_secure_link_token($href); } -// /* -// * ==================== -// * Container Detection -// * =================== -// */ +/* + * ==================== + * Container Detection + * =================== + */ function twig_check_container() { global $config; From 2c023ee644bfa14aae5ae4e5beaee354f79c5f27 Mon Sep 17 00:00:00 2001 From: Zankaria Date: Fri, 25 Apr 2025 18:00:54 +0200 Subject: [PATCH 3/4] templates.php: use local vars for container checking --- inc/template.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/inc/template.php b/inc/template.php index db206ab1..fbe8e9b3 100644 --- a/inc/template.php +++ b/inc/template.php @@ -233,11 +233,11 @@ function twig_secure_link($href) { */ function twig_check_container() { - global $config; - $isDocker = is_file("/.dockerenv") || is_file("/run/.containerenv"); - $isKubernetes = is_file("/var/run/secrets/kubernetes.io/serviceaccount/namespace"); - $config['is_container'] = $isDocker || $isKubernetes ? true : false; - $config['is_docker'] = $isDocker; - $config['is_kubernetes'] = $isKubernetes; - return $config['is_container']; -} \ No newline at end of file + static $is_container = null; + if ($is_container === null) { + $is_docker = \is_file("/.dockerenv") || \is_file("/run/.containerenv"); + $is_kubernetes = \is_file("/var/run/secrets/kubernetes.io/serviceaccount/namespace"); + $is_container = $is_docker || $is_kubernetes; + } + return $is_container; +} From f959e790fd162f6c9be3b7da24a35fba3f5479f1 Mon Sep 17 00:00:00 2001 From: Zankaria Date: Fri, 25 Apr 2025 18:02:12 +0200 Subject: [PATCH 4/4] template.php: expose check_container function in twig templates --- inc/template.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inc/template.php b/inc/template.php index fbe8e9b3..11d9ea10 100644 --- a/inc/template.php +++ b/inc/template.php @@ -142,7 +142,8 @@ class Tinyboard extends Twig\Extension\AbstractExtension new Twig\TwigFunction('ratio', 'twig_ratio_function'), new Twig\TwigFunction('secure_link_confirm', 'twig_secure_link_confirm'), new Twig\TwigFunction('secure_link', 'twig_secure_link'), - new Twig\TwigFunction('link_for', 'link_for') + new Twig\TwigFunction('link_for', 'link_for'), + new Twig\TwigFunction('check_container', 'twig_check_container') ); }