harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Handle excessively long email addresses in the signup form.

Browse Source
This commit is contained in:
Pēteris Caune 2020-08-17 11:31:24 +03:00
parent 8223b0c402
commit ffafc16fe5
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -7,6 +7,9 @@ All notable changes to this project will be documented in this file.
- Django 3.1 - Django 3.1
- Handle status callbacks from Twilio, show delivery failures in Integrations - Handle status callbacks from Twilio, show delivery failures in Integrations
## Bug Fixes
- Handle excessively long email addresses in the signup form.
## v1.16.0 - 2020-08-04 ## v1.16.0 - 2020-08-04
### Improvements ### Improvements

3
hc/accounts/forms.py
View File

@ -20,6 +20,9 @@ class AvailableEmailForm(forms.Form):
def clean_identity(self): def clean_identity(self):
v = self.cleaned_data["identity"] v = self.cleaned_data["identity"]
if len(v) > 254:
raise forms.ValidationError("Address is too long.")
if User.objects.filter(email=v).exists(): if User.objects.filter(email=v).exists():
raise forms.ValidationError( raise forms.ValidationError(
"An account with this email address already exists." "An account with this email address already exists."

8
hc/accounts/tests/test_signup.py
View File

@ -81,3 +81,11 @@ class SignupTestCase(TestCase):
form = {"identity": "alice at example org"} form = {"identity": "alice at example org"}
r = self.client.post("/accounts/signup/", form) r = self.client.post("/accounts/signup/", form)
self.assertContains(r, "Enter a valid email address") self.assertContains(r, "Enter a valid email address")
def test_it_checks_length(self):
aaa = "a" * 300
form = {"identity": f"alice+{aaa}@example.org"}
r = self.client.post("/accounts/signup/", form)
self.assertContains(r, "Address is too long.")
self.assertFalse(User.objects.exists())