harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

hc.api.views.bounce updates Channel.last_error

Browse Source
This commit is contained in:
Pēteris Caune 2020-01-08 11:14:34 +02:00
parent c521b44d20
commit b8108906f4
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hc/api/tests/test_bounce.py
View File

@ -29,6 +29,7 @@ class BounceTestCase(BaseTestCase):
self.channel.refresh_from_db() self.channel.refresh_from_db()
self.assertFalse(self.channel.email_verified) self.assertFalse(self.channel.email_verified)
self.assertEqual(self.channel.last_error, "foo")
def test_it_checks_ttl(self): def test_it_checks_ttl(self):
self.n.created = self.n.created - timedelta(minutes=60) self.n.created = self.n.created - timedelta(minutes=60)

6
hc/api/views.py
View File

@ -272,9 +272,13 @@ def bounce(request, code):
notification.error = request.body.decode()[:200] notification.error = request.body.decode()[:200]
notification.save() notification.save()
notification.channel.last_error = notification.error
if request.GET.get("type") in (None, "Permanent"): if request.GET.get("type") in (None, "Permanent"):
# For permanent bounces, mark the channel as not verified, so we
# will not try to deliver to it again.
notification.channel.email_verified = False notification.channel.email_verified = False
notification.channel.save()
notification.channel.save()
return HttpResponse() return HttpResponse()