harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Don't escape HTML in the subject line of notification emails

Browse Source
This commit is contained in:
Pēteris Caune 2020-03-25 17:18:14 +02:00
parent 4a43ed59fc
commit 9d2cf4f008
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
### Bug Fixes ### Bug Fixes
- "Get a single check" API call now supports read-only API keys (#346) - "Get a single check" API call now supports read-only API keys (#346)
- Don't escape HTML in the subject line of notification emails
## v1.14.0 - 2020-03-23 ## v1.14.0 - 2020-03-23

8
hc/api/tests/test_notify.py
View File

@ -345,6 +345,14 @@ class NotifyTestCase(BaseTestCase):
self.assertEqual(Notification.objects.count(), 0) self.assertEqual(Notification.objects.count(), 0)
self.assertEqual(len(mail.outbox), 0) self.assertEqual(len(mail.outbox), 0)
def test_email_handles_amperstand(self):
self._setup_data("email", "alice@example.org")
self.check.name = "Foo & Bar"
self.channel.notify(self.check)
email = mail.outbox[0]
self.assertEqual(email.subject, "DOWN | Foo & Bar")
@patch("hc.api.transports.requests.request") @patch("hc.api.transports.requests.request")
def test_pd(self, mock_post): def test_pd(self, mock_post):
self._setup_data("pd", "123") self._setup_data("pd", "123")

2
templates/emails/alert-subject.html
View File

@ -1,2 +1,2 @@
{{ check.status|upper }} | {{ check.name_then_code }} {{ check.status|upper }} | {{ check.name_then_code|safe }}