harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Remove startup check for update_alert_after trigger, remove drop_triggers command.

Browse Source
This commit is contained in:
Pēteris Caune 2017-09-12 12:05:58 +03:00
parent 94556f2893
commit 8d0a2f2eaf
2 changed files with 0 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
hc/api/management/commands/droptriggers.py
View File

@ -1,37 +0,0 @@
from django.core.management.base import BaseCommand
from django.db import connection
def _pg(cursor):
cursor.execute("""
DROP TRIGGER IF EXISTS update_alert_after ON api_check;
""")
def _mysql(cursor):
cursor.execute("""
DROP TRIGGER IF EXISTS update_alert_after;
""")
def _sqlite(cursor):
cursor.execute("""
DROP TRIGGER IF EXISTS update_alert_after;
""")
class Command(BaseCommand):
help = 'Drops the `update_alert_after` trigger'
requires_system_checks = False
def handle(self, *args, **options):
with connection.cursor() as cursor:
if connection.vendor == "postgresql":
_pg(cursor)
return "Dropped PostgreSQL trigger"
if connection.vendor == "mysql":
_mysql(cursor)
return "Dropped MySQL trigger"
if connection.vendor == "sqlite":
_sqlite(cursor)
return "Dropped SQLite trigger"

23
hc/api/models.py
View File

@ -186,29 +186,6 @@ class Check(models.Model):
def has_confirmation_link(self):
return "confirm" in self.last_ping_body.lower()
@classmethod
def check(cls, **kwargs):
errors = super(Check, cls).check(**kwargs)
trigger_detected = False
try:
dummy = Check(last_ping=timezone.now())
dummy.save()
dummy.refresh_from_db()
trigger_detected = bool(dummy.alert_after)
dummy.delete()
except:
pass
if trigger_detected:
err = Warning(
"Obsolete 'update_alert_after' trigger exists in database.",
hint="Please remove the trigger with 'manage.py droptriggers'",
id="hc.api.E001")
errors.append(err)
return errors
class Ping(models.Model):
n = models.IntegerField(null=True)