harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize the "Update Check" API call

Browse Source 
In the "Update Check" API call, if no fields have changed,
don't save the changes to the database.
This commit is contained in:
Pēteris Caune 2020-10-14 18:03:13 +03:00
parent 0e77064c44
commit 7e56156d32
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
1 changed files with 36 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
hc/api/views.py
View File

@ -97,36 +97,58 @@ def _update(check, spec):
new_channels.add(matches[0]) new_channels.add(matches[0])
if "name" in spec: need_save = False
if check.pk is None:
# Empty pk means we're inserting a new check,
# and so do need to save() it:
need_save = True
if "name" in spec and check.name != spec["name"]:
check.name = spec["name"] check.name = spec["name"]
need_save = True
if "tags" in spec: if "tags" in spec and check.tags != spec["tags"]:
check.tags = spec["tags"] check.tags = spec["tags"]
need_save = True
if "desc" in spec: if "desc" in spec and check.desc != spec["desc"]:
check.desc = spec["desc"] check.desc = spec["desc"]
need_save = True
if "manual_resume" in spec: if "manual_resume" in spec and check.manual_resume != spec["manual_resume"]:
check.manual_resume = spec["manual_resume"] check.manual_resume = spec["manual_resume"]
need_save = True
if "methods" in spec: if "methods" in spec and check.methods != spec["methods"]:
check.methods = spec["methods"] check.methods = spec["methods"]
need_save = True
if "timeout" in spec and "schedule" not in spec: if "timeout" in spec and "schedule" not in spec:
check.kind = "simple" new_timeout = td(seconds=spec["timeout"])
check.timeout = td(seconds=spec["timeout"]) if check.kind != "simple" or check.timeout != new_timeout:
check.kind = "simple"
check.timeout = new_timeout
need_save = True
if "grace" in spec: if "grace" in spec:
check.grace = td(seconds=spec["grace"]) new_grace = td(seconds=spec["grace"])
if check.grace != new_grace:
check.grace = new_grace
need_save = True
if "schedule" in spec: if "schedule" in spec:
check.kind = "cron" if check.kind != "cron" or check.schedule != spec["schedule"]:
check.schedule = spec["schedule"] check.kind = "cron"
if "tz" in spec: check.schedule = spec["schedule"]
check.tz = spec["tz"] need_save = True
check.alert_after = check.going_down_after() if "tz" in spec and check.tz != spec["tz"]:
check.save() check.tz = spec["tz"]
need_save = True
if need_save:
check.alert_after = check.going_down_after()
check.save()
# This needs to be done after saving the check, because of # This needs to be done after saving the check, because of
# the M2M relation between checks and channels: # the M2M relation between checks and channels: