harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Revert deterministic username generation feature – it causes problems when users change their email address. See #290 for details.

Browse Source
This commit is contained in:
Pēteris Caune 2019-10-12 11:37:06 +03:00
parent 6cd4e494e8
commit 391921d8af
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -10,7 +10,6 @@ All notable changes to this project will be documented in this file.
- Add Go usage example - Add Go usage example
### Bug Fixes ### Bug Fixes
- Usernames now are uuid3(const, email). Prevents multiple accts with same email (#290)
- Prevent double-clicking the submit button in signup form - Prevent double-clicking the submit button in signup form
- Upgrade to Django 2.2.6 – fixes sqlite migrations (#284) - Upgrade to Django 2.2.6 – fixes sqlite migrations (#284)

7
hc/accounts/views.py
View File

@ -43,8 +43,6 @@ NEXT_WHITELIST = (
"hc-add-pushover", "hc-add-pushover",
) )
NAMESPACE_HC = uuid.UUID("2b25afdf-ce1a-4fa3-adf2-592e35f27fa9")
def _is_whitelisted(path): def _is_whitelisted(path):
try: try:
@ -56,10 +54,7 @@ def _is_whitelisted(path):
def _make_user(email, with_project=True): def _make_user(email, with_project=True):
# Generate username from email in a deterministic way. username = str(uuid.uuid4())[:30]
# Since the database has an uniqueness constraint on username,
# this makes sure that emails also are unique.
username = str(uuid.uuid3(NAMESPACE_HC, email))
user = User(username=username, email=email) user = User(username=username, email=email)
user.set_unusable_password() user.set_unusable_password()
user.save() user.save()