Don't let users clone checks if the account is at check limit

CHANGELOG.md

@@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file.
 ### Bug Fixes
 - "Get a single check" API call now supports read-only API keys (#346)
 - Don't escape HTML in the subject line of notification emails
+- Don't let users clone checks if the account is at check limit
 
 ## v1.14.0 - 2020-03-23
 

hc/front/tests/test_copy.py

@@ -16,3 +16,11 @@ class CopyCheckTestCase(BaseTestCase):
         r = self.client.post(self.copy_url, follow=True)
         self.assertContains(r, "This is a brand new check")
         self.assertContains(r, "Foo (copy)")
+
+    def test_it_obeys_limit(self):
+        self.profile.check_limit = 0
+        self.profile.save()
+
+        self.client.login(username="alice@example.org", password="password")
+        r = self.client.post(self.copy_url)
+        self.assertEqual(r.status_code, 400)

hc/front/views.py

@@ -556,6 +556,9 @@ def transfer(request, code):
 def copy(request, code):
     check = _get_check_for_user(request, code)
 
+    if check.project.num_checks_available() <= 0:
+        return HttpResponseBadRequest()
+
     copied = Check(project=check.project)
     copied.name = check.name + " (copy)"
     copied.desc, copied.tags = check.desc, check.tags

templates/front/details.html

@@ -223,11 +223,13 @@
             <p>Copy, Transfer, or permanently remove this check.</p>
 
             <div class="text-right">
+                {% if project.num_checks_available > 0 %}
                 <button
                     id="copy-btn"
                     data-toggle="modal"
                     data-target="#copy-modal"
                     class="btn btn-sm btn-default">Create a Copy&hellip;</button>
+                {% endif %}
                 <button
                     id="transfer-btn"
                     data-toggle="modal"