harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Don't log delivery notifications for unverified email addresses.

Browse Source
This commit is contained in:
Pēteris Caune 2017-11-04 17:52:11 +02:00
parent ddd940688e
commit 363f219671
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hc/api/tests/test_notify.py
View File

@ -162,9 +162,9 @@ class NotifyTestCase(BaseTestCase):
self._setup_data("email", "alice@example.org", email_verified=False) self._setup_data("email", "alice@example.org", email_verified=False)
self.channel.notify(self.check) self.channel.notify(self.check)
assert Notification.objects.count() == 1 # If an email is not verified, it should be skipped over
n = Notification.objects.first() # without logging a notification:
self.assertEqual(n.error, "Email not verified") self.assertEqual(Notification.objects.count(), 0)
self.assertEqual(len(mail.outbox), 0) self.assertEqual(len(mail.outbox), 0)
@patch("hc.api.transports.requests.request") @patch("hc.api.transports.requests.request")

3
hc/api/transports.py
View File

@ -70,6 +70,9 @@ class Email(Transport):
emails.alert(self.channel.value, ctx, headers) emails.alert(self.channel.value, ctx, headers)
def is_noop(self, check):
return not self.channel.email_verified
class HttpTransport(Transport): class HttpTransport(Transport):