harmacist/healthchecks
1
0
Fork 0
forked from GithubBackups/healthchecks
Code Issues Pull Requests Projects Releases Wiki Activity

Show a warning when running with DEBUG=True. Fixes #189

Browse Source
This commit is contained in:
Pēteris Caune 2018-11-06 10:48:59 +02:00
parent 5ef67e8bbf
commit 0ece2664ac
No known key found for this signature in database
GPG Key ID: E28D7679E9A9EDE2
5 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
- Add search box in the "My Checks" page - Add search box in the "My Checks" page
- Add read-only API key support - Add read-only API key support
- Remove Profile.bill_to field (obsolete) - Remove Profile.bill_to field (obsolete)
- Show a warning when running with DEBUG=True
### Bug Fixes ### Bug Fixes
- During DST transition, handle ambiguous dates as pre-transition - During DST transition, handle ambiguous dates as pre-transition

12
hc/front/templatetags/hc_extras.py
View File

@ -35,6 +35,18 @@ def site_root():
return settings.SITE_ROOT return settings.SITE_ROOT
@register.simple_tag
def debug_warning():
if settings.DEBUG:
return mark_safe("""
<div id="debug-warning">
Running in debug mode, do not use in production.
</div>
""")
return ""
def naturalize_int_match(match): def naturalize_int_match(match):
return '%08d' % (int(match.group(0)),) return '%08d' % (int(match.group(0)),)

8
hc/front/tests/test_basics.py
View File

@ -1,14 +1,18 @@
from django.test import TestCase from django.test import TestCase
from django.test.utils import override_settings from django.test.utils import override_settings
from hc.api.models import Check
class BasicsTestCase(TestCase): class BasicsTestCase(TestCase):
def test_it_shows_welcome(self): def test_it_shows_welcome(self):
r = self.client.get("/") r = self.client.get("/")
self.assertContains(r, "Get Notified", status_code=200) self.assertContains(r, "Get Notified", status_code=200)
self.assertNotContains(r, "do not use in production")
@override_settings(DEBUG=True)
def test_it_shows_debug_warning(self):
r = self.client.get("/")
self.assertContains(r, "do not use in production")
@override_settings(REGISTRATION_OPEN=False) @override_settings(REGISTRATION_OPEN=False)
def test_it_obeys_registration_open(self): def test_it_obeys_registration_open(self):

7
static/css/base.css
View File

@ -93,3 +93,10 @@ pre {
.jumbotron p { .jumbotron p {
font-weight: 300; font-weight: 300;
} }
#debug-warning {
background: #eeeeee;
text-align: center;
font-size: small;
padding: 2px 0;
}

1
templates/base.html
View File

@ -46,6 +46,7 @@
{% endcompress %} {% endcompress %}
</head> </head>
<body class="page-{{ page }}"> <body class="page-{{ page }}">
{% debug_warning %}
<nav class="navbar navbar-default"> <nav class="navbar navbar-default">
<div class="container{% if page == "checks" or page == "details" %}-fluid{% endif %}"> <div class="container{% if page == "checks" or page == "details" %}-fluid{% endif %}">
<div class="navbar-header"> <div class="navbar-header">